[jira] [Commented] (HTTPCLIENT-1765) SSLConnectionSocketFactory uses connectTimeout for read timeout

2019-08-22 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913139#comment-16913139 ] Oleg Kalnichevski commented on HTTPCLIENT-1765: --- [~northfolk28] In your code you do

[jira] [Created] (HTTPCORE-594) Apache HttpCore 4.4.1 reached EoS

2019-08-22 Thread Gonzalo Suardiaz (Jira)
Gonzalo Suardiaz created HTTPCORE-594: - Summary: Apache HttpCore 4.4.1 reached EoS Key: HTTPCORE-594 URL: https://issues.apache.org/jira/browse/HTTPCORE-594 Project: HttpComponents HttpCore

[GitHub] [httpcomponents-client] ok2c merged pull request #161: Add RequestConfig builder javadocs

2019-08-22 Thread GitBox
ok2c merged pull request #161: Add RequestConfig builder javadocs URL: https://github.com/apache/httpcomponents-client/pull/161 This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (HTTPCORE-594) Apache HttpCore 4.4.1 reached EoS

2019-08-22 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCORE-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913142#comment-16913142 ] Oleg Kalnichevski commented on HTTPCORE-594: [~egonsur] I suppose you want this issue

[GitHub] [httpcomponents-client] ok2c commented on issue #161: Add RequestConfig builder javadocs

2019-08-22 Thread GitBox
ok2c commented on issue #161: Add RequestConfig builder javadocs URL: https://github.com/apache/httpcomponents-client/pull/161#issuecomment-523797831 @rhernandez35 Thank you for contributing this PR. It would really cool if you could make similar changes to the config classes in HttpCore.

[jira] [Commented] (HTTPCLIENT-1765) SSLConnectionSocketFactory uses connectTimeout for read timeout

2019-08-22 Thread Jang Ryeol (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913153#comment-16913153 ] Jang Ryeol commented on HTTPCLIENT-1765: Shouldn't it be system default? As per document

Apache HttpAsyncClient throws TimeoutException for successful requests due to failed lease requests

2019-08-22 Thread 赵博丰
Dear all, Using the Apache HttpAsyncClient inside Elasticsearch's RestHighLevelClient, I found a problem that HttpAsyncClient might throw TimeoutException for successful requests due to failed lease requests. The problem is that AbstractNIOConnPool throws TimeoutException for a lease request

Re: Apache HttpAsyncClient throws TimeoutException for successful requests due to failed lease requests

2019-08-22 Thread Oleg Kalnichevski
On Thu, 2019-08-22 at 11:18 +0800, 赵博丰 wrote: > Dear all, > > Using the Apache HttpAsyncClient inside Elasticsearch's > RestHighLevelClient, I found a problem that HttpAsyncClient might > throw TimeoutException for successful requests due to failed lease > requests. > > The problem is that

[GitHub] [httpcomponents-client] ok2c commented on a change in pull request #162: Modify RequestConfig Javadoc

2019-08-22 Thread GitBox
ok2c commented on a change in pull request #162: Modify RequestConfig Javadoc URL: https://github.com/apache/httpcomponents-client/pull/162#discussion_r316738153 ## File path: httpclient/src/main/java/org/apache/http/client/config/RequestConfig.java ## @@ -295,11 +293,11

[GitHub] [httpcomponents-client] bekker commented on a change in pull request #162: Modify RequestConfig Javadoc

2019-08-22 Thread GitBox
bekker commented on a change in pull request #162: Modify RequestConfig Javadoc URL: https://github.com/apache/httpcomponents-client/pull/162#discussion_r316742070 ## File path: httpclient/src/main/java/org/apache/http/client/config/RequestConfig.java ## @@ -295,11

[GitHub] [httpcomponents-client] garydgregory commented on a change in pull request #162: Modify RequestConfig Javadoc

2019-08-22 Thread GitBox
garydgregory commented on a change in pull request #162: Modify RequestConfig Javadoc URL: https://github.com/apache/httpcomponents-client/pull/162#discussion_r316748514 ## File path: httpclient/src/main/java/org/apache/http/client/config/RequestConfig.java ## @@

[jira] [Commented] (HTTPCLIENT-1765) SSLConnectionSocketFactory uses connectTimeout for read timeout

2019-08-22 Thread Jang Ryeol (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913422#comment-16913422 ] Jang Ryeol commented on HTTPCLIENT-1765: [~ggregory] Sure. I made a small Javadoc change

[jira] [Commented] (HTTPCLIENT-1765) SSLConnectionSocketFactory uses connectTimeout for read timeout

2019-08-22 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913158#comment-16913158 ] Oleg Kalnichevski commented on HTTPCLIENT-1765: --- [~northfolk28] Correctly configure

[GitHub] [httpcomponents-client] bekker opened a new pull request #162: Modify RequestConfig Javadoc

2019-08-22 Thread GitBox
bekker opened a new pull request #162: Modify RequestConfig Javadoc URL: https://github.com/apache/httpcomponents-client/pull/162 Cleaned up duplicate sentences and removed 'system default' from getSocketTimeout comment

[GitHub] [httpcomponents-client] bekker commented on a change in pull request #162: Modify RequestConfig Javadoc

2019-08-22 Thread GitBox
bekker commented on a change in pull request #162: Modify RequestConfig Javadoc URL: https://github.com/apache/httpcomponents-client/pull/162#discussion_r316756683 ## File path: httpclient/src/main/java/org/apache/http/client/config/RequestConfig.java ## @@ -295,11

[GitHub] [httpcomponents-client] bekker commented on a change in pull request #162: Modify RequestConfig Javadoc

2019-08-22 Thread GitBox
bekker commented on a change in pull request #162: Modify RequestConfig Javadoc URL: https://github.com/apache/httpcomponents-client/pull/162#discussion_r316756683 ## File path: httpclient/src/main/java/org/apache/http/client/config/RequestConfig.java ## @@ -295,11

[jira] [Commented] (HTTPCLIENT-1765) SSLConnectionSocketFactory uses connectTimeout for read timeout

2019-08-22 Thread Jang Ryeol (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913301#comment-16913301 ] Jang Ryeol commented on HTTPCLIENT-1765: Yeah adding readTimeout is not that hard. I

[jira] [Commented] (HTTPCLIENT-1765) SSLConnectionSocketFactory uses connectTimeout for read timeout

2019-08-22 Thread Gary Gregory (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913356#comment-16913356 ] Gary Gregory commented on HTTPCLIENT-1765: -- Hi [~northfolk28], Do you think different

[GitHub] [httpcomponents-client] rschmitt commented on issue #161: Add RequestConfig builder javadocs

2019-08-22 Thread GitBox
rschmitt commented on issue #161: Add RequestConfig builder javadocs URL: https://github.com/apache/httpcomponents-client/pull/161#issuecomment-524003213 @ok2c Do you agree with his suggestion that the Javadoc should be moved to the builder methods? I like that idea.

[GitHub] [httpcomponents-client] ok2c commented on issue #161: Add RequestConfig builder javadocs

2019-08-22 Thread GitBox
ok2c commented on issue #161: Add RequestConfig builder javadocs URL: https://github.com/apache/httpcomponents-client/pull/161#issuecomment-524017200 @rschmitt I am fine with it as long as the same change get applied consistently to all similar classes in core and client.

[GitHub] [httpcomponents-core] rhernandez35 opened a new pull request #144: Move javadocs to Builder classes

2019-08-22 Thread GitBox
rhernandez35 opened a new pull request #144: Move javadocs to Builder classes URL: https://github.com/apache/httpcomponents-core/pull/144 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [httpcomponents-client] rhernandez35 opened a new pull request #163: Move javadocs to Builder classes

2019-08-22 Thread GitBox
rhernandez35 opened a new pull request #163: Move javadocs to Builder classes URL: https://github.com/apache/httpcomponents-client/pull/163 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (HTTPCLIENT-2013) Connect timeout throws HttpHostConnectException (ConnectException) instead of ConnectTimeoutException (IOException)

2019-08-22 Thread Chanseok Oh (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chanseok Oh updated HTTPCLIENT-2013: Description: It is obvious from the code in DefaultHttpClientConnectionOperator that

[jira] [Updated] (HTTPCLIENT-2013) Connect timeout throws HttpHostConnectException (ConnectException) instead of ConnectTimeoutException (IOException)

2019-08-22 Thread Chanseok Oh (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chanseok Oh updated HTTPCLIENT-2013: Description: It is obvious from the code in DefaultHttpClientConnectionOperator that

[jira] [Created] (HTTPCLIENT-2013) Connect timeout throws HttpHostConnectException (ConnectException) instead of ConnectTimeoutException (IOException)

2019-08-22 Thread Chanseok Oh (Jira)
Chanseok Oh created HTTPCLIENT-2013: --- Summary: Connect timeout throws HttpHostConnectException (ConnectException) instead of ConnectTimeoutException (IOException) Key: HTTPCLIENT-2013 URL: