[jira] [Commented] (HTTPCORE-489) sometimes unit test will failed

2017-09-06 Thread silver9886 (JIRA) 

[ 
https://issues.apache.org/jira/browse/HTTPCORE-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156281#comment-16156281
 ] 

silver9886 commented on HTTPCORE-489:
-

why don't give me a chance to raise a pr :(

> sometimes unit test will failed
> ---
>
> Key: HTTPCORE-489
> URL: https://issues.apache.org/jira/browse/HTTPCORE-489
> Project: HttpComponents HttpCore
>  Issue Type: Test
>  Components: HttpCore NIO
>Affects Versions: 5.0-alpha4
> Environment: windows 7
> jdk:1.8.0_101
>Reporter: silver9886
>Priority: Trivial
> Fix For: 5.0-beta1
>
> Attachments: SocketException(success case).txt, 
> SSLHandshakeException(failed case).txt
>
>
> org.apache.hc.core5.ssl.TestSSLContextBuilder.testSSLHanskshakeProtocolMismatch2()
> sometimes will run failed occasionally.
> for example, change the branch from master to the other banch,run mvn clean 
> test command,
> change back to the master run the command,and change to the other branch ,run 
> command 
> twice change back ,run command(just run more times each branch and change to 
> other branch run command several times).
> Doing steps above for some times, occasionally the unit test failed.
> out put is like this:
> Failed tests:
>   TestSSLContextBuilder.testSSLHanskshakeProtocolMismatch2
> Expected: an instance of java.net.SocketException
>  but:  handshake_
> failure> is a javax.net.ssl.SSLHandshakeException
> Stacktrace was: javax.net.ssl.SSLHandshakeException: Received fatal alert: 
> hands
> hake_failure
> the difference exception stack between failed and success test case are in 
> attachment.
> I don't know if you can Recurrent this bug in your environment.And I am not
> sure If it is a bug or just something wrong with my environment.
> If make sure it is a bug,maybe we should except thrown IOException.class when 
> environment is windows and jdk.version
> >= 1.8.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[GitHub] httpcomponents-client pull request #83: Fix typo in HttpClients.java javadoc

2017-09-06 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/httpcomponents-client/pull/83


---

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[GitHub] httpcomponents-client pull request #83: Fix typo in HttpClients.java javadoc

2017-09-06 Thread andyklimczak 
GitHub user andyklimczak opened a pull request:

https://github.com/apache/httpcomponents-client/pull/83

Fix typo in HttpClients.java javadoc



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andyklimczak/httpcomponents-client 
typo-http-clients

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/httpcomponents-client/pull/83.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #83


commit b28e521dbd565f7aac32732b6b3fcd279a74d41c
Author: Andy Klimczak 
Date:   2017-09-06T17:53:32Z

Fix typo in HttpClients.java javadoc




---

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[jira] [Resolved] (HTTPCORE-489) sometimes unit test will failed

2017-09-06 Thread Oleg Kalnichevski (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HTTPCORE-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleg Kalnichevski resolved HTTPCORE-489.

Resolution: Fixed

Fixed in master.

Oleg

> sometimes unit test will failed
> ---
>
> Key: HTTPCORE-489
> URL: https://issues.apache.org/jira/browse/HTTPCORE-489
> Project: HttpComponents HttpCore
>  Issue Type: Test
>  Components: HttpCore NIO
>Affects Versions: 5.0-alpha4
> Environment: windows 7
> jdk:1.8.0_101
>Reporter: silver9886
>Priority: Trivial
> Fix For: 5.0-beta1
>
> Attachments: SocketException(success case).txt, 
> SSLHandshakeException(failed case).txt
>
>
> org.apache.hc.core5.ssl.TestSSLContextBuilder.testSSLHanskshakeProtocolMismatch2()
> sometimes will run failed occasionally.
> for example, change the branch from master to the other banch,run mvn clean 
> test command,
> change back to the master run the command,and change to the other branch ,run 
> command 
> twice change back ,run command(just run more times each branch and change to 
> other branch run command several times).
> Doing steps above for some times, occasionally the unit test failed.
> out put is like this:
> Failed tests:
>   TestSSLContextBuilder.testSSLHanskshakeProtocolMismatch2
> Expected: an instance of java.net.SocketException
>  but:  handshake_
> failure> is a javax.net.ssl.SSLHandshakeException
> Stacktrace was: javax.net.ssl.SSLHandshakeException: Received fatal alert: 
> hands
> hake_failure
> the difference exception stack between failed and success test case are in 
> attachment.
> I don't know if you can Recurrent this bug in your environment.And I am not
> sure If it is a bug or just something wrong with my environment.
> If make sure it is a bug,maybe we should except thrown IOException.class when 
> environment is windows and jdk.version
> >= 1.8.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[jira] [Commented] (HTTPCORE-489) sometimes unit test will failed

2017-09-06 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/HTTPCORE-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155459#comment-16155459
 ] 

ASF subversion and git services commented on HTTPCORE-489:
--

Commit 5ea246258b2da559b0645f1ca12cb083948f372e in httpcomponents-core's branch 
refs/heads/master from [~olegk]
[ https://git-wip-us.apache.org/repos/asf?p=httpcomponents-core.git;h=5ea2462 ]

HTTPCORE-489: tweak SSL protocol mismatch test case to work around the problem 
with intermittent failures on Windows


> sometimes unit test will failed
> ---
>
> Key: HTTPCORE-489
> URL: https://issues.apache.org/jira/browse/HTTPCORE-489
> Project: HttpComponents HttpCore
>  Issue Type: Test
>  Components: HttpCore NIO
>Affects Versions: 5.0-alpha4
> Environment: windows 7
> jdk:1.8.0_101
>Reporter: silver9886
>Priority: Trivial
> Fix For: 5.0-beta1
>
> Attachments: SocketException(success case).txt, 
> SSLHandshakeException(failed case).txt
>
>
> org.apache.hc.core5.ssl.TestSSLContextBuilder.testSSLHanskshakeProtocolMismatch2()
> sometimes will run failed occasionally.
> for example, change the branch from master to the other banch,run mvn clean 
> test command,
> change back to the master run the command,and change to the other branch ,run 
> command 
> twice change back ,run command(just run more times each branch and change to 
> other branch run command several times).
> Doing steps above for some times, occasionally the unit test failed.
> out put is like this:
> Failed tests:
>   TestSSLContextBuilder.testSSLHanskshakeProtocolMismatch2
> Expected: an instance of java.net.SocketException
>  but:  handshake_
> failure> is a javax.net.ssl.SSLHandshakeException
> Stacktrace was: javax.net.ssl.SSLHandshakeException: Received fatal alert: 
> hands
> hake_failure
> the difference exception stack between failed and success test case are in 
> attachment.
> I don't know if you can Recurrent this bug in your environment.And I am not
> sure If it is a bug or just something wrong with my environment.
> If make sure it is a bug,maybe we should except thrown IOException.class when 
> environment is windows and jdk.version
> >= 1.8.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[jira] [Commented] (HTTPCORE-488) SingleCoreIOReactor.connect methods timeout parameter do not have effect.

2017-09-06 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/HTTPCORE-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155450#comment-16155450
 ] 

ASF GitHub Bot commented on HTTPCORE-488:
-

Github user xiaohu-zhang closed the pull request at:

https://github.com/apache/httpcomponents-core/pull/51


> SingleCoreIOReactor.connect methods timeout parameter do not have effect.
> -
>
> Key: HTTPCORE-488
> URL: https://issues.apache.org/jira/browse/HTTPCORE-488
> Project: HttpComponents HttpCore
>  Issue Type: Bug
>  Components: HttpCore NIO
>Affects Versions: 5.0-alpha4
>Reporter: silver9886
>Priority: Minor
> Fix For: 5.0-beta1
>
>
> In my opinion , timeout parameter in connect method means connectTimeout.
> In InternalConnectChannel.onIOEvent ,if (readyOps & SelectionKey.OP_CONNECT) 
> != 0 then the socketChannel will connect to the server.However , at this time,
> Perhaps It is connection time out already.
> So i suggest check connecttimeout at InternalConnectChannel.onIOEvent methods 
> When there is SelectionKey.OP_CONNECT event happend



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[GitHub] httpcomponents-core issue #51: Check connecttimeout when SelectionKey.OP_CON...

2017-09-06 Thread xiaohu-zhang 
Github user xiaohu-zhang commented on the issue:

https://github.com/apache/httpcomponents-core/pull/51
  
thank you 


---

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[GitHub] httpcomponents-core pull request #51: Check connecttimeout when SelectionKey...

2017-09-06 Thread xiaohu-zhang 
Github user xiaohu-zhang closed the pull request at:

https://github.com/apache/httpcomponents-core/pull/51


---

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[jira] [Commented] (HTTPCORE-488) SingleCoreIOReactor.connect methods timeout parameter do not have effect.

2017-09-06 Thread Oleg Kalnichevski (JIRA) 

[ 
https://issues.apache.org/jira/browse/HTTPCORE-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155447#comment-16155447
 ] 

Oleg Kalnichevski commented on HTTPCORE-488:


Cool. Please close the PR at Github if you are happy with the change-set.

Oleg

> SingleCoreIOReactor.connect methods timeout parameter do not have effect.
> -
>
> Key: HTTPCORE-488
> URL: https://issues.apache.org/jira/browse/HTTPCORE-488
> Project: HttpComponents HttpCore
>  Issue Type: Bug
>  Components: HttpCore NIO
>Affects Versions: 5.0-alpha4
>Reporter: silver9886
>Priority: Minor
> Fix For: 5.0-beta1
>
>
> In my opinion , timeout parameter in connect method means connectTimeout.
> In InternalConnectChannel.onIOEvent ,if (readyOps & SelectionKey.OP_CONNECT) 
> != 0 then the socketChannel will connect to the server.However , at this time,
> Perhaps It is connection time out already.
> So i suggest check connecttimeout at InternalConnectChannel.onIOEvent methods 
> When there is SelectionKey.OP_CONNECT event happend



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[jira] [Commented] (HTTPCORE-488) SingleCoreIOReactor.connect methods timeout parameter do not have effect.

2017-09-06 Thread silver9886 (JIRA) 

[ 
https://issues.apache.org/jira/browse/HTTPCORE-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155424#comment-16155424
 ] 

silver9886 commented on HTTPCORE-488:
-

you are right ! your change is execlent，I ignore the super constructor . The 
commit is perfect.

> SingleCoreIOReactor.connect methods timeout parameter do not have effect.
> -
>
> Key: HTTPCORE-488
> URL: https://issues.apache.org/jira/browse/HTTPCORE-488
> Project: HttpComponents HttpCore
>  Issue Type: Bug
>  Components: HttpCore NIO
>Affects Versions: 5.0-alpha4
>Reporter: silver9886
>Priority: Minor
> Fix For: 5.0-beta1
>
>
> In my opinion , timeout parameter in connect method means connectTimeout.
> In InternalConnectChannel.onIOEvent ,if (readyOps & SelectionKey.OP_CONNECT) 
> != 0 then the socketChannel will connect to the server.However , at this time,
> Perhaps It is connection time out already.
> So i suggest check connecttimeout at InternalConnectChannel.onIOEvent methods 
> When there is SelectionKey.OP_CONNECT event happend



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[jira] [Commented] (HTTPCORE-488) SingleCoreIOReactor.connect methods timeout parameter do not have effect.

2017-09-06 Thread silver9886 (JIRA) 

[ 
https://issues.apache.org/jira/browse/HTTPCORE-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155385#comment-16155385
 ] 

silver9886 commented on HTTPCORE-488:
-

I think we have to discuss about it. In the pr,
SingleCoreIOReactor.java
channel.setLastEventTime(System.currentTimeMillis());
is very useful.
In the truck code,lastEventTime change in handleIOEvent method ,that is the 
time accept the SelectionKey.OP_CONNECT event.but it should be set right after
socketChannel.connect(sessionRequest.remoteAddress);then the checkTimeout(now) 
in the InternalConnectChannel
will calculate the time duration between connect and OP_CONNECT event,and chck 
if it is connect timeout.

> SingleCoreIOReactor.connect methods timeout parameter do not have effect.
> -
>
> Key: HTTPCORE-488
> URL: https://issues.apache.org/jira/browse/HTTPCORE-488
> Project: HttpComponents HttpCore
>  Issue Type: Bug
>  Components: HttpCore NIO
>Affects Versions: 5.0-alpha4
>Reporter: silver9886
>Priority: Minor
> Fix For: 5.0-beta1
>
>
> In my opinion , timeout parameter in connect method means connectTimeout.
> In InternalConnectChannel.onIOEvent ,if (readyOps & SelectionKey.OP_CONNECT) 
> != 0 then the socketChannel will connect to the server.However , at this time,
> Perhaps It is connection time out already.
> So i suggest check connecttimeout at InternalConnectChannel.onIOEvent methods 
> When there is SelectionKey.OP_CONNECT event happend



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[jira] [Resolved] (HTTPCORE-488) SingleCoreIOReactor.connect methods timeout parameter do not have effect.

2017-09-06 Thread Oleg Kalnichevski (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HTTPCORE-488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleg Kalnichevski resolved HTTPCORE-488.

   Resolution: Fixed
Fix Version/s: 5.0-beta1

Committed to master with changes. I also decided to not commit test cases due 
to their dependency on external hosts / availability of local ports and the 
fact that they were not really testing the fix in question.

Please review and close.

Oleg 

> SingleCoreIOReactor.connect methods timeout parameter do not have effect.
> -
>
> Key: HTTPCORE-488
> URL: https://issues.apache.org/jira/browse/HTTPCORE-488
> Project: HttpComponents HttpCore
>  Issue Type: Bug
>  Components: HttpCore NIO
>Affects Versions: 5.0-alpha4
>Reporter: silver9886
>Priority: Minor
> Fix For: 5.0-beta1
>
>
> In my opinion , timeout parameter in connect method means connectTimeout.
> In InternalConnectChannel.onIOEvent ,if (readyOps & SelectionKey.OP_CONNECT) 
> != 0 then the socketChannel will connect to the server.However , at this time,
> Perhaps It is connection time out already.
> So i suggest check connecttimeout at InternalConnectChannel.onIOEvent methods 
> When there is SelectionKey.OP_CONNECT event happend



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[GitHub] httpcomponents-core issue #51: Check connecttimeout when SelectionKey.OP_CON...

2017-09-06 Thread ok2c 
Github user ok2c commented on the issue:

https://github.com/apache/httpcomponents-core/pull/51
  
Committed to master with changes. Please review and close.


---

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[jira] [Commented] (HTTPCORE-488) SingleCoreIOReactor.connect methods timeout parameter do not have effect.

2017-09-06 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/HTTPCORE-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155294#comment-16155294
 ] 

ASF subversion and git services commented on HTTPCORE-488:
--

Commit 6e22c52f689597741503ce2a85881b249f4728f4 in httpcomponents-core's branch 
refs/heads/master from [~silver9886]
[ https://git-wip-us.apache.org/repos/asf?p=httpcomponents-core.git;h=6e22c52 ]

HTTPCORE-488: SingleCoreIOReactor#connect timeout parameter has no effect


> SingleCoreIOReactor.connect methods timeout parameter do not have effect.
> -
>
> Key: HTTPCORE-488
> URL: https://issues.apache.org/jira/browse/HTTPCORE-488
> Project: HttpComponents HttpCore
>  Issue Type: Bug
>  Components: HttpCore NIO
>Affects Versions: 5.0-alpha4
>Reporter: silver9886
>Priority: Minor
>
> In my opinion , timeout parameter in connect method means connectTimeout.
> In InternalConnectChannel.onIOEvent ,if (readyOps & SelectionKey.OP_CONNECT) 
> != 0 then the socketChannel will connect to the server.However , at this time,
> Perhaps It is connection time out already.
> So i suggest check connecttimeout at InternalConnectChannel.onIOEvent methods 
> When there is SelectionKey.OP_CONNECT event happend



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[jira] [Commented] (HTTPCORE-489) sometimes unit test will failed

2017-09-06 Thread Oleg Kalnichevski (JIRA) 

[ 
https://issues.apache.org/jira/browse/HTTPCORE-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155134#comment-16155134
 ] 

Oleg Kalnichevski commented on HTTPCORE-489:


No, it is not. It is Windows being crap.

Oleg

> sometimes unit test will failed
> ---
>
> Key: HTTPCORE-489
> URL: https://issues.apache.org/jira/browse/HTTPCORE-489
> Project: HttpComponents HttpCore
>  Issue Type: Test
>  Components: HttpCore NIO
>Affects Versions: 5.0-alpha4
> Environment: windows 7
> jdk:1.8.0_101
>Reporter: silver9886
>Priority: Trivial
> Fix For: 5.0-beta1
>
> Attachments: SocketException(success case).txt, 
> SSLHandshakeException(failed case).txt
>
>
> org.apache.hc.core5.ssl.TestSSLContextBuilder.testSSLHanskshakeProtocolMismatch2()
> sometimes will run failed occasionally.
> for example, change the branch from master to the other banch,run mvn clean 
> test command,
> change back to the master run the command,and change to the other branch ,run 
> command 
> twice change back ,run command(just run more times each branch and change to 
> other branch run command several times).
> Doing steps above for some times, occasionally the unit test failed.
> out put is like this:
> Failed tests:
>   TestSSLContextBuilder.testSSLHanskshakeProtocolMismatch2
> Expected: an instance of java.net.SocketException
>  but:  handshake_
> failure> is a javax.net.ssl.SSLHandshakeException
> Stacktrace was: javax.net.ssl.SSLHandshakeException: Received fatal alert: 
> hands
> hake_failure
> the difference exception stack between failed and success test case are in 
> attachment.
> I don't know if you can Recurrent this bug in your environment.And I am not
> sure If it is a bug or just something wrong with my environment.
> If make sure it is a bug,maybe we should except thrown IOException.class when 
> environment is windows and jdk.version
> >= 1.8.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[jira] [Commented] (HTTPCORE-489) sometimes unit test will failed

2017-09-06 Thread silver9886 (JIRA) 

[ 
https://issues.apache.org/jira/browse/HTTPCORE-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155125#comment-16155125
 ] 

silver9886 commented on HTTPCORE-489:
-

Is it a bug?

> sometimes unit test will failed
> ---
>
> Key: HTTPCORE-489
> URL: https://issues.apache.org/jira/browse/HTTPCORE-489
> Project: HttpComponents HttpCore
>  Issue Type: Test
>  Components: HttpCore NIO
>Affects Versions: 5.0-alpha4
> Environment: windows 7
> jdk:1.8.0_101
>Reporter: silver9886
>Priority: Trivial
> Fix For: 5.0-beta1
>
> Attachments: SocketException(success case).txt, 
> SSLHandshakeException(failed case).txt
>
>
> org.apache.hc.core5.ssl.TestSSLContextBuilder.testSSLHanskshakeProtocolMismatch2()
> sometimes will run failed occasionally.
> for example, change the branch from master to the other banch,run mvn clean 
> test command,
> change back to the master run the command,and change to the other branch ,run 
> command 
> twice change back ,run command(just run more times each branch and change to 
> other branch run command several times).
> Doing steps above for some times, occasionally the unit test failed.
> out put is like this:
> Failed tests:
>   TestSSLContextBuilder.testSSLHanskshakeProtocolMismatch2
> Expected: an instance of java.net.SocketException
>  but:  handshake_
> failure> is a javax.net.ssl.SSLHandshakeException
> Stacktrace was: javax.net.ssl.SSLHandshakeException: Received fatal alert: 
> hands
> hake_failure
> the difference exception stack between failed and success test case are in 
> attachment.
> I don't know if you can Recurrent this bug in your environment.And I am not
> sure If it is a bug or just something wrong with my environment.
> If make sure it is a bug,maybe we should except thrown IOException.class when 
> environment is windows and jdk.version
> >= 1.8.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[jira] [Updated] (HTTPCORE-489) sometimes unit test will failed

2017-09-06 Thread Oleg Kalnichevski (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HTTPCORE-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleg Kalnichevski updated HTTPCORE-489:
---
Affects Version/s: (was: 5.0-beta1)
   5.0-alpha4
 Priority: Trivial  (was: Critical)
Fix Version/s: 5.0-beta1

> sometimes unit test will failed
> ---
>
> Key: HTTPCORE-489
> URL: https://issues.apache.org/jira/browse/HTTPCORE-489
> Project: HttpComponents HttpCore
>  Issue Type: Test
>  Components: HttpCore NIO
>Affects Versions: 5.0-alpha4
> Environment: windows 7
> jdk:1.8.0_101
>Reporter: silver9886
>Priority: Trivial
> Fix For: 5.0-beta1
>
> Attachments: SocketException(success case).txt, 
> SSLHandshakeException(failed case).txt
>
>
> org.apache.hc.core5.ssl.TestSSLContextBuilder.testSSLHanskshakeProtocolMismatch2()
> sometimes will run failed occasionally.
> for example, change the branch from master to the other banch,run mvn clean 
> test command,
> change back to the master run the command,and change to the other branch ,run 
> command 
> twice change back ,run command(just run more times each branch and change to 
> other branch run command several times).
> Doing steps above for some times, occasionally the unit test failed.
> out put is like this:
> Failed tests:
>   TestSSLContextBuilder.testSSLHanskshakeProtocolMismatch2
> Expected: an instance of java.net.SocketException
>  but:  handshake_
> failure> is a javax.net.ssl.SSLHandshakeException
> Stacktrace was: javax.net.ssl.SSLHandshakeException: Received fatal alert: 
> hands
> hake_failure
> the difference exception stack between failed and success test case are in 
> attachment.
> I don't know if you can Recurrent this bug in your environment.And I am not
> sure If it is a bug or just something wrong with my environment.
> If make sure it is a bug,maybe we should except thrown IOException.class when 
> environment is windows and jdk.version
> >= 1.8.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[GitHub] httpcomponents-core issue #51: Check connecttimeout when SelectionKey.OP_CON...

2017-09-06 Thread ok2c 
Github user ok2c commented on the issue:

https://github.com/apache/httpcomponents-core/pull/51
  
Could you please rebase your branch off the latest master and squash all 
your individual commits? There is also garbage in the change-set 
(commit-6349d92 file presumably checked in by mistake). Could you please remove 
it?


---

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[jira] [Created] (HTTPCORE-489) sometimes unit test will failed

2017-09-06 Thread silver9886 (JIRA) 
silver9886 created HTTPCORE-489:
---

 Summary: sometimes unit test will failed
 Key: HTTPCORE-489
 URL: https://issues.apache.org/jira/browse/HTTPCORE-489
 Project: HttpComponents HttpCore
  Issue Type: Test
  Components: HttpCore NIO
Affects Versions: 5.0-beta1
 Environment: windows 7
jdk:1.8.0_101
Reporter: silver9886
Priority: Critical
 Attachments: SocketException(success case).txt, 
SSLHandshakeException(failed case).txt

org.apache.hc.core5.ssl.TestSSLContextBuilder.testSSLHanskshakeProtocolMismatch2()
sometimes will run failed occasionally.
for example, change the branch from master to the other banch,run mvn clean 
test command,
change back to the master run the command,and change to the other branch ,run 
command 
twice change back ,run command(just run more times each branch and change to 
other branch run command several times).
Doing steps above for some times, occasionally the unit test failed.
out put is like this:

Failed tests:
  TestSSLContextBuilder.testSSLHanskshakeProtocolMismatch2
Expected: an instance of java.net.SocketException
 but:  is a javax.net.ssl.SSLHandshakeException
Stacktrace was: javax.net.ssl.SSLHandshakeException: Received fatal alert: hands
hake_failure

the difference exception stack between failed and success test case are in 
attachment.
I don't know if you can Recurrent this bug in your environment.And I am not
sure If it is a bug or just something wrong with my environment.
If make sure it is a bug,maybe we should except thrown IOException.class when 
environment is windows and jdk.version
>= 1.8.





--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[jira] [Commented] (HTTPCORE-488) SingleCoreIOReactor.connect methods timeout parameter do not have effect.

2017-09-06 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/HTTPCORE-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154927#comment-16154927
 ] 

ASF GitHub Bot commented on HTTPCORE-488:
-

GitHub user xiaohu-zhang opened a pull request:

https://github.com/apache/httpcomponents-core/pull/51

Check connecttimeout when SelectionKey.OP_CONNECT event happend

related to HTTPCORE-488
InternalConnectChannel onTimeout should also invoke close method

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xiaohu-zhang/httpcomponents-core 
checkconnecttimeout

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/httpcomponents-core/pull/51.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #51


commit 4d7a18420cd66dd17387b845b324b241281d7fcc
Author: xiaohu-zhang 
Date:   2017-08-29T14:11:24Z

setting time limit on processPending methods

setting time limit to avoid the SingleCoreIOReactor's time be exhausted
and then  block the remaining work to do.

commit b6043b3aa94c65b23bb39804342a7826dc236eae
Author: xiaohu-zhang 
Date:   2017-08-30T03:27:04Z

Merge branch 'master' of 
https://github.com/apache/httpcomponents-core/commits/master

commit 6349d9223c01b9533d38a19e3100b7d1c81f5bae
Author: xiaohu-zhang 
Date:   2017-09-04T10:49:58Z

commit for merge from remove trank

commit d55b119b7fb9dffa7b74020a704265947eed1abb
Author: xiaohu-zhang 
Date:   2017-09-04T11:10:24Z

Merge branch 'master' of https://github.com/apache/httpcomponents-core into 
checkconnecttimeout

# Conflicts:
#   
httpcore5/src/main/java/org/apache/hc/core5/reactor/SingleCoreIOReactor.java

commit 1f81fa7809f0f7c2af7cb1eee60447c3dc2534f0
Author: xiaohu-zhang 
Date:   2017-09-04T11:21:26Z

test commit

commit 5f0d50af647d478ac19da8790f23c5e4135cf5a3
Author: xiaohu-zhang 
Date:   2017-09-04T11:24:43Z

Revert "test commit"

This reverts commit 1f81fa7809f0f7c2af7cb1eee60447c3dc2534f0.

commit c70f59c84eb5378f4d203d8c5b9cc9d301d2e86c
Author: xiaohu-zhang 
Date:   2017-09-04T11:28:10Z

Revert "Revert "test commit""

This reverts commit 5f0d50af647d478ac19da8790f23c5e4135cf5a3.

commit 4c38f0560dd5f80a16816c5d8d32b89439ecec24
Author: xiaohu-zhang 
Date:   2017-09-04T11:29:26Z

test

commit 6c564282d0e77878af06729747873dbb0e373fff
Author: xiaohu-zhang 
Date:   2017-09-06T03:08:07Z

deal with connect time out
add unit test

commit b0e26899cb39b5927b2ca5983aea4dcceeb29ce5
Author: xiaohu-zhang 
Date:   2017-09-06T04:34:28Z

modify with checkstyle

commit 3002e710b2f83b0c7f606dfb4c95ef9203fa6d9b
Author: xiaohu-zhang 
Date:   2017-09-06T07:12:40Z

add unrun unit test




> SingleCoreIOReactor.connect methods timeout parameter do not have effect.
> -
>
> Key: HTTPCORE-488
> URL: https://issues.apache.org/jira/browse/HTTPCORE-488
> Project: HttpComponents HttpCore
>  Issue Type: Bug
>  Components: HttpCore NIO
>Affects Versions: 5.0-alpha4
>Reporter: silver9886
>Priority: Minor
>
> In my opinion , timeout parameter in connect method means connectTimeout.
> In InternalConnectChannel.onIOEvent ,if (readyOps & SelectionKey.OP_CONNECT) 
> != 0 then the socketChannel will connect to the server.However , at this time,
> Perhaps It is connection time out already.
> So i suggest check connecttimeout at InternalConnectChannel.onIOEvent methods 
> When there is SelectionKey.OP_CONNECT event happend



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

[GitHub] httpcomponents-core pull request #51: Check connecttimeout when SelectionKey...

2017-09-06 Thread xiaohu-zhang 
GitHub user xiaohu-zhang opened a pull request:

https://github.com/apache/httpcomponents-core/pull/51

Check connecttimeout when SelectionKey.OP_CONNECT event happend

related to HTTPCORE-488
InternalConnectChannel onTimeout should also invoke close method

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xiaohu-zhang/httpcomponents-core 
checkconnecttimeout

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/httpcomponents-core/pull/51.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #51


commit 4d7a18420cd66dd17387b845b324b241281d7fcc
Author: xiaohu-zhang 
Date:   2017-08-29T14:11:24Z

setting time limit on processPending methods

setting time limit to avoid the SingleCoreIOReactor's time be exhausted
and then  block the remaining work to do.

commit b6043b3aa94c65b23bb39804342a7826dc236eae
Author: xiaohu-zhang 
Date:   2017-08-30T03:27:04Z

Merge branch 'master' of 
https://github.com/apache/httpcomponents-core/commits/master

commit 6349d9223c01b9533d38a19e3100b7d1c81f5bae
Author: xiaohu-zhang 
Date:   2017-09-04T10:49:58Z

commit for merge from remove trank

commit d55b119b7fb9dffa7b74020a704265947eed1abb
Author: xiaohu-zhang 
Date:   2017-09-04T11:10:24Z

Merge branch 'master' of https://github.com/apache/httpcomponents-core into 
checkconnecttimeout

# Conflicts:
#   
httpcore5/src/main/java/org/apache/hc/core5/reactor/SingleCoreIOReactor.java

commit 1f81fa7809f0f7c2af7cb1eee60447c3dc2534f0
Author: xiaohu-zhang 
Date:   2017-09-04T11:21:26Z

test commit

commit 5f0d50af647d478ac19da8790f23c5e4135cf5a3
Author: xiaohu-zhang 
Date:   2017-09-04T11:24:43Z

Revert "test commit"

This reverts commit 1f81fa7809f0f7c2af7cb1eee60447c3dc2534f0.

commit c70f59c84eb5378f4d203d8c5b9cc9d301d2e86c
Author: xiaohu-zhang 
Date:   2017-09-04T11:28:10Z

Revert "Revert "test commit""

This reverts commit 5f0d50af647d478ac19da8790f23c5e4135cf5a3.

commit 4c38f0560dd5f80a16816c5d8d32b89439ecec24
Author: xiaohu-zhang 
Date:   2017-09-04T11:29:26Z

test

commit 6c564282d0e77878af06729747873dbb0e373fff
Author: xiaohu-zhang 
Date:   2017-09-06T03:08:07Z

deal with connect time out
add unit test

commit b0e26899cb39b5927b2ca5983aea4dcceeb29ce5
Author: xiaohu-zhang 
Date:   2017-09-06T04:34:28Z

modify with checkstyle

commit 3002e710b2f83b0c7f606dfb4c95ef9203fa6d9b
Author: xiaohu-zhang 
Date:   2017-09-06T07:12:40Z

add unrun unit test




---

-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org