Re: Use of final keyword

2013-01-15 Thread Gary Gregory
On Tue, Jan 15, 2013 at 9:46 AM, Oleg Kalnichevski wrote: > On Tue, 2013-01-15 at 08:26 -0500, Gary Gregory wrote: > > Over in Log4J-land, we've discussed [1] the use of the final keyword for > > locals and parameters. > > > > In brief [1]: The final keyword in trunk: sometimes it is used, someti

Re: Use of final keyword

2013-01-15 Thread Oleg Kalnichevski
On Tue, 2013-01-15 at 15:40 -0500, Gary Gregory wrote: > On Tue, Jan 15, 2013 at 3:35 PM, Gary Gregory wrote: > > > On Tue, Jan 15, 2013 at 3:03 PM, Oleg Kalnichevski wrote: > > > >> On Tue, 2013-01-15 at 13:41 -0500, Gary Gregory wrote: > >> > On Tue, Jan 15, 2013 at 9:46 AM, Oleg Kalnichevski >

Re: Use of final keyword

2013-01-15 Thread Gary Gregory
On Tue, Jan 15, 2013 at 3:35 PM, Gary Gregory wrote: > On Tue, Jan 15, 2013 at 3:03 PM, Oleg Kalnichevski wrote: > >> On Tue, 2013-01-15 at 13:41 -0500, Gary Gregory wrote: >> > On Tue, Jan 15, 2013 at 9:46 AM, Oleg Kalnichevski >> wrote: >> > >> > > On Tue, 2013-01-15 at 08:26 -0500, Gary Gregor

Re: Use of final keyword

2013-01-15 Thread Gary Gregory
On Tue, Jan 15, 2013 at 3:03 PM, Oleg Kalnichevski wrote: > On Tue, 2013-01-15 at 13:41 -0500, Gary Gregory wrote: > > On Tue, Jan 15, 2013 at 9:46 AM, Oleg Kalnichevski > wrote: > > > > > On Tue, 2013-01-15 at 08:26 -0500, Gary Gregory wrote: > > > > Over in Log4J-land, we've discussed [1] the

Re: Use of final keyword

2013-01-15 Thread Oleg Kalnichevski
On Tue, 2013-01-15 at 13:41 -0500, Gary Gregory wrote: > On Tue, Jan 15, 2013 at 9:46 AM, Oleg Kalnichevski wrote: > > > On Tue, 2013-01-15 at 08:26 -0500, Gary Gregory wrote: > > > Over in Log4J-land, we've discussed [1] the use of the final keyword for > > > locals and parameters. > > > > > > I

Re: Use of final keyword

2013-01-15 Thread Gary Gregory
On Tue, Jan 15, 2013 at 9:46 AM, Oleg Kalnichevski wrote: > On Tue, 2013-01-15 at 08:26 -0500, Gary Gregory wrote: > > Over in Log4J-land, we've discussed [1] the use of the final keyword for > > locals and parameters. > > > > In brief [1]: The final keyword in trunk: sometimes it is used, someti

Re: Use of final keyword

2013-01-15 Thread Oleg Kalnichevski
On Tue, 2013-01-15 at 08:26 -0500, Gary Gregory wrote: > Over in Log4J-land, we've discussed [1] the use of the final keyword for > locals and parameters. > > In brief [1]: The final keyword in trunk: sometimes it is used, sometimes > not. I propose we use it all over consistently. > > [1] http:/