[ANNOUNCE] Move review related emails to revi...@helix.apache.org

Hi Folks, Due to large set of emails from github reviews flooding dev channel, we decide to move all review related notifications to revi...@helix.apache.org. Please resubscribe the reviews by directly send subscribe emails to revi...@helix.apache.org or go through this page:

[GitHub] [helix] mcvsubbu opened a new issue #377: Multiple problems with 0.9.0

mcvsubbu opened a new issue #377: Multiple problems with 0.9.0 URL: https://github.com/apache/helix/issues/377 We see the following issues in Pinot deployment: 1. Controller callback does not happen on a PARTICIPANT helix manager when leadership changes. 2. Other participants

[GitHub] [helix] i3wangyi opened a new pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue

i3wangyi opened a new pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376 TODO, will update everything later This is an automated message from the

[GitHub] [helix] narendly opened a new issue #375: Drop all tasks whose requested state is DROPPED

narendly opened a new issue #375: Drop all tasks whose requested state is DROPPED URL: https://github.com/apache/helix/issues/375 Upon a Participant disconnect, the Participant would carry over from the last session. This would copy all previous task states to the current session and set

[GitHub] [helix] kaisun2000 commented on issue #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

kaisun2000 commented on issue #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#issuecomment-518453741 Resolved all the review request. Also passing the test. Next step is to merge into trunk

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310841129 ## File path:

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310838708 ## File path:

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310838708 ## File path:

[GitHub] [helix] dasahcc commented on issue #374: Stablize the REST tests in helix-rest

dasahcc commented on issue #374: Stablize the REST tests in helix-rest URL: https://github.com/apache/helix/pull/374#issuecomment-518443325 > A lot of duplicate prints, can you check testng's BeforeMethod and AfterMethod annotations >

[GitHub] [helix] dasahcc commented on issue #374: Stablize the REST tests in helix-rest

dasahcc commented on issue #374: Stablize the REST tests in helix-rest URL: https://github.com/apache/helix/pull/374#issuecomment-518442369 > A lot of duplicate prints, can you check testng's BeforeMethod and AfterMethod annotations >

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310832882 ## File path:

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310832625 ## File path:

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310832401 ## File path:

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310831810 ## File path:

[GitHub] [helix] dasahcc opened a new pull request #374: Stablize the REST tests in helix-rest

dasahcc opened a new pull request #374: Stablize the REST tests in helix-rest URL: https://github.com/apache/helix/pull/374 ### Issues For test stabilizing, not create an issue. ### Description - [ ] Here are some details about my PR, including screenshots of any UI

[GitHub] [helix] i3wangyi commented on issue #367: Add transient cache for CustomRestClient implementation

i3wangyi commented on issue #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#issuecomment-518406925 > > > The parallel request still need to be considered. Say you are implementing the locking by keys. We need 100 participants

[GitHub] [helix] dasahcc commented on issue #367: Add transient cache for CustomRestClient implementation

dasahcc commented on issue #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#issuecomment-518402635 > > The parallel request still need to be considered. Say you are implementing the locking by keys. We need 100 participants

[GitHub] [helix] i3wangyi commented on issue #367: Add transient cache for CustomRestClient implementation

i3wangyi commented on issue #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#issuecomment-518397174 > The parallel request still need to be considered. Say you are implementing the locking by keys. We need 100 participants

[GitHub] [helix] i3wangyi commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

i3wangyi commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r310786737 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java

[GitHub] [helix] dasahcc commented on issue #367: Add transient cache for CustomRestClient implementation

dasahcc commented on issue #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#issuecomment-518390345 The parallel request still need to be considered. Say you are implementing the locking by keys. We need 100 participants partition

helix - Build # 1641 - Still Failing

The Apache Jenkins build system has built helix (build #1641) Status: Still Failing Check console output at https://builds.apache.org/job/helix/1641/ to view the results.

[GitHub] [helix] dasahcc merged pull request #359: Dynamically change the processor thread name when consuming event

dasahcc merged pull request #359: Dynamically change the processor thread name when consuming event URL: https://github.com/apache/helix/pull/359 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [helix] i3wangyi commented on issue #359: Dynamically change the processor thread name when consuming event

i3wangyi commented on issue #359: Dynamically change the processor thread name when consuming event URL: https://github.com/apache/helix/pull/359#issuecomment-518348999 This PR is ready to be merged, approved by @lei-xia

[GitHub] [helix] dasahcc commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

dasahcc commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r310212588 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java ##

[GitHub] [helix] dasahcc commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

dasahcc commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r310212407 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java ##

helix - Build # 1640 - Still Failing

The Apache Jenkins build system has built helix (build #1640) Status: Still Failing Check console output at https://builds.apache.org/job/helix/1640/ to view the results.

[GitHub] [helix] narendly closed issue #358: removing DEFAULT_VIEW_CLUSTER_REFRESH_PERIOD from clusterconfig

narendly closed issue #358: removing DEFAULT_VIEW_CLUSTER_REFRESH_PERIOD from clusterconfig URL: https://github.com/apache/helix/issues/358 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [helix] narendly merged pull request #373: Remove DEFAULT_VIEW_CLUSTER_REFRESH_PERIOD from ClusterConfig #358

narendly merged pull request #373: Remove DEFAULT_VIEW_CLUSTER_REFRESH_PERIOD from ClusterConfig #358 URL: https://github.com/apache/helix/pull/373 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [helix] narendly commented on issue #373: Remove DEFAULT_VIEW_CLUSTER_REFRESH_PERIOD from ClusterConfig #358

narendly commented on issue #373: Remove DEFAULT_VIEW_CLUSTER_REFRESH_PERIOD from ClusterConfig #358 URL: https://github.com/apache/helix/pull/373#issuecomment-518325951 This PR is ready to be merged, approved by @alirezazamani

[GitHub] [helix] narendly opened a new pull request #373: Remove DEFAULT_VIEW_CLUSTER_REFRESH_PERIOD from ClusterConfig #358

narendly opened a new pull request #373: Remove DEFAULT_VIEW_CLUSTER_REFRESH_PERIOD from ClusterConfig #358 URL: https://github.com/apache/helix/pull/373 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR title: #358 ###

helix - Build # 1639 - Still Failing

The Apache Jenkins build system has built helix (build #1639) Status: Still Failing Check console output at https://builds.apache.org/job/helix/1639/ to view the results.

[GitHub] [helix] narendly commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

narendly commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310622237 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

narendly commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310619356 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

narendly commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310624803 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

narendly commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310621901 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

narendly commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310623149 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

narendly commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310623904 ## File path:

[GitHub] [helix] jiajunwang commented on issue #369: Add the workaround fix for assigning partitions when instance weight …

jiajunwang commented on issue #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#issuecomment-518101703 I just notice the title, this is not a workaround. Please remove this to avoid confusion.