Re: [RESULT][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

Hi, Julien! > Q: Do you have a way to tests for memory leaks as part of unit tests? > Q: Do you have other ways to detect that as part of the release process? We are thinking about a startup *command line flag* that will (if present) run all native components under Valgrind. I will get back when

Re: [RESULT][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

Dmitry is working on Valgrind related things. ^^ On Sat, Apr 27, 2019 at 8:57 PM Xiaoyao Qian wrote: > To turn on heapcheck, just need to set ENABLE_HEAPCHECK=1 in the build > environment. The heapcheck report will be at the end of > heron-executor-*.stdout when the executor instance gracefully

Re: [RESULT][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

To turn on heapcheck, just need to set ENABLE_HEAPCHECK=1 in the build environment. The heapcheck report will be at the end of heron-executor-*.stdout when the executor instance gracefully shuts down. I was having a hard time decoding the heapcheck report into human readable format though. Dmitry

Re: [RESULT][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

On Thu, Apr 25, 2019 at 9:43 PM Ning Wang wrote: > Thans Julien! > > For the release check instructions, here is a tracking ticket: > https://github.com/apache/incubator-heron/issues/3246 > > thanks > About the other questions: > Q: Do you have a way to tests for memory leaks as part of unit

Re: [RESULT][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

Thans Julien! For the release check instructions, here is a tracking ticket: https://github.com/apache/incubator-heron/issues/3246 About the other questions: Q: Do you have a way to tests for memory leaks as part of unit tests? Yes. We have heap check with unit tests as well as integration

Re: [Mentors][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

On Thu, Apr 25, 2019 at 9:09 PM Ning Wang wrote: > Thanks. > > We fixed one memory leak issue in Jan and the fix is included in this RC. > Could you please create an issue for us to investigate? > > > On Thu, Apr 25, 2019 at 7:30 PM thinker0 wrote: > >> -1 : The stream manager has a large

Re: [RESULT][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

For what it's worth. I was able to build, verify the signature and run the rat report. So I was going to vote when thinker0 reported the issue. It would be nice to have clear an precise step by step instructions for validating the release. (and specifically the release) For example, the apache

[RESULT][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

Hi, A memory leak issue was reported with this release, plus a fix is needed for status script. I am closing this vote now and will prepare a new release candidate after the issues are resolved. Thanks a lot for all the help! --ning On Sun, Apr 21, 2019 at 11:30 PM Ning Wang wrote: > > > On

Re: [Mentors][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

Thanks. We fixed one memory leak issue in Jan and the fix is included in this RC. Could you please create an issue for us to investigate? On Thu, Apr 25, 2019 at 7:30 PM thinker0 wrote: > -1 : The stream manager has a large memory leak. > > 2019년 4월 26일 (금) 오전 7:58, Ning Wang 님이 작성: > > > I

Re: [Mentors][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

-1 : The stream manager has a large memory leak. 2019년 4월 26일 (금) 오전 7:58, Ning Wang 님이 작성: > I believe I found the issue. Here is the PR: > https://github.com/apache/incubator-heron/pull/3245 > > On Wed, Apr 24, 2019 at 7:44 PM Ning Wang wrote: > > > Yeah. It is sufficient to use the bazel

Re: [Mentors][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

I believe I found the issue. Here is the PR: https://github.com/apache/incubator-heron/pull/3245 On Wed, Apr 24, 2019 at 7:44 PM Ning Wang wrote: > Yeah. It is sufficient to use the bazel command. I will use it in the > future. Thanks for the suggestion. > > On Wed, Apr 24, 2019 at 5:19 PM Josh

Re: [Mentors][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

nevermind: https://github.com/bazelbuild/bazel/releases?after=0.15.0 It seems brew knows only about the latest version. On Wed, Apr 24, 2019 at 3:15 PM Julien Le Dem wrote: > how does one install bazel 0.14? > > On Wed, Apr 24, 2019 at 2:59 PM Ning Wang wrote: > >> Thanks Julien! >> >> Yeah.

Re: [Mentors][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

Would it be sufficient for Julien to not use the "build_release_packages.sh" script and just the bazel command to generate the heron-install.sh script and install and run from there? Something similar to "bazel build --config=darwin scripts/packages:binpkgs"? On Wed, Apr 24, 2019 at 6:56 PM Ning

Re: [Mentors][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

Tracking ticket created: https://github.com/apache/incubator-heron/issues/3243 On Wed, Apr 24, 2019 at 4:44 PM Ning Wang wrote: > I see. I think it is something I need to take a look at. > > The link is the official steps and it should work. > > The script is a convenient script and it is used

Re: [Mentors][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

I see. I think it is something I need to take a look at. The link is the official steps and it should work. The script is a convenient script and it is used by the CI job to make a build. On Wed, Apr 24, 2019 at 4:41 PM Julien Le Dem wrote: > In your email you say: > > Please download the

Re: [Mentors][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

In your email you say: Please download the source package, and follow the compiling guide( https://apache.github.io/incubator-heron/docs/developers/compiling/compiling/ Which I guess you mean only to setup your environment? And then use the script to build: "sh

Re: [Mentors][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

following step 6: https://apache.github.io/incubator-heron/docs/developers/compiling/mac/ On Wed, Apr 24, 2019 at 4:23 PM Ning Wang wrote: > Thanks a lot! > > For the questions: > 1. version of Bazel is on the website. We are fixing it currently. > 2. What is the command you use to build? This

Re: [Mentors][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

So the build works now. However I get this error: *ERROR: *Process exited with status 1: Process exited with status 1 scripts/release/status.sh: line 62: HERON_BUILD_VERSION: unbound variable INFO: Elapsed time: 408.083s, Critical Path: 371.21s INFO: 1859 processes: 1525 local, 334 worker.

Re: [Mentors][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

Thanks a lot! For the questions: 1. version of Bazel is on the website. We are fixing it currently. 2. What is the command you use to build? This error is not expected. I might missed it somewhere. On Wed, Apr 24, 2019 at 4:14 PM Julien Le Dem wrote: > I did set > >

Re: [Mentors][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

I did set HERON_BUILD_VERSION=v0.20.1-incubating and it works On Wed, Apr 24, 2019 at 4:12 PM Julien Le Dem wrote: > So the build works now. However I get this error: > > *ERROR: *Process exited with status 1: Process exited with status 1 > > scripts/release/status.sh: line 62:

Re: [Mentors][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

Basically download the installer from bazel website ( https://github.com/bazelbuild/bazel/releases) and then run: ./bazel--installer-darwin-x86_64.sh --user On Wed, Apr 24, 2019 at 3:15 PM Julien Le Dem wrote: > how does one install bazel 0.14? > > On Wed, Apr 24, 2019 at 2:59 PM Ning Wang

Re: [Mentors][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

See https://docs.bazel.build/versions/master/install-os-x.html > On Apr 24, 2019, at 3:15 PM, Julien Le Dem > wrote: > > how does one install bazel 0.14? > > On Wed, Apr 24, 2019 at 2:59 PM Ning Wang wrote: > >> Thanks Julien! >> >> Yeah. This RC was still with Bazel 0.14.1 since it was

Re: [Mentors][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

how does one install bazel 0.14? On Wed, Apr 24, 2019 at 2:59 PM Ning Wang wrote: > Thanks Julien! > > Yeah. This RC was still with Bazel 0.14.1 since it was created in February. > Latest master works with Bazel 0.23.1. > > On Wed, Apr 24, 2019 at 2:47 PM Julien Le Dem > wrote: > > > I was

Re: [Mentors][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

Thanks Julien! Yeah. This RC was still with Bazel 0.14.1 since it was created in February. Latest master works with Bazel 0.23.1. On Wed, Apr 24, 2019 at 2:47 PM Julien Le Dem wrote: > I was able to build from master but not from the release tarbal. > Is Bazel 0.14.1 actually required? Current

Re: [Mentors][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

I was able to build from master but not from the release tarbal. Is Bazel 0.14.1 actually required? Current release is 0.24.1. On Wed, Apr 24, 2019 at 2:25 PM Julien Le Dem wrote: > I'm looking into it. > I recently got a new laptop so doing the setup from scratch. > I had to follow: >

Re: [Mentors][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

MacBook-Pro-Julien:incubator-heron-0.20.1-incubating-rc2 jledem$ bazel build --config=darwin heron/... WARNING: The following rc files are no longer being read, please transfer their contents or import their path into one of the standard rc files:

Re: [Mentors][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

I'm looking into it. I recently got a new laptop so doing the setup from scratch. I had to follow: https://stackoverflow.com/questions/45276830/xcode-version-must-be-specified-to-use-an-apple-crosstool I hit that error at step 6 here:

Re: [Mentors][VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

On Fri, Apr 19, 2019 at 11:52 AM Ning Wang wrote: > Hi, dear Mentors, > > Please help if you have time. :) Thanks in advance. > > --ning > > > On Fri, Apr 19, 2019 at 11:50 AM Ning Wang wrote: > >> *Hello, Heron Community,* >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> *This is a call

Re: [VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

Hi, dear Mentors, Please help if you have time. :) Thanks in advance. --ning On Fri, Apr 19, 2019 at 11:50 AM Ning Wang wrote: > *Hello, Heron Community,* > > > > > > > > > > > > > > > > > > *This is a call for a vote to the 2nd release candidate for Apache Heron, > version

[VOTE] Heron Release 0.20.1-incubating Release Candidate 2 (Second Pass)

*Hello, Heron Community,* *This is a call for a vote to the 2nd release candidate for Apache Heron, version v0.20.1-incubating. This is a second pass since Dave pointed out a few things that we weren’t clear before. The git tag is the same as the last time and the previous votes

Re: Jenkins & Binaries - Re: [DISCUSS][VOTE] Heron Release 0.20.1-incubating (Release Candidate 2)

Ok. Sounds reasonable. On Wed, Apr 3, 2019 at 3:31 PM Dave Fisher wrote: > Hi - > > > On Apr 3, 2019, at 3:20 PM, Ning Wang wrote: > > > > Got it. Thanks. > > > > My bad. I meant for this version (before the review). > > Look into the License of all the dependent code and packages included in

Re: Jenkins & Binaries - Re: [DISCUSS][VOTE] Heron Release 0.20.1-incubating (Release Candidate 2)

Hi - > On Apr 3, 2019, at 3:20 PM, Ning Wang wrote: > > Got it. Thanks. > > My bad. I meant for this version (before the review). Look into the License of all the dependent code and packages included in the built binary. There will then need to be procedures to understand when new

Re: Jenkins & Binaries - Re: [DISCUSS][VOTE] Heron Release 0.20.1-incubating (Release Candidate 2)

Got it. Thanks. My bad. I meant for this version (before the review). One more question, what exactly we need to do to review license? On Wed, Apr 3, 2019 at 12:13 PM Dave Fisher wrote: > Hi - > > > On Apr 3, 2019, at 11:50 AM, Ning Wang wrote: > > > > *Inline. > > > > On Wed, Apr 3, 2019 at

Re: Jenkins & Binaries - Re: [DISCUSS][VOTE] Heron Release 0.20.1-incubating (Release Candidate 2)

Hi - > On Apr 3, 2019, at 11:50 AM, Ning Wang wrote: > > *Inline. > > On Wed, Apr 3, 2019 at 11:36 AM Dave Fisher wrote: > >> Hi - >> >> See inline: >> > > For docker hub image, I published it to > *https://hub.docker.com/r/apacheheron/heron/tags >

Re: Jenkins & Binaries - Re: [DISCUSS][VOTE] Heron Release 0.20.1-incubating (Release Candidate 2)

*Inline. On Wed, Apr 3, 2019 at 11:36 AM Dave Fisher wrote: > Hi - > > See inline: > > >>> > >>> For docker hub image, I published it to > >>> *https://hub.docker.com/r/apacheheron/heron/tags > >>> . It is not the right > >> one? > >>> I got an

Jenkins & Binaries - Re: [DISCUSS][VOTE] Heron Release 0.20.1-incubating (Release Candidate 2)

Hi - See inline: >>> >>> For docker hub image, I published it to >>> *https://hub.docker.com/r/apacheheron/heron/tags >>> . It is not the right >> one? >>> I got an invite after becoming a committer then I thought this is the >>> official one.

[DISCUSS][VOTE] Heron Release 0.20.1-incubating (Release Candidate 2)

Hi - > On Apr 1, 2019, at 2:23 PM, Ning Wang wrote: > > Hi, > > For the 0.20.1-incubating-rc2 release: > > So we should require more buy-ins from mentors for the release before > moving to general@ mailing list? Maybe let's have a rule like minimal two > Mentors? Sounds good to me but let's

Re: [VOTE] Heron Release 0.20.1-incubating (Release Candidate 2)

Hi, For the 0.20.1-incubating-rc2 release: So we should require more buy-ins from mentors for the release before moving to general@ mailing list? Maybe let's have a rule like minimal two Mentors? Sounds good to me but let's make a decision. For docker hub image, I published it to

Re: [VOTE] Heron Release 0.20.1-incubating (Release Candidate 2)

And - general@incubator mailing list. On Mon, Apr 1, 2019 at 1:53 PM Ning Wang wrote: > Ok. Thanks! > > On Mon, Apr 1, 2019 at 11:55 AM Dave Fisher wrote: > >> -1 - we need to carefully discuss this on dev@heron. >> >> I seem to be the only Heron Mentor paying attention. We need more than me!

Re: [Cancelled] [VOTE] Heron Release 0.20.1-incubating (Release Candidate 2)

Let's cancel this vote for now and go back to dev mailing list to discuss more. On Mon, Apr 1, 2019 at 1:53 PM Ning Wang wrote: > Ok. Thanks! > > On Mon, Apr 1, 2019 at 11:55 AM Dave Fisher wrote: > >> -1 - we need to carefully discuss this on dev@heron. >> >> I seem to be the only Heron

Re: [VOTE] Heron Release 0.20.1-incubating (Release Candidate 2)

Ok. Thanks! On Mon, Apr 1, 2019 at 11:55 AM Dave Fisher wrote: > -1 - we need to carefully discuss this on dev@heron. > > I seem to be the only Heron Mentor paying attention. We need more than me! > > (1) I cannot really follow this email > (2) We still need to discuss the docker hub image. (I

[RESULT] [Vote] Heron Release 0.20.1-incubating Release Candidate 2

Dear all, Here is the vote result for Heron release 0.20.1-incubating release candidate 2: The vote has been open for more than 72 hours. We have 4 +1 votes, no 0s and no -1s. +1s: thinker0, Karthik Ramasamy, Josh Fischer, Simong Weng. Regards, --ning

Re: [VOTE] Heron Release 0.20.1-incubating Release Candidate 2

+1 On Fri, Mar 29, 2019 at 6:26 AM Josh Fischer wrote: > +1 > > On Thu, Mar 28, 2019 at 11:27 PM Ning Wang wrote: > > > Nice~ Thanks thinker0! > > > > On Thu, Mar 28, 2019 at 8:29 PM thinker0 wrote: > > > > > +1 We are using it well for production. > > > > > > 2019년 3월 29일 (금) 오전 8:00, Ning

Re: [VOTE] Heron Release 0.20.1-incubating Release Candidate 2

+1 On Thu, Mar 28, 2019 at 11:27 PM Ning Wang wrote: > Nice~ Thanks thinker0! > > On Thu, Mar 28, 2019 at 8:29 PM thinker0 wrote: > > > +1 We are using it well for production. > > > > 2019년 3월 29일 (금) 오전 8:00, Ning Wang 님이 작성: > > > > > *Hello, Heron Community,This is a call for vote to the

Re: [VOTE] Heron Release 0.20.1-incubating Release Candidate 2

Nice~ Thanks thinker0! On Thu, Mar 28, 2019 at 8:29 PM thinker0 wrote: > +1 We are using it well for production. > > 2019년 3월 29일 (금) 오전 8:00, Ning Wang 님이 작성: > > > *Hello, Heron Community,This is a call for vote to the 2nd release > > candidate for Apache Heron, version v0.20.1-incubating.The

Re: [VOTE] Heron Release 0.20.1-incubating Release Candidate 2

+1 On Thu, Mar 28, 2019 at 8:29 PM thinker0 wrote: > +1 We are using it well for production. > > 2019년 3월 29일 (금) 오전 8:00, Ning Wang 님이 작성: > > > *Hello, Heron Community,This is a call for vote to the 2nd release > > candidate for Apache Heron, version v0.20.1-incubating.The tag to be > voted >

Re: [VOTE] Heron Release 0.20.1-incubating Release Candidate 2

+1 We are using it well for production. 2019년 3월 29일 (금) 오전 8:00, Ning Wang 님이 작성: > *Hello, Heron Community,This is a call for vote to the 2nd release > candidate for Apache Heron, version v0.20.1-incubating.The tag to be voted > upon:0.20.1-incubating-rc2

[VOTE] Heron Release 0.20.1-incubating Release Candidate 2

*Hello, Heron Community,This is a call for vote to the 2nd release candidate for Apache Heron, version v0.20.1-incubating.The tag to be voted upon:0.20.1-incubating-rc2 (e6134da336fa290fa1b40972bc747a7507948d8a)The full list of changes and release notes are available