Re: Review Request 56070: HIVE-15748

2017-01-30 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56070/#review163620 ---

Review Request 56110: Fix ConcurrentModification Excpetion in HIVE-15760

2017-01-30 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56110/ --- Review request for hive and Jason Dere. Bugs: HIVE-15760

Re: Review Request 55816: HIVE-15680: Incorrect results when hive.optimize.index.filter=true and same ORC table is referenced twice in query

2017-01-30 Thread Anthony Hsu
> On Jan. 30, 2017, 4:53 p.m., Peter Vary wrote: > > Hi Anthony, > > > > I am not too familiar with the ORC tables, but currently wokring on > > enabling yetus on Hive. > > > > Yetus runs several checks which might help the work of the reviewers. Here > > is what Yetus found with the

Re: Review Request 55816: HIVE-15680: Incorrect results when hive.optimize.index.filter=true and same ORC table is referenced twice in query

2017-01-30 Thread Anthony Hsu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55816/ --- (Updated Jan. 31, 2017, 2:43 a.m.) Review request for hive. Changes ---

Review Request 56108: HIVE-15688 LlapServiceDriver slider APIs

2017-01-30 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56108/ --- Review request for hive, Gopal V and Siddharth Seth. Repository: hive-git

Re: Review Request 55977: HIVE-15672 LLAP text cache: improve first query perf II

2017-01-30 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55977/ --- (Updated Jan. 31, 2017, 1:17 a.m.) Review request for hive, Gopal V and

Re: Review Request 56070: HIVE-15748

2017-01-30 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56070/ --- (Updated Jan. 31, 2017, 12:44 a.m.) Review request for hive and Jason Dere.

Re: Review Request 56070: HIVE-15748

2017-01-30 Thread Deepak Jaiswal
> On Jan. 30, 2017, 10:27 p.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java, > > line 33 > > > > > > importing * is not normally considered to be good form, try to

Re: Review Request 56070: HIVE-15748

2017-01-30 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56070/#review163574 ---

Re: Invitation for Hive committers to become ORC committers

2017-01-30 Thread Owen O'Malley
Carl, Sorry about that. I've just added you and Jimmy. .. Owen On Mon, Jan 30, 2017 at 1:37 PM, Carl Steinbach wrote: > Hi Chris, > > Can you please add Jimmy and me to the ORC committer list? > > Thanks. > > - Carl > > On Sun, Jan 22, 2017 at 5:18 PM, Jimmy Xiang

Re: Invitation for Hive committers to become ORC committers

2017-01-30 Thread Carl Steinbach
Hi Chris, Can you please add Jimmy and me to the ORC committer list? Thanks. - Carl On Sun, Jan 22, 2017 at 5:18 PM, Jimmy Xiang wrote: > Hi Owen, > > I am also interested. > > Thanks, > Jimmy > > > On Sun, Jan 22, 2017 at 2:16 PM, Carl Steinbach >

Review Request 56095: HIVE-15754 exchange partition is not generating notifications

2017-01-30 Thread Nachiket Vaidya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56095/ --- Review request for hive and Mohit Sabharwal. Bugs: HIVE-15754

Re: Review Request 55994: HIVE-15736: Add unit tests to Utilities.getInputSummary() method for multi-threading cases

2017-01-30 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55994/ --- (Updated Jan. 30, 2017, 8:48 p.m.) Review request for hive, Mohit Sabharwal,

Re: Review Request 55994: HIVE-15736: Add unit tests to Utilities.getInputSummary() method for multi-threading cases

2017-01-30 Thread Sergio Pena
> On Jan. 28, 2017, 1:30 a.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java, line 894 > > > > > > Not sure I understand this part. Passing in false invokes > >

Re: Review Request 56025: HIVE-15723 Hive should report a warning about missing table/column statistics to user.

2017-01-30 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56025/#review163534 --- Hi Remus, I am not too familiar how the colstats are propagated,

Re: Review Request 55816: HIVE-15680: Incorrect results when hive.optimize.index.filter=true and same ORC table is referenced twice in query

2017-01-30 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55816/#review163528 --- Hi Anthony, I am not too familiar with the ORC tables, but

Re: Review Request 55994: HIVE-15736: Add unit tests to Utilities.getInputSummary() method for multi-threading cases

2017-01-30 Thread Peter Vary
> On Jan. 27, 2017, 3:37 p.m., Peter Vary wrote: > > Hi Sergio, > > > > Looking through the patch I did not find anything useful to enhance what > > you did :) > > > > I did run the yetus pre-commit stuff on it (author, checkstyle, javadoc, > > findbugs, whitespace, asflicense), and it came

Re: Review Request 56025: HIVE-15723 Hive should report a warning about missing table/column statistics to user.

2017-01-30 Thread Remus Rusanu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56025/ --- (Updated Jan. 30, 2017, 10:30 a.m.) Review request for hive and Ashutosh

Review Request 56070: HIVE-15748

2017-01-30 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56070/ --- Review request for hive and Jason Dere. Bugs: HIVE-15748