[jira] [Created] (HIVE-18783) Set Notification ID for Alter Table event

2018-02-22 Thread Na Li (JIRA)
Na Li created HIVE-18783: Summary: Set Notification ID for Alter Table event Key: HIVE-18783 URL: https://issues.apache.org/jira/browse/HIVE-18783 Project: Hive Issue Type: Bug Reporter:

[jira] [Created] (HIVE-18782) NullPointerException when inserting into a table with complex data type

2018-02-22 Thread Vineet Garg (JIRA)
Vineet Garg created HIVE-18782: -- Summary: NullPointerException when inserting into a table with complex data type Key: HIVE-18782 URL: https://issues.apache.org/jira/browse/HIVE-18782 Project: Hive

Re: Review Request 65766: HIVE-18738 LLAP IO ACID - includes handling is broken

2018-02-22 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65766/#review198160 ---

Review Request 65766: HIVE-18738 LLAP IO ACID - includes handling is broken

2018-02-22 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65766/ --- Review request for hive, Prasanth_J and Teddy Choi. Repository: hive-git

[jira] [Created] (HIVE-18781) Create/Replicate Abort Txn event

2018-02-22 Thread mahesh kumar behera (JIRA)
mahesh kumar behera created HIVE-18781: -- Summary: Create/Replicate Abort Txn event Key: HIVE-18781 URL: https://issues.apache.org/jira/browse/HIVE-18781 Project: Hive Issue Type: Task

Re: Review Request 65716: HIVE-18696: The partition folders might not get cleaned up properly in the HiveMetaStore.add_partitions_core method if an exception occurs

2018-02-22 Thread Sahil Takiar
> On Feb. 21, 2018, 3:32 p.m., Sahil Takiar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 3149-3150 (patched) > > > > > > curious what behavior you were

[jira] [Created] (HIVE-18780) Improve schema discovery For Druid Storage Handler

2018-02-22 Thread slim bouguerra (JIRA)
slim bouguerra created HIVE-18780: - Summary: Improve schema discovery For Druid Storage Handler Key: HIVE-18780 URL: https://issues.apache.org/jira/browse/HIVE-18780 Project: Hive Issue

[jira] [Created] (HIVE-18779) Hive does not enable ppd to underlying storage format by default

2018-02-22 Thread Keith Sun (JIRA)
Keith Sun created HIVE-18779: Summary: Hive does not enable ppd to underlying storage format by default Key: HIVE-18779 URL: https://issues.apache.org/jira/browse/HIVE-18779 Project: Hive Issue

[jira] [Created] (HIVE-18778) Needs to capture input/output entities in explain

2018-02-22 Thread Daniel Dai (JIRA)
Daniel Dai created HIVE-18778: - Summary: Needs to capture input/output entities in explain Key: HIVE-18778 URL: https://issues.apache.org/jira/browse/HIVE-18778 Project: Hive Issue Type: Bug

[GitHub] hive pull request #310: HIVE-17580 : Remove dependency of get_fields_with_en...

2018-02-22 Thread vihangk1
GitHub user vihangk1 opened a pull request: https://github.com/apache/hive/pull/310 HIVE-17580 : Remove dependency of get_fields_with_environment_context API to serde This version of patch moves TypeInfo and its sub-classes to standalone-metastore. The motivation of doing this is

Re: Review Request 65753: HIVE-18771 Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration

2018-02-22 Thread Sahil Takiar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65753/#review198143 --- Ship it! Ship It! - Sahil Takiar On Feb. 22, 2018, 7:02

Re: Review Request 65753: HIVE-18771 Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration

2018-02-22 Thread Sahil Takiar
> On Feb. 22, 2018, 4:45 p.m., Sahil Takiar wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/MetaStoreClientTest.java > > Lines 60 (patched) > > > > > > can this be `private` > >

[jira] [Created] (HIVE-18777) Add Authorization interface to support information_schema integration with external authorization

2018-02-22 Thread Thejas M Nair (JIRA)
Thejas M Nair created HIVE-18777: Summary: Add Authorization interface to support information_schema integration with external authorization Key: HIVE-18777 URL: https://issues.apache.org/jira/browse/HIVE-18777

[jira] [Created] (HIVE-18776) MaterializationsInvalidationCache loading causes race condition in the metastore

2018-02-22 Thread Alan Gates (JIRA)
Alan Gates created HIVE-18776: - Summary: MaterializationsInvalidationCache loading causes race condition in the metastore Key: HIVE-18776 URL: https://issues.apache.org/jira/browse/HIVE-18776 Project:

[jira] [Created] (HIVE-18775) HIVE-17983 missed deleting metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql

2018-02-22 Thread Vineet Garg (JIRA)
Vineet Garg created HIVE-18775: -- Summary: HIVE-17983 missed deleting metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql Key: HIVE-18775 URL: https://issues.apache.org/jira/browse/HIVE-18775

[jira] [Created] (HIVE-18774) ACID: Use the _copy_N files copyNumber as the implicit statement-id

2018-02-22 Thread Gopal V (JIRA)
Gopal V created HIVE-18774: -- Summary: ACID: Use the _copy_N files copyNumber as the implicit statement-id Key: HIVE-18774 URL: https://issues.apache.org/jira/browse/HIVE-18774 Project: Hive Issue

Re: Review Request 65746: HIVE-18768: Use Datanucleus to serialize notification updates

2018-02-22 Thread Vihang Karajgaonkar via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65746/#review198134 --- Ship it! Patch LGTM - Vihang Karajgaonkar On Feb. 22, 2018,

Re: Review Request 65753: HIVE-18771 Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration

2018-02-22 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65753/ --- (Updated Feb. 22, 2018, 7:02 p.m.) Review request for hive, Marta Kuczora,

Re: Review Request 65753: HIVE-18771 Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration

2018-02-22 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65753/ --- (Updated Feb. 22, 2018, 6:49 p.m.) Review request for hive, Marta Kuczora,

Re: Review Request 65753: HIVE-18771 Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration

2018-02-22 Thread Peter Vary via Review Board
> On Feb. 22, 2018, 4:45 p.m., Sahil Takiar wrote: > > so just to clarify, the creation of metastore instances is moving from the > > individual contructors to a `BeforeClass` method? Thanks for the review! Yes! This is the main change in the patch - run start the metastore instances once per

Re: reverting test-breaking changes

2018-02-22 Thread Vihang Karajgaonkar
+1 Commenting on JIRA and giving a 24hr heads-up (excluding weekends) would be good. On Thu, Feb 22, 2018 at 10:19 AM, Alan Gates wrote: > +1. > > Alan. > > On Thu, Feb 22, 2018 at 8:25 AM, Thejas Nair > wrote: > > > +1 > > I agree, this makes

Re: Review Request 65634: HIVE-18264: CachedStore: Store cached partitions/col stats within the table cache

2018-02-22 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65634/#review198082 ---

Re: reverting test-breaking changes

2018-02-22 Thread Alan Gates
+1. Alan. On Thu, Feb 22, 2018 at 8:25 AM, Thejas Nair wrote: > +1 > I agree, this makes sense. The number of failures keeps increasing. > A 24 hour heads up in either case before revert would be good. > > > On Thu, Feb 22, 2018 at 2:45 AM, Peter Vary

[jira] [Created] (HIVE-18773) Support multiple instances of Cleaner

2018-02-22 Thread Eugene Koifman (JIRA)
Eugene Koifman created HIVE-18773: - Summary: Support multiple instances of Cleaner Key: HIVE-18773 URL: https://issues.apache.org/jira/browse/HIVE-18773 Project: Hive Issue Type: Improvement

[jira] [Created] (HIVE-18772) Make Acid Cleaner use MIN_HISTORY_LEVEL

2018-02-22 Thread Eugene Koifman (JIRA)
Eugene Koifman created HIVE-18772: - Summary: Make Acid Cleaner use MIN_HISTORY_LEVEL Key: HIVE-18772 URL: https://issues.apache.org/jira/browse/HIVE-18772 Project: Hive Issue Type:

Re: Review Request 65756: HIVE-18060 UpdateInputAccessTimeHook fails for non-current database

2018-02-22 Thread Zoltan Haindrich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65756/#review198127 --- Could you please add a test for this use case? The one in the

Re: Review Request 65755: HIVE-18279 Incorrect condition in StatsOpimizer

2018-02-22 Thread Zoltan Haindrich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65755/#review198126 ---

Re: Review Request 65753: HIVE-18771 Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration

2018-02-22 Thread Sahil Takiar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65753/#review198121 --- so just to clarify, the creation of metastore instances is moving

Re: reverting test-breaking changes

2018-02-22 Thread Thejas Nair
+1 I agree, this makes sense. The number of failures keeps increasing. A 24 hour heads up in either case before revert would be good. On Thu, Feb 22, 2018 at 2:45 AM, Peter Vary wrote: > I agree with Zoltan. The continuously braking tests make it very hard to > spot real

Re: Review Request 65757: Remove the unnecessary HiveConf dependency for MiniHiveKdc

2018-02-22 Thread daniel voros
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65757/ --- (Updated Feb. 22, 2018, 4:09 p.m.) Review request for hive. Bugs: HIVE-18327

Review Request 65757: Remove the unnecessary HiveConf dependency for MiniHiveKdc

2018-02-22 Thread daniel voros
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65757/ --- Review request for hive. Bugs: HIVE-18327

Review Request 65756: HIVE-18060 UpdateInputAccessTimeHook fails for non-current database

2018-02-22 Thread Oleksiy Sayankin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65756/ --- Review request for hive, Ashutosh Chauhan and Zoltan Haindrich. Repository:

Review Request 65755: HIVE-18279 Incorrect condition in StatsOpimizer

2018-02-22 Thread Oleksiy Sayankin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65755/ --- Review request for hive, Ashutosh Chauhan, Zoltan Haindrich, and Zoltan

Review Request 65754: HIVE-18702 INSERT OVERWRITE TABLE doesn't clean the table directory before overwriting

2018-02-22 Thread Oleksiy Sayankin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65754/ --- Review request for hive and Ashutosh Chauhan. Repository: hive-git

Re: Review Request 65716: HIVE-18696: The partition folders might not get cleaned up properly in the HiveMetaStore.add_partitions_core method if an exception occurs

2018-02-22 Thread Marta Kuczora via Review Board
> On Feb. 21, 2018, 3:32 p.m., Sahil Takiar wrote: > > Would be good to know which Hive queries invoke this method. Thanks a lot Sahil for the review. I will check where these methods are used and come back to you with the answer a bit later. - Marta

Re: Review Request 65716: HIVE-18696: The partition folders might not get cleaned up properly in the HiveMetaStore.add_partitions_core method if an exception occurs

2018-02-22 Thread Marta Kuczora via Review Board
> On Feb. 21, 2018, 3:32 p.m., Sahil Takiar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Line 3032 (original), 3065 (patched) > > > > > > this code looks

Re: Review Request 65716: HIVE-18696: The partition folders might not get cleaned up properly in the HiveMetaStore.add_partitions_core method if an exception occurs

2018-02-22 Thread Marta Kuczora via Review Board
> On Feb. 21, 2018, 1:38 p.m., Peter Vary wrote: > > Thanks for the patch Marta! > > Mostly just questions. > > Peter Thanks a lot Peter for the review. > On Feb. 21, 2018, 1:38 p.m., Peter Vary wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java

Review Request 65753: HIVE-18771 Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration

2018-02-22 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65753/ --- Review request for hive, Marta Kuczora, Sahil Takiar, and Adam Szita. Bugs:

Re: reverting test-breaking changes

2018-02-22 Thread Peter Vary
I agree with Zoltan. The continuously braking tests make it very hard to spot real issues. Any thoughts on doing it automatically? > On Feb 22, 2018, at 10:47 AM, Zoltan Haindrich wrote: > > * > > Hello, > > * > * > > ** > > In the last couple weeks the number of broken tests

Re: Review Request 65731: HIVE-18699: Check for duplicate partitions in HiveMetastore.exchange_partitions

2018-02-22 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65731/#review198106 --- Ship it! Ship It! - Adam Szita On Feb. 21, 2018, 11:37

Re: Review Request 65731: HIVE-18699: Check for duplicate partitions in HiveMetastore.exchange_partitions

2018-02-22 Thread Adam Szita via Review Board
> On Feb. 21, 2018, 1:37 p.m., Peter Vary wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 3370 (patched) > > > > > > How "expensive" is this call? Is this

[jira] [Created] (HIVE-18771) Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration

2018-02-22 Thread Peter Vary (JIRA)
Peter Vary created HIVE-18771: - Summary: Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration Key: HIVE-18771 URL: https://issues.apache.org/jira/browse/HIVE-18771

reverting test-breaking changes

2018-02-22 Thread Zoltan Haindrich
* Hello, * * ** In the last couple weeks the number of broken tests have started to go up...and even tho I run bisect/etc from time to time ; sometimes people don’t react to my comments/tickets/etc. Because keeping this many failing tests makes it easier for a new one to slip in...I