Illya Yalovyy created HIVE-16158:
Summary: Correct mistake in documentation for ALTER TABLE …
ADD/REPLACE COLUMNS CASCADE
Key: HIVE-16158
URL: https://issues.apache.org/jira/browse/HIVE-16158
Project
2080)
<https://reviews.apache.org/r/56688/#comment238311>
I feel like we need a unit test for this method.
- Illya Yalovyy
On Feb. 22, 2017, 4:28 p.m., Sergio Pena wrote:
>
> ---
> This is an automatically generated e
va/org/apache/hive/storagehandler/db/oracle/HiveOracleVendorBridge.java
(line 74)
<https://reviews.apache.org/r/54711/#comment230240>
return String.format("SELECT \* FROM %s WHERE ROWNUM = 0", tableName);
The name should be escaped.
F
]
[INFO] Total time: 03:14 min
[INFO] Finished at: 2016-10-26T13:53:15-07:00
[INFO] Final Memory: 36M/1091M
[INFO]
Thanks,
Illya Yalovyy
onstant string
> > "hive.server2.authentication.ldap.userMembershipKey" here like most of
> > other entries?
>
> Illya Yalovyy wrote:
> Because it uses in several places. In particular in documentation.
> Putting a string in documentation is not maintainable,
SUCCESS
[INFO]
[INFO] Total time: 03:14 min
[INFO] Finished at: 2016-10-26T13:53:15-07:00
[INFO] Final Memory: 36M/1091M
[INFO]
Thanks,
Illya Yalovyy
need to add some tests for the default configuraiton which is
> > null for HIVE_SERVER2_PLAIN_LDAP_USERMEMBERSHIP_KEY.
>
> Illya Yalovyy wrote:
> If HIVE_SERVER2_PLAIN_LDAP_USERMEMBERSHIP_KEY is NULL this filter will
> not be used. I think we have enough test for this case.
d to change message since it's expected that the user is not
> > in some groups. Probably change to "Cannot match user ... and group ..."
> > since "Failed to" seems to be an error.
>
> Illya Yalovyy wrote:
> I will update the message.
Usually it shoul
ndle NPE so NPE may cause some problems.
> >
> > If userMembershipAttr is null, will we still check userMememberOfGroup
> > or not? If not, maybe we should handle such exception here. How about
> > groupMembershipAttr above? Seems we will have such issue as well.
>
&
bershipAttr is null, will we still check userMememberOfGroup
> > or not? If not, maybe we should handle such exception here. How about
> > groupMembershipAttr above? Seems we will have such issue as well.
I think it should not happen, but I'll double check.
-
min
[INFO] Finished at: 2016-10-26T13:53:15-07:00
[INFO] Final Memory: 36M/1091M
[INFO]
Thanks,
Illya Yalovyy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54393/#review158221
---
Ship it!
Ship It!
- Illya Yalovyy
On Dec. 6, 2016, 8:13 p.m
you don't have to call getters here.
ql/src/java/org/apache/hadoop/hive/ql/plan/LoadTableDesc.java (line 52)
<https://reviews.apache.org/r/54393/#comment228768>
Don't have to call getters here.
Could you also add a test with a strict dynamic partitioning, like:
INSERT OVERWRITE TA
this best practice.
- Illya Yalovyy
On Oct. 28, 2016, 12:59 p.m., Illya Yalovyy wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53204/
>
test for it
in hive-blobstore package.
- Illya Yalovyy
On Nov. 22, 2016, 10:35 p.m., Sergio Pena wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
6>
"." is missing between name and type.
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 2943)
<https://reviews.apache.org/r/53966/#comment226830>
FilenameUtils can do the job:
https://commons.apache.org/proper/commons-io/javadocs/ap
] Finished at: 2016-10-26T13:53:15-07:00
[INFO] Final Memory: 36M/1091M
[INFO]
Thanks,
Illya Yalovyy
Memory: 36M/1091M
[INFO]
Thanks,
Illya Yalovyy
]
Thanks,
Illya Yalovyy
Illya Yalovyy created HIVE-15076:
Summary: Improve scalability of LDAP authentication provider group
filter
Key: HIVE-15076
URL: https://issues.apache.org/jira/browse/HIVE-15076
Project: Hive
]
[INFO] Total time: 04:02 min
[INFO] Finished at: 2016-10-06T12:23:16-07:00
[INFO] Final Memory: 42M/1146M
[INFO]
Thanks,
Illya Yalovyy
Illya Yalovyy created HIVE-14927:
Summary: Remove code duplication from tests in
TestLdapAtnProviderWithMiniDS
Key: HIVE-14927
URL: https://issues.apache.org/jira/browse/HIVE-14927
Project: Hive
]
Thanks,
Illya Yalovyy
]
[INFO] Total time: 04:00 min
[INFO] Finished at: 2016-09-29T21:20:04-07:00
[INFO] Final Memory: 40M/1000M
[INFO]
Thanks,
Illya Yalovyy
Illya Yalovyy created HIVE-14875:
Summary: Enhancement and refactoring of
TestLdapAtnProviderWithMiniDS
Key: HIVE-14875
URL: https://issues.apache.org/jira/browse/HIVE-14875
Project: Hive
6M/984M
[INFO] ----
Thanks,
Illya Yalovyy
Thank you!
- Illya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51694/#review149769
---
On Sept. 20, 2016, 7:39 p.m.
t the search limit? I did not see
> > it is used.
>
> Illya Yalovyy wrote:
> I will be used for different filters. Do you think we should use it for
> existing filters? Which one in particular? Or you would prefer me to remove
> this option?
>
> Please keep in
gt; it is used.
I will be used for different filters. Do you think we should use it for
existing filters? Which one in particular? Or you would prefer me to remove
this option?
Please keep in mind that this CR is not about performance.
- Illya
----------
minor changes on my side.
I'll update this CR in a couple of days.
- Illya Yalovyy
On Sept. 7, 2016, 2:24 p.m., Illya Yalovyy wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
ime: 04:18 min
[INFO] Finished at: 2016-09-06T08:46:04-07:00
[INFO] Final Memory: 66M/984M
[INFO]
Thanks,
Illya Yalovyy
Illya Yalovyy created HIVE-14713:
Summary: LDAP Authentication Provider should be covered with unit
tests
Key: HIVE-14713
URL: https://issues.apache.org/jira/browse/HIVE-14713
Project: Hive
://reviews.apache.org/r/51037/diff/
Testing
---
It can be buld and executed with the latest hive master branch.
Thanks,
Illya Yalovyy
.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-MASTER-Build-674/
Thanks,
Illya Yalovyy
Illya Yalovyy created HIVE-13510:
Summary: Dynamic partitioning doesn’t work when remote metastore
is used
Key: HIVE-13510
URL: https://issues.apache.org/jira/browse/HIVE-13510
Project: Hive
Illya Yalovyy created HIVE-13185:
Summary: orc.ReaderImp.ensureOrcFooter() method fails on small
text files with IndexOutOfBoundsException
Key: HIVE-13185
URL: https://issues.apache.org/jira/browse/HIVE-13185
Illya Yalovyy created HIVE-12715:
Summary: Unit test for HIVE-10685 fix
Key: HIVE-12715
URL: https://issues.apache.org/jira/browse/HIVE-12715
Project: Hive
Issue Type: Test
Illya Yalovyy created HIVE-11882:
Summary: Fetch optimizer should stop source files traversal once
it exceeds the hive.fetch.task.conversion.threshold
Key: HIVE-11882
URL: https://issues.apache.org/jira/browse
iff: https://reviews.apache.org/r/38268/diff/
Testing
---
1. Added new unit tests
2. Added qtest
3. Updated old qtests
Thanks,
Illya Yalovyy
Illya Yalovyy created HIVE-11791:
Summary: Add test for HIVE-10122
Key: HIVE-11791
URL: https://issues.apache.org/jira/browse/HIVE-11791
Project: Hive
Issue Type: Test
Components
Illya Yalovyy created HIVE-11583:
Summary: When PTF is used over a large partitions result could be
corrupted
Key: HIVE-11583
URL: https://issues.apache.org/jira/browse/HIVE-11583
Project: Hive
Illya Yalovyy created HIVE-10980:
Summary: Merge of dynamic partitions loads all data to default
partition
Key: HIVE-10980
URL: https://issues.apache.org/jira/browse/HIVE-10980
Project: Hive
Illya Yalovyy created HIVE-9225:
---
Summary: Windowing functions are not executing efficiently when
the window is identical
Key: HIVE-9225
URL: https://issues.apache.org/jira/browse/HIVE-9225
Project
43 matches
Mail list logo
