Re: [VOTE] Drop support for Java7 in master branch

2017-02-27 Thread Rajat Khandelwal
t; > Here is my +1. > > Vote ends in 72 hours. > Thanks, > Thejas > > PS: I think this would fall under "Code change" under Hive-bylaws, so it > doesn't seem to really require a formal vote thread. But I think this does > merit wider attention than a jira tic

Re: [DISCUSS] Hive 2.1.1 bug fix release

2016-10-09 Thread Rajat Khandelwal
ce the release of 2.1.0, there have been more than 170 fixes > > >> > that went into branch-2.1 (awesome!). Thus, I think it is a good > > >> > time to release 2.1.1. > > >> > > > >> > If you would like some other fixes to be included, please tag >

[jira] [Created] (HIVE-14463) hcatalog server extensions test cases getting stuck

2016-08-08 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created HIVE-14463: --- Summary: hcatalog server extensions test cases getting stuck Key: HIVE-14463 URL: https://issues.apache.org/jira/browse/HIVE-14463 Project: Hive Issue

[jira] [Created] (HIVE-14424) CLIRestoreTest failing in branch 2.1

2016-08-04 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created HIVE-14424: --- Summary: CLIRestoreTest failing in branch 2.1 Key: HIVE-14424 URL: https://issues.apache.org/jira/browse/HIVE-14424 Project: Hive Issue Type: Bug

Question regarding DB Txn Manager

2016-07-29 Thread Rajat Khandelwal
Can somebody please explain or point me to what are db transaction in hive. This is related to https://issues.apache.org/jira/browse/HIVE-14357. I raised this jira after observing a test failures. Would like to gain some understanding regarding what this test failure means, and whether or not the

[jira] [Created] (HIVE-14357) TestDbTxnManager2#testLocksInSubquery failing in branch-2.1

2016-07-27 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created HIVE-14357: --- Summary: TestDbTxnManager2#testLocksInSubquery failing in branch-2.1 Key: HIVE-14357 URL: https://issues.apache.org/jira/browse/HIVE-14357 Project: Hive

Review Request 50443: HIVE-14335: TaskDisplay's return value is not getting deserialized properly

2016-07-26 Thread Rajat Khandelwal
://reviews.apache.org/r/50443/diff/ Testing --- Thanks, Rajat Khandelwal

[jira] [Created] (HIVE-14335) TaskDisplay's return value is not getting deserialized properly

2016-07-26 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created HIVE-14335: --- Summary: TaskDisplay's return value is not getting deserialized properly Key: HIVE-14335 URL: https://issues.apache.org/jira/browse/HIVE-14335 Project: Hive

Re: Version number in branch-2.1

2016-07-26 Thread Rajat Khandelwal
soon (maybe starting the > release process in one or two weeks). > > -- > Jesús > > > > > On 7/25/16, 12:52 PM, "Rajat Khandelwal" <rajatgupt...@gmail.com> wrote: > > >Another thing, When is 2.1.1 planned? > > > >On Mon, Jul 25,

Re: Version number in branch-2.1

2016-07-25 Thread Rajat Khandelwal
es and the version is not updated for them either after the > release has been done. > > I will fix it shortly for branch-2.1 and fix the release instructions. > > -- > Jesús > > > > On 7/25/16, 11:16 AM, "Rajat Khandelwal" <rajatgupt...@gmail.com> wrot

Version number in branch-2.1

2016-07-25 Thread Rajat Khandelwal
Hi https://github.com/apache/hive/blob/branch-2.1/pom.xml#L24 Why is the version not a SNAPSHOT version?

Review Request 49494: HIVE-14144: Permanent functions are showing up in show functions, but describe says it doesn't exist

2016-07-01 Thread Rajat Khandelwal
: https://reviews.apache.org/r/49494/diff/ Testing --- Thanks, Rajat Khandelwal

[jira] [Created] (HIVE-14144) Permanent functions are showing up in show functions, but describe says it doesn't exist

2016-07-01 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created HIVE-14144: --- Summary: Permanent functions are showing up in show functions, but describe says it doesn't exist Key: HIVE-14144 URL: https://issues.apache.org/jira/browse/HIVE-14144

Re: Review Request 49288: HIVE-11402 HS2 - disallow parallel query execution within a single Session

2016-06-28 Thread Rajat Khandelwal
2150) <https://reviews.apache.org/r/49288/#comment205069> Why is the default value false? Existing behaviour should be the default. - Rajat Khandelwal On June 28, 2016, 6:12 a.m., Sergey Shelukhin

Re: Review Request 48544: HIVE-13903: getFunctionInfo is downloading jar on every call

2016-06-10 Thread Rajat Khandelwal
://reviews.apache.org/r/48544/diff/ Testing --- Thanks, Rajat Khandelwal

Review Request 48544: HIVE-13903: getFunctionInfo is downloading jar on every call

2016-06-10 Thread Rajat Khandelwal
d61edf50df576af582aa9e9fb7112f8e72224043 shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java 68fac17311474108389fdf2dcea2baa52504ffd9 Diff: https://reviews.apache.org/r/48544/diff/ Testing --- Thanks, Rajat Khandelwal

Review Request 48118: HIVE-13903: getFunctionInfo is downloading jar on every call

2016-06-01 Thread Rajat Khandelwal
, Rajat Khandelwal

[jira] [Created] (HIVE-13903) getFunctionInfo is downloading jar on every call

2016-06-01 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created HIVE-13903: --- Summary: getFunctionInfo is downloading jar on every call Key: HIVE-13903 URL: https://issues.apache.org/jira/browse/HIVE-13903 Project: Hive Issue

[jira] [Created] (HIVE-13885) Hive session close is not resetting thread name

2016-05-28 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created HIVE-13885: --- Summary: Hive session close is not resetting thread name Key: HIVE-13885 URL: https://issues.apache.org/jira/browse/HIVE-13885 Project: Hive Issue

[jira] [Created] (HIVE-13727) Getting error Failed rule: 'orderByClause clusterByClause distributeByClause sortByClause limitClause can only be applied to the whole union.' in subquery

2016-05-10 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created HIVE-13727: --- Summary: Getting error Failed rule: 'orderByClause clusterByClause distributeByClause sortByClause limitClause can only be applied to the whole union.' in subquery Key: HIVE-13727

Re: Review Request 46929: HIVE-13676: Tests failing because metastore doesn't come up

2016-05-10 Thread Rajat Khandelwal
/apache/hadoop/hive/ql/metadata/TestHiveRemote.java ee95e160c858a93c43f96775b360f28f8d6a178f Diff: https://reviews.apache.org/r/46929/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 46929: HIVE-13676: Tests failing because metastore doesn't come up

2016-05-10 Thread Rajat Khandelwal
/apache/hadoop/hive/ql/io/orc/TestRecordReaderImpl.java fe87794d6df939ec1f061e10162698d36e9836bd ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveRemote.java ee95e160c858a93c43f96775b360f28f8d6a178f Diff: https://reviews.apache.org/r/46929/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 46929: HIVE-13676: Tests failing because metastore doesn't come up

2016-05-10 Thread Rajat Khandelwal
fc4351d211019a63c73f03771833dce19c9061a0 Diff: https://reviews.apache.org/r/46929/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 46929: HIVE-13676: Tests failing because metastore doesn't come up

2016-05-09 Thread Rajat Khandelwal
/apache/hadoop/hive/ql/metadata/TestHiveRemote.java ee95e160c858a93c43f96775b360f28f8d6a178f Diff: https://reviews.apache.org/r/46929/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 46929: HIVE-13676: Tests failing because metastore doesn't come up

2016-05-09 Thread Rajat Khandelwal
/apache/hadoop/hive/ql/metadata/TestHiveRemote.java ee95e160c858a93c43f96775b360f28f8d6a178f Diff: https://reviews.apache.org/r/46929/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 46929: HIVE-13676: Tests failing because metastore doesn't come up

2016-05-09 Thread Rajat Khandelwal
toreUtils::startMetaStore() I wonder why it isn't already used in these places. - Rajat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46929/#review131518 -----

[jira] [Created] (HIVE-13686) TestRecordReaderImpl is deleting target/tmp causing all the tests after it to fail

2016-05-04 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created HIVE-13686: --- Summary: TestRecordReaderImpl is deleting target/tmp causing all the tests after it to fail Key: HIVE-13686 URL: https://issues.apache.org/jira/browse/HIVE-13686

Review Request 46929: HIVE-13676: Tests failing because metastore doesn't come up

2016-05-03 Thread Rajat Khandelwal
--- Thanks, Rajat Khandelwal

[jira] [Created] (HIVE-13676) Tests failing because metastore doesn't come up

2016-05-03 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created HIVE-13676: --- Summary: Tests failing because metastore doesn't come up Key: HIVE-13676 URL: https://issues.apache.org/jira/browse/HIVE-13676 Project: Hive Issue

Re: Review Request 45733: HIVE-13421: Propagate job progress in operation status

2016-04-29 Thread Rajat Khandelwal
--- Thanks, Rajat Khandelwal

Re: Review Request 45733: HIVE-13421: Propagate job progress in operation status

2016-04-28 Thread Rajat Khandelwal
--- Thanks, Rajat Khandelwal

Re: Review Request 45733: HIVE-13421: Propagate job progress in operation status

2016-04-27 Thread Rajat Khandelwal
--- Thanks, Rajat Khandelwal

[jira] [Created] (HIVE-13605) TestDbTxnManager failing intermittently

2016-04-25 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created HIVE-13605: --- Summary: TestDbTxnManager failing intermittently Key: HIVE-13605 URL: https://issues.apache.org/jira/browse/HIVE-13605 Project: Hive Issue Type: Bug

Re: Review Request 45733: HIVE-13421: Propagate job progress in operation status

2016-04-25 Thread Rajat Khandelwal
--- Thanks, Rajat Khandelwal

Re: Review Request 45733: HIVE-13421: Propagate job progress in operation status

2016-04-19 Thread Rajat Khandelwal
Was a task removed from the display? > > Rajat Khandelwal wrote: > No, but there is some change in when the tasks are updated in the query > display. Each task updates the task display whenever there's a status change. > The query display needs to be registered with the task. E

Re: Review Request 45733: HIVE-13421: Propagate job progress in operation status

2016-04-19 Thread Rajat Khandelwal
--- Thanks, Rajat Khandelwal

Re: Review Request 45733: HIVE-13421: Propagate job progress in operation status

2016-04-17 Thread Rajat Khandelwal
--- Thanks, Rajat Khandelwal

Re: Review Request 45733: HIVE-13421: Propagate job progress in operation status

2016-04-17 Thread Rajat Khandelwal
tasks are left out, which is fine. Secondly, this was already 1 before my last change. Now it's again 1, so shouldn't be an issue. On April 14, 2016, 7:26 a.m., Rajat Khandelwal wrote: > > Looks good mostly. Just some questions and a nit below. > > > > Also it does

[jira] [Created] (HIVE-13500) Launching big queries fails with Out of Memory Exception

2016-04-13 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created HIVE-13500: --- Summary: Launching big queries fails with Out of Memory Exception Key: HIVE-13500 URL: https://issues.apache.org/jira/browse/HIVE-13500 Project: Hive

Re: Review Request 45738: HIVE-13415: Decouple Sessions from thrift binary transport

2016-04-13 Thread Rajat Khandelwal
If client transport is closed, how are you able to do closeSession? > > Shouldnt you create a new client? > > Rajat Khandelwal wrote: > Sessions are not tied to tranport now. And looking at the code, > `client.closeSession` isn't using transport, it's delegating the cal

Re: Review Request 45738: HIVE-13415: Decouple Sessions from thrift binary transport

2016-04-13 Thread Rajat Khandelwal
/TestRetryingThriftCLIServiceClient.java 3bd82e614a50c0b5419a926ff00a95dafd4b0ebb Diff: https://reviews.apache.org/r/45738/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 45738: HIVE-13415: Decouple Sessions from thrift binary transport

2016-04-12 Thread Rajat Khandelwal
generated e-mail. To reply, visit: https://reviews.apache.org/r/45738/#review128072 ------- On April 11, 2016, 11:59 a.m., Rajat Khandelwal wrote: > > --- > Thi

Re: Review Request 45738: HIVE-13415: Decouple Sessions from thrift binary transport

2016-04-11 Thread Rajat Khandelwal
/java/org/apache/hadoop/hive/shims/HadoopShims.java a44d0c0a64238574fb9ea349e45974c3d6010219 Diff: https://reviews.apache.org/r/45738/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 45733: HIVE-13421: Propagate job progress in operation status

2016-04-06 Thread Rajat Khandelwal
--- Thanks, Rajat Khandelwal

Re: Review Request 45738: HIVE-13415: Decouple Sessions from thrift binary transport

2016-04-06 Thread Rajat Khandelwal
/TestRetryingThriftCLIServiceClient.java 3bd82e614a50c0b5419a926ff00a95dafd4b0ebb Diff: https://reviews.apache.org/r/45738/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 45738: HIVE-13415: Decouple Sessions from thrift binary transport

2016-04-06 Thread Rajat Khandelwal
/TestRetryingThriftCLIServiceClient.java 3bd82e614a50c0b5419a926ff00a95dafd4b0ebb Diff: https://reviews.apache.org/r/45738/diff/ Testing --- Thanks, Rajat Khandelwal

Review Request 45738: HIVE-13415: Decouple Sessions from thrift binary transport

2016-04-05 Thread Rajat Khandelwal
/cli/thrift/ThriftCLIService.java 0a2a761867ab596e942dbc78eaabc0ef920665a3 service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java 3bd82e614a50c0b5419a926ff00a95dafd4b0ebb Diff: https://reviews.apache.org/r/45738/diff/ Testing --- Thanks, Rajat Khandelwal

Review Request 45733: HIVE-13421: Propagate job progress in operation status

2016-04-05 Thread Rajat Khandelwal
/exec/mr/HadoopJobExecHelper.java 1b296b9986907d983a754f9957f2cbe4f7583ae5 service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 698b13d66f100618aab3c3ee2cbf3c3df8477afe Diff: https://reviews.apache.org/r/45733/diff/ Testing --- Thanks, Rajat Khandelwal

[jira] [Created] (HIVE-13421) Propagate job progress in operation status

2016-04-05 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created HIVE-13421: --- Summary: Propagate job progress in operation status Key: HIVE-13421 URL: https://issues.apache.org/jira/browse/HIVE-13421 Project: Hive Issue Type

Re: Review Request 44783: HIVE-13183: More logs in operation logs

2016-04-04 Thread Rajat Khandelwal
/clientpositive/tez/tez_join_hash.q.out 8d0aba19d63a51c3d21f356078b74363ce8fc967 Diff: https://reviews.apache.org/r/44783/diff/ Testing --- Thanks, Rajat Khandelwal

[jira] [Created] (HIVE-13415) Decouple Sessions from thrift binary transport

2016-04-04 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created HIVE-13415: --- Summary: Decouple Sessions from thrift binary transport Key: HIVE-13415 URL: https://issues.apache.org/jira/browse/HIVE-13415 Project: Hive Issue Type

Re: Review Request 45032: HIVE-13319: HIVE-4570/HIVE-13319: Propagate external handle in task display

2016-03-20 Thread Rajat Khandelwal
/cli/CLIServiceTest.java e145eb434159d43b90480bad6711f965a82072c5 Diff: https://reviews.apache.org/r/45032/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 45032: HIVE-4570/HIVE-13319: Propagate external handle in task display

2016-03-20 Thread Rajat Khandelwal
e145eb434159d43b90480bad6711f965a82072c5 Diff: https://reviews.apache.org/r/45032/diff/ Testing --- Thanks, Rajat Khandelwal

[jira] [Created] (HIVE-13319) Propagate external handles in task display

2016-03-20 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created HIVE-13319: --- Summary: Propagate external handles in task display Key: HIVE-13319 URL: https://issues.apache.org/jira/browse/HIVE-13319 Project: Hive Issue Type

Review Request 45032: HIVE-4570: More information to user on GetOperationStatus in Hive Server2 when query is still executing

2016-03-19 Thread Rajat Khandelwal
/java/org/apache/hadoop/hive/ql/QueryDisplay.java 467dab66e454d895742e96d4ac5db452fea00551 service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e145eb434159d43b90480bad6711f965a82072c5 Diff: https://reviews.apache.org/r/45032/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 44783: HIVE-13183: More logs in operation logs

2016-03-19 Thread Rajat Khandelwal
/session/OperationLog.java 2ecdde9799683cd104323af170d8905fb3005b9e Diff: https://reviews.apache.org/r/44783/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 44783: HIVE-13183: More logs in operation logs

2016-03-16 Thread Rajat Khandelwal
-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java be5e67ba23122bb5cddbd34217cc8abdf1bfa2cc Diff: https://reviews.apache.org/r/44783/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 44783: HIVE-13183: More logs in operation logs

2016-03-15 Thread Rajat Khandelwal
/session/OperationLog.java 2ecdde9799683cd104323af170d8905fb3005b9e Diff: https://reviews.apache.org/r/44783/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 44783: HIVE-13183: More logs in operation logs

2016-03-14 Thread Rajat Khandelwal
/diff/ Testing --- Thanks, Rajat Khandelwal

Review Request 44783: HIVE-13183: More logs in operation logs

2016-03-14 Thread Rajat Khandelwal
://reviews.apache.org/r/44783/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 44453: HIVE-4570: More information to user on GetOperationStatus in Hive Server2 when query is still executing

2016-03-12 Thread Rajat Khandelwal
/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171 Diff: https://reviews.apache.org/r/44453/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 44453: HIVE-4570: More information to user on GetOperationStatus in Hive Server2 when query is still executing

2016-03-10 Thread Rajat Khandelwal
/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171 Diff: https://reviews.apache.org/r/44453/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 44453: HIVE-4570: More information to user on GetOperationStatus in Hive Server2 when query is still executing

2016-03-10 Thread Rajat Khandelwal
/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171 Diff: https://reviews.apache.org/r/44453/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 44453: HIVE-4570: More information to user on GetOperationStatus in Hive Server2 when query is still executing

2016-03-09 Thread Rajat Khandelwal
----- On March 10, 2016, 1:25 p.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44453/ >

Re: Review Request 44453: HIVE-4570: More information to user on GetOperationStatus in Hive Server2 when query is still executing

2016-03-09 Thread Rajat Khandelwal
/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171 Diff: https://reviews.apache.org/r/44453/diff/ Testing --- Thanks, Rajat Khandelwal

Review Request 44608: HIVE-4570: More information to user on GetOperationStatus in Hive Server2 when query is still executing

2016-03-09 Thread Rajat Khandelwal
5f01165d0dfd131a2599b90a8e1c4d4970650b7a service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171 Diff: https://reviews.apache.org/r/44608/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 44453: HIVE-4570: More information to user on GetOperationStatus in Hive Server2 when query is still executing

2016-03-09 Thread Rajat Khandelwal
e worth considering, as I still believe > > the logic is similar and the problems (the two I mentioned above) are the > > same. Thanks. > > Rajat Khandelwal wrote: > I'm working on the TaskDisplay idea, but there will *not* be a period of > time when you stop se

Re: Review Request 44453: HIVE-4570: More information to user on GetOperationStatus in Hive Server2 when query is still executing

2016-03-09 Thread Rajat Khandelwal
e78181a15993d99f1cab5a061c08bb21823d2171 Diff: https://reviews.apache.org/r/44453/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 44453: HIVE-4570: More information to user on GetOperationStatus in Hive Server2 when query is still executing

2016-03-09 Thread Rajat Khandelwal
the root tasks in the driver. So when plan is nulified, root tasks are picked from the plan and cached with the driver. - Rajat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44453/#review122382 --

Re: Review Request 44524: HIVE-11484 : Fix ObjectInspector for Char and VarChar

2016-03-09 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44524/#review122697 --- Ship it! Ship It! - Rajat Khandelwal On March 9, 2016, 12

Re: Review Request 44453: HIVE-4570: More information to user on GetOperationStatus in Hive Server2 when query is still executing

2016-03-07 Thread Rajat Khandelwal
java generated class now. - Rajat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44453/#review122476 --- On March 8, 2016, 1:03 p.m., R

Re: Review Request 44453: HIVE-4570: More information to user on GetOperationStatus in Hive Server2 when query is still executing

2016-03-07 Thread Rajat Khandelwal
--------- On March 8, 2016, 1:03 p.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44453/ >

Re: Review Request 44453: HIVE-4570: More information to user on GetOperationStatus in Hive Server2 when query is still executing

2016-03-07 Thread Rajat Khandelwal
/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171 Diff: https://reviews.apache.org/r/44453/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 42134: More information to user on GetOperationStatus in Hive Server2 when query is still executing

2016-03-07 Thread Rajat Khandelwal
> On March 3, 2016, 6:20 a.m., Szehon Ho wrote: > > This requirement is very similar to webui's display of operations, can you > > look at QueryDisplay and see if it can be enhanced and combined (rather > > than repeating all this container classes). That class also gives you > > concurrency

Review Request 44453: HIVE-4570: More information to user on GetOperationStatus in Hive Server2 when query is still executing

2016-03-07 Thread Rajat Khandelwal
e78181a15993d99f1cab5a061c08bb21823d2171 Diff: https://reviews.apache.org/r/44453/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 44172: HIVE-11483: Add encoding and decoding for query string config

2016-03-06 Thread Rajat Khandelwal
/TestHooks.java 8d27762522f0ac5f59696e019ec52a25e77318db Diff: https://reviews.apache.org/r/44172/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 44146: HIVE-13179: Allow custom HiveConf to be passed to Authentication Providers

2016-03-03 Thread Rajat Khandelwal
/TestLdapAtnProviderWithMiniDS.java e5cee37ac72001086323c94392274fb86f4307ef service/src/test/org/apache/hive/service/auth/TestLdapAuthenticationProviderImpl.java 5e91a0eb8a1bfc8a8d6e6774b195de9731035bdd Diff: https://reviews.apache.org/r/44146/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 44172: HIVE-11483: Add encoding and decoding for query string config

2016-03-03 Thread Rajat Khandelwal
red any more? Removed. - Rajat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44172/#review121807 --- On March 3, 2016,

Re: Review Request 44172: HIVE-11483: Add encoding and decoding for query string config

2016-03-03 Thread Rajat Khandelwal
/TestHooks.java 8d27762522f0ac5f59696e019ec52a25e77318db Diff: https://reviews.apache.org/r/44172/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 44201: HIVE-13188: Allow users of RetryingThriftClient to close transport

2016-03-02 Thread Rajat Khandelwal
Can you update test to call new method introduced? > > Rajat Khandelwal wrote: > Updated. Test is also passing > > Amareshwari Sriramadasu wrote: > Can you update by calling close Transport() as well ? Added. But I can't assert whether the transport is closed after

Re: Review Request 44201: HIVE-13188: Allow users of RetryingThriftClient to close transport

2016-03-02 Thread Rajat Khandelwal
/RetryingThriftCLIServiceClient.java a81c600236e6e0f53a484806e559303279244616 service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java 3798053a4a2e2b26b97b5accf96d73b58c89fb6e Diff: https://reviews.apache.org/r/44201/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 44201: HIVE-13188: Allow users of RetryingThriftClient to close transport

2016-03-01 Thread Rajat Khandelwal
/RetryingThriftCLIServiceClient.java a81c600236e6e0f53a484806e559303279244616 service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java 3798053a4a2e2b26b97b5accf96d73b58c89fb6e Diff: https://reviews.apache.org/r/44201/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 44201: HIVE-13188: Allow users of RetryingThriftClient to close transport

2016-03-01 Thread Rajat Khandelwal
-- On March 1, 2016, 12:48 p.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44201/ > -

Re: Review Request 44172: HIVE-11483: Add encoding and decoding for query string config

2016-03-01 Thread Rajat Khandelwal
/java/org/apache/hadoop/hive/conf/HiveConf.java 2723dadd76418f23b6e6358d21304e3312ef1cbd common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java 365d5005d2a1f240b12bb4e9f9a920b3db4d32ba Diff: https://reviews.apache.org/r/44172/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 44172: HIVE-11483: Add encoding and decoding for query string config

2016-03-01 Thread Rajat Khandelwal
ls, but add one more method that takes a factory instance . - Rajat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44172/#review121409 ------- On March 1, 2016, 1:09 p.m., Rajat Khandelwal wrote: > > ---

Re: Review Request 44172: HIVE-11483: Add encoding and decoding for query string config

2016-02-29 Thread Rajat Khandelwal
/org/apache/hadoop/hive/conf/HiveConf.java 2723dadd76418f23b6e6358d21304e3312ef1cbd common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java 365d5005d2a1f240b12bb4e9f9a920b3db4d32ba Diff: https://reviews.apache.org/r/44172/diff/ Testing --- Thanks, Rajat Khandelwal

Review Request 44201: HIVE-13188: Allow users of RetryingThriftClient to close transport

2016-02-29 Thread Rajat Khandelwal
a81c600236e6e0f53a484806e559303279244616 service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java 3798053a4a2e2b26b97b5accf96d73b58c89fb6e Diff: https://reviews.apache.org/r/44201/diff/ Testing --- Thanks, Rajat Khandelwal

[jira] [Created] (HIVE-13188) Allow users of RetryingThriftClient to close transport

2016-02-29 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created HIVE-13188: --- Summary: Allow users of RetryingThriftClient to close transport Key: HIVE-13188 URL: https://issues.apache.org/jira/browse/HIVE-13188 Project: Hive

[jira] [Created] (HIVE-13183) Redirect exceptions in TaskRunner to operation error stream

2016-02-29 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created HIVE-13183: --- Summary: Redirect exceptions in TaskRunner to operation error stream Key: HIVE-13183 URL: https://issues.apache.org/jira/browse/HIVE-13183 Project: Hive

Review Request 44172: HIVE-11483: Add encoding and decoding for query string config

2016-02-29 Thread Rajat Khandelwal
2723dadd76418f23b6e6358d21304e3312ef1cbd common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java 365d5005d2a1f240b12bb4e9f9a920b3db4d32ba Diff: https://reviews.apache.org/r/44172/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 44146: HIVE-13179: Allow custom HiveConf to be passed to Authentication Providers

2016-02-29 Thread Rajat Khandelwal
: https://reviews.apache.org/r/44146/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 44146: HIVE-13179: Allow custom HiveConf to be passed to Authentication Providers

2016-02-28 Thread Rajat Khandelwal
: https://reviews.apache.org/r/44146/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 44146: HIVE-13179: Allow custom HiveConf to be passed to Authentication Providers

2016-02-28 Thread Rajat Khandelwal
: https://reviews.apache.org/r/44146/diff/ Testing --- Thanks, Rajat Khandelwal

Review Request 44146: HIVE-13179: Allow custom HiveConf to be passed to Authentication Providers

2016-02-28 Thread Rajat Khandelwal
: https://reviews.apache.org/r/44146/diff/ Testing --- Thanks, Rajat Khandelwal

[jira] [Created] (HIVE-13179) Allow custom HiveConf to be passed to Authentication Providers

2016-02-28 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created HIVE-13179: --- Summary: Allow custom HiveConf to be passed to Authentication Providers Key: HIVE-13179 URL: https://issues.apache.org/jira/browse/HIVE-13179 Project: Hive

Re: Review Request 43597: HIVE-13064: Serde properties are not working while expecting output in a directory

2016-02-19 Thread Rajat Khandelwal
/hive/ql/plan/PlanUtils.java 04d26f3 ql/src/test/queries/clientpositive/insert_overwrite_directory.q c3d419b ql/src/test/results/clientpositive/insert_overwrite_directory.q.out e5d2455 Diff: https://reviews.apache.org/r/43597/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 43597: HIVE-13064: Serde properties are not working while expecting output in a directory

2016-02-18 Thread Rajat Khandelwal
://reviews.apache.org/r/43597/diff/ Testing --- Thanks, Rajat Khandelwal

Review Request 43597: HIVE-13064: Serde properties are not working while expecting output in a directory

2016-02-16 Thread Rajat Khandelwal
/test/results/clientpositive/insert_overwrite_directory.q.out e5d2455 Diff: https://reviews.apache.org/r/43597/diff/ Testing --- Thanks, Rajat Khandelwal

[jira] [Created] (HIVE-13064) Serde properties are not working while expecting output in a directory

2016-02-16 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created HIVE-13064: --- Summary: Serde properties are not working while expecting output in a directory Key: HIVE-13064 URL: https://issues.apache.org/jira/browse/HIVE-13064 Project

[jira] [Created] (HIVE-12972) Hive Expression parsing is significantly slow for pre-fix expression than post-fix expressions

2016-02-01 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created HIVE-12972: --- Summary: Hive Expression parsing is significantly slow for pre-fix expression than post-fix expressions Key: HIVE-12972 URL: https://issues.apache.org/jira/browse/HIVE

  1   2   >