Re: Review Request 69642: HIVE-20977: Lazy evaluate the table object in PreReadTableEvent to improve get_partition performance

code more readable. - Sergio Pena On Jan. 3, 2019, 1:40 a.m., Karthik Manamcheri wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

eed it? standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Lines 3016-3017 (original), 3059-3062 (patched) <https://reviews.apache.org/r/69585/#comment296631> Same question, why splitting the lines where if this patch doesn't need it?

Re: Review Request 67186: HIVE-19585: Add UNKNOWN to PrincipalType

havior to all the authorization commands like: ALTER TABLE ... SET OWNER UNKNOWN Do we want to support that? Do we need the UNKNOWN on the PrincipalType? - Sergio Pena On May 17, 2018, 3:19 p.m., Arjun Mishra

Re: [VOTE] Stricter commit guidelines

+1 On Tue, May 15, 2018 at 11:05 AM, Gunther Hagleitner < ghagleit...@hortonworks.com> wrote: > +1 > > From: Sankar Hariappan > Sent: Tuesday, May 15, 2018 9:03 AM > To: dev@hive.apache.org > Subject: Re: [VOTE] Stricter

Review Request 67121: HIVE-19527: Preparing for 2.4 development

e3bdb47c9eb730233434b9b9ca8282888b09ef04 testutils/pom.xml 0ab295a59c04dfc6c384956f6d92a5096cc696cd vector-code-gen/pom.xml 81fcdb89321669f922eb8d6cb3b04821671c80b1 Diff: https://reviews.apache.org/r/67121/diff/1/ Testing --- Thanks, Sergio Pena

Re: Review Request 66979: HIVE-19374: Parse and process ALTER TABLE SET OWNER command syntax

rifies that the new command works. Describe is not tested because the .q tests files mask the owner information. - the describe command verified manually in my local hive environment Thanks, Sergio Pena

Review Request 66979: HIVE-19374: Parse and process ALTER TABLE SET OWNER command syntax

HiveQA - alter_table_set_owner.q which verifies that the new command works. Describe is not tested because the .q tests files mask the owner information. - the describe command verified manually in my local hive environment Thanks, Sergio Pena

Re: Review Request 66890: HIVE-19371: Add table ownerType to HMS thrift API

/r/66909/ (needs review too) - Sergio --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66890/#review202291 ------- On Ma

Review Request 66909: HIVE-19372: Add table ownerType to JDO/SQL and ObjectStore

Diff: https://reviews.apache.org/r/66909/diff/1/ Testing --- Waiting for Hive QA Thanks, Sergio Pena

Review Request 66890: HIVE-19371: Add table ownerType to HMS thrift API

/hive_metastore.thrift ccc3c93bcec88b96e524eeb6d47b7c77ccf49d34 Diff: https://reviews.apache.org/r/66890/diff/1/ Testing --- Waiting for Hive QA. Thanks, Sergio Pena

Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

; > > why do we need !success check here? > > Sergio Pena wrote: > Ah? Thanks, I missed this. I removed the first condition and leave this > one instead. > > Vihang Karajgaonkar wrote: > I thought we need the first condition and not the second condition

Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

/metastore/IHMSHandler.java f59f40bc33367cff7a8d0d24d0e200b16c2c30e5 Diff: https://reviews.apache.org/r/65985/diff/3/ Changes: https://reviews.apache.org/r/65985/diff/2-3/ Testing --- All tests passed. Thanks, Sergio Pena

Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

eviews.apache.org/r/65985/#review200405 --- On March 15, 2018, 5:45 p.m., Sergio Pena wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

/hive/metastore/IHMSHandler.java e6de0013bc1be12b2772e2e97102ed476cf5 Diff: https://reviews.apache.org/r/65985/diff/2/ Changes: https://reviews.apache.org/r/65985/diff/1-2/ Testing --- All tests passed. Thanks, Sergio Pena

Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

other variables for each transaction response. - Sergio --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65985/#review199027 -------

Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

L operations are inside the HiveMetaStore and only the alter is in its own class. Could this also be considered in the HMS v2 design? - Sergio ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

e6de0013bc1be12b2772e2e97102ed476cf5 Diff: https://reviews.apache.org/r/65985/diff/1/ Testing --- All tests passed. Thanks, Sergio Pena

Re: [VOTE] Apache Hive 2.3.2 Release Candidate 0

+1 I verified the release by doing the following: * checked the gpg signature * checked the md5 files * installed hive 2.3.2 in my local machine with hadoop 2.7.2 and run a few commands: > show databases > show tables > insert into table values() > select * from table > select count(*)

Re: [Announce] New committer: Tao Li

Congratulations Tao !!! On Wed, Nov 1, 2017 at 2:13 PM, Peter Vary wrote: > Congratulations Tao! :) > > > On Nov 1, 2017, at 6:49 PM, Ashutosh Chauhan > wrote: > > > > The Project Management Committee (PMC) for Apache Hive has invited Tao > Li to > >

Re: Review Request 62816: HIVE-17729 Add Database & Explain related blobstore tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62816/#review189798 --- Ship it! Ship It! - Sergio Pena On Oct. 6, 2017, 7:13 p.m

Re: [VOTE] Apache Hive 2.3.1 Release Candidate 0

Great, thanks Jesus. On Tue, Oct 24, 2017 at 5:00 PM, Jesus Camacho Rodriguez < jcama...@apache.org> wrote: > Sergio, > > branch-2.3 is open for commits again. > > Thanks, > Jesús > > > > On 10/24/17, 10:56 AM, "Jesus Camacho Rodriguez" hortonworks.com on behalf of

Re: [VOTE] Apache Hive 2.3.1 Release Candidate 0

Jesus, the vote expired. I wonder if we're allowed to commit HIVE-17831 into the branch 2.3 so it is available in this release? On Tue, Oct 24, 2017 at 10:40 AM, Ashutosh Chauhan wrote: > - Built from sources. > - Ran few unit tests. > - Checked md5sum. > > Everything

Re: [VOTE] Apache Hive 2.3.1 Release Candidate 0

Great, thanks Jesus for preparing this. Just one request, can we include HIVE-17831 in the 2.3.1 release? Sentry has been waiting to bump the Hive version to 2.x for a while, and HIVE-17831 fixes an issue that is required to make it work. It's a small fix and is already part of 3.0 and 2.4. -

Re: Review Request 62736: HIVE-17544: Provide classname info for function authorization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62736/#review187000 --- Ship it! Ship It! - Sergio Pena On Oct. 2, 2017, 9:10 p.m

Re: New committer : Barna Zsombor Klara

Great, congratulations Zsombor !!! On Mon, Sep 18, 2017 at 12:44 PM, Sahil Takiar wrote: > Congrats Zsombor! > > On Mon, Sep 18, 2017 at 9:50 AM, Vihang Karajgaonkar > wrote: > > > Congratulations Zsombor! > > > > On Mon, Sep 18, 2017 at 8:15 AM,

Re: Review Request 60085: HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60085/#review183136 --- Ship it! Ship It! - Sergio Pena On Aug. 17, 2017, 7:56 a.m

Re: Review Request 60085: HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client

parameters and another place as an environment variable). Could you give an example? - Sergio Pena On Aug. 8, 2017, 12:50 p.m., Barna Zsombor Klara wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 60085: HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client

code? I see we initialize a couple of classes with a specific context that may have a server environment file context, but how are we getting Java info from such context? - Sergio Pena On July 31, 2017, 8:05 a.m., Barna Zsombor Klara wrote

Re: Review Request 60085: HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client

/ptest/execution/conf/Context.java Lines 266 (patched) <https://reviews.apache.org/r/60085/#comment258170> Can you add javadoc to all the new public methods and ContextBuilder? - Sergio Pena On July 31, 2017, 8:05 a.m., Barna Zsombor

Re: Review Request 60006: HIVE-14746: Remove branch and repositories from profiles by sending them from ptest-client

> On June 14, 2017, 4:03 p.m., Sergio Pena wrote: > > testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java > > Lines 108 (patched) > > <https://reviews.apache.org/r/60006/diff/2/?file=1749730#file1749730line108> > > > >

Re: Review Request 61041: HIVE-17150: CREATE INDEX execute HMS out-of-transaction listener calls inside a transaction

/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 94cbd5235dce0b49b92203ff92d0d2e29e8b2ca9 Diff: https://reviews.apache.org/r/61041/diff/2/ Changes: https://reviews.apache.org/r/61041/diff/1-2/ Testing --- Thanks, Sergio Pena

Review Request 61041: HIVE-17150: CREATE INDEX execute HMS out-of-transaction listener calls inside a transaction

bd33c7101f5bc01a482153f810b65b620a061636 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 94cbd5235dce0b49b92203ff92d0d2e29e8b2ca9 Diff: https://reviews.apache.org/r/61041/diff/1/ Testing --- Thanks, Sergio Pena

Re: [VOTE] Apache Hive 2.3.0 Release Candidate 1

What happened with the 2.2.0 release? is it confusing to jump from 2.1 -> 2.3 without having a 2.2 release previously? On Fri, Jul 14, 2017 at 2:02 AM, Pengcheng Xiong wrote: > Apache Hive 2.3.0 Release Candidate 1 is available here: > > Artifacts: > tag:

Re: Review Request 59020: Support Parquet through HCatalog

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59020/#review180306 --- Ship it! Ship It! - Sergio Pena On July 12, 2017, 2:57 p.m

Re: Review Request 59020: Support Parquet through HCatalog

ment255312> Same thing with the short words on method names. However, makes more sense to use getParquetProperties(), what do you think? Table properties are set through the Table, but jobConf can bring other parquet properties that were set in hive-site.xml, right? - Sergio Pena O

Re: [Announce] New committer: Deepesh Khandelwal

Congratulations Deepesh !!! On Wed, Jul 5, 2017 at 7:48 PM, Ashutosh Chauhan wrote: > The Project Management Committee (PMC) for Apache Hive has invited Deepesh > Khandelwal to become a committer and we are pleased to announce that he has > accepted. > > Welcome, Deepesh!

Re: [Announce] New committer: Sahil Takiar

Congratulations Sahil !!! On Wed, Jul 5, 2017 at 7:49 PM, Ashutosh Chauhan wrote: > The Project Management Committee (PMC) for Apache Hive has invited Sahil > Takiar to become a committer and we are pleased to announce that he has > accepted. > > Welcome, Sahil! > >

Re: [Announce] New committer: Vihang Karajgaonkar

Congratulations Vihang !!!. - Sergio On Fri, Jul 7, 2017 at 12:50 PM, Vaibhav Gumashta wrote: > Congratulations Vihang! > > On 7/7/17, 10:47 AM, "Vineet Garg" wrote: > > >Congratulations Vihang! > > > >> On Jul 5, 2017, at 5:51 PM, Ashutosh

Re: [Announce] New committer: Peter Vary

Congrats Peter !! On Fri, Jul 7, 2017 at 12:51 PM, Vaibhav Gumashta wrote: > Congratulations Peter! > > On 7/7/17, 10:46 AM, "Vineet Garg" wrote: > > >Congrats Peter! > > > >> On Jul 7, 2017, at 9:27 AM, Xuefu Zhang wrote: >

Re: [ANNOUNCE] New PMC Member : Matt McCline

Congrats Matt !! On Fri, Jul 7, 2017 at 12:51 PM, Vaibhav Gumashta wrote: > Congratulations Matt! > > On 7/7/17, 10:46 AM, "Vineet Garg" wrote: > > >Congrats Matt! > >> On Jul 7, 2017, at 9:57 AM, Vihang Karajgaonkar >

Re: [Announce] New committer: Teddy Choi

Congratulations Teddy! On Fri, Jul 7, 2017 at 12:51 PM, Vaibhav Gumashta wrote: > Congratulations Teddy! > > On 7/7/17, 10:46 AM, "Vineet Garg" wrote: > > >Congratulations! > > > >> On Jul 7, 2017, at 10:25 AM, Gunther Hagleitner >

Re: Review Request 60445: HIVE-16935: Hive should strip comments from input before choosing which CommandProcessor to run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60445/#review179821 --- Ship it! Great, this looks very good. - Sergio Pena On July

Re: [DISCUSS] Separating out the metastore as its own TLP

attract new projects that> > > > might otherwise feel the need to solve their metadata problems on > their own.> > > > > > > > Any Hive PMC member or committer will be welcome to join the new > project at> > > > the same level. We propose this pr

Re: Review Request 59446: HIVE-16559: Parquet schema evolution for partitioned tables may break if table and partition serdes differ

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59446/#review178921 --- Ship it! Ship It! - Sergio Pena On June 26, 2017, 11:48 a.m

Re: Review Request 59446: HIVE-16559: Parquet schema evolution for partitioned tables may break if table and partition serdes differ

ent252831> Should we use CASCADE in capital case for better info that it is a keyword? - Sergio Pena On June 19, 2017, 9:52 a.m., Barna Zsombor Klara wrote: > > --- > This is an automatically generated e-mail. To

Re: Hadoop3 + hbase2 support in Hive

Aihua, There are a few of JIRAs related to the Hadoop3 support: https://issues.apache.org/jira/browse/HIVE-16531 (This is the Umbrella for Hadoop 3.x support) https://issues.apache.org/jira/browse/HIVE-15016 https://issues.apache.org/jira/browse/HIVE-15427 I started the work on HIVE-15016 some

Re: Review Request 60006: HIVE-14746: Remove branch and repositories from profiles by sending them from ptest-client

gt; Why is a workingDirectoryWrapper needed? Currently, Ptest works on a 'working' directory for any branch detected on the profile. Why do we want to change that for different branches? - Sergio Pena On June 13, 2017, 2:28 p.m., Barna Zsombor

Re: Review Request 59654: HIVE-16771 : Schematool should use MetastoreSchemaInfo to get the metastore schema version from database

refactoring to make it better, but it is more work to do. Let's ship this for now. - Sergio Pena On May 30, 2017, 9:43 p.m., Vihang Karajgaonkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: CVE-2016-3083: Apache Hive SSL vulnerability bug disclosure

Hi Vaibhav, Do you happen to know which JIRA or patches addressed this issue? - Sergio On Wed, May 24, 2017 at 5:56 PM, Vaibhav Gumashta wrote: > Severity: Important > > Vendor: The Apache Software Foundation > > Versions Affected: > Apache Hive 0.13.x > Apache

Re: [Announce] New PMC members

Thanks all for your comments, and congratulations to all new PMC members too !!! - Sergio On Sun, May 28, 2017 at 8:43 PM, Rajesh Balamohan wrote: > Congratulations to new PMC members! > > ~Rajesh.B > > On Sat, May 27, 2017 at 12:14 PM, Zoltan Haindrich < >

Re: Jimmy Xiang now a Hive PMC member

Congratulations Jimmy !!! On Thu, May 25, 2017 at 2:30 AM, Peter Vary wrote: > Congratulations Jimmy! > > > On May 25, 2017, at 6:16 AM, Xuefu Zhang wrote: > > > > Hi all, > > > > It's an honer to announce that Apache Hive PMC has recently voted to >

Re: Welcome Rui Li to Hive PMC

Congratulations Rui !!! On Thu, May 25, 2017 at 4:44 AM, Rui Li wrote: > Thank you guys :) > > On Thu, May 25, 2017 at 3:29 PM, Peter Vary wrote: > > > Congratulations Rui! > > > > > On May 25, 2017, at 6:19 AM, Xuefu Zhang wrote: >

Re: [Announce] New committer: Vineet Garg

Congratulations Vinnet !! On Tue, May 9, 2017 at 3:42 PM, Wei Zheng wrote: > Congrats! > > Thanks, > Wei > > On 5/9/17, 13:36, "Gunther Hagleitner" > wrote: > > Congrats Vineet! > > From:

Re: Review Request 58501: HIVE-16469: Parquet timestamp table property is not always taken into account

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58501/#review174184 --- Ship it! Ship It! - Sergio Pena On May 4, 2017, 10:19 a.m

Re: pre-commit jenkins issues

I restarted hiveptest and seems is working now. There was a hiccup on the server while using the libraries to create the slave nodes. On Fri, May 5, 2017 at 12:05 AM, Sushanth Sowmyan wrote: > Hi, > > It looks like the precommit queue is currently having issues : >

Re: [VOTE] Apache Hive 2.3.0 Release Candidate 0

Thanks Rui. Pengcheng, the patch is reverted, you may continue with the RC1. On Tue, May 2, 2017 at 11:02 PM, Rui Li <lirui.fu...@gmail.com> wrote: > The patch has been reverted in master and branch-2.3 > > On Wed, May 3, 2017 at 3:01 AM, Sergio Pena <sergio.p...@cloudera.com&

Re: [VOTE] Apache Hive 2.3.0 Release Candidate 0

Hi Pengcheng, There is a request from the HDFS team to revert the patch committed on HIVE-16047 from our code because it might cause problems when future Hadoop versions are released due to being a private API on Hadoop. This API method signature has been changed between releases, and we don't

Re: Review Request 58501: HIVE-16469: Parquet timestamp table property is not always taken into account

I think it makes more sense to use the above exception when arguments are not valid. ql/src/test/org/apache/hadoop/hive/ql/io/parquet/AbstractTestParquetDirect.java Line 24 (original), 24 (patched) <https://reviews.apache.org/r/58501/#comment246599> Keep the standard here. Let's imp

Re: ptest not running?

This seems a problem with the Jenkins slave resources. We'll need to wait until Jenkins reserves a executor for Hive. On Wed, Apr 26, 2017 at 3:18 PM, Vihang Karajgaonkar wrote: > Does anyone have access to https://builds.apache.org/job/PreCommit-Admin/ > job? It is

Re: Review Request 57353: Intern Properties objects referenced from PartitionDesc to reduce memory pressure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57353/#review172715 --- Ship it! Ship It! - Sergio Pena On April 21, 2017, 8:26 p.m

Re: Review Request 57353: Intern Properties objects referenced from PartitionDesc to reduce memory pressure.

> On April 21, 2017, 4:35 p.m., Sergio Pena wrote: > > Misha, whers is CopyOnFirstWriteProperties used? The patch looks pretty > > good, but I don't see where CopyOnFirstWriteProperties is instatiated. > > Misha Dmitriev wrote: > It's not instantiat

Re: ptest is taking 8h

Done. There was an issue with some permissions I changed yesterday on the hiveptest ssh key. The server is up and running now. On Fri, Apr 21, 2017 at 1:34 PM, Sergio Pena <sergio.p...@cloudera.com> wrote: > I'm taking a look at this now. There is something wrong on the server. > &

Re: ptest is taking 8h

I'm taking a look at this now. There is something wrong on the server. On Fri, Apr 21, 2017 at 10:27 AM, Vihang Karajgaonkar wrote: > Looks like PtestServer is not responding. > > org.apache.hive.ptest.api.client.PTestClient --command testStart > --outputDir >

Re: Review Request 57353: Intern Properties objects referenced from PartitionDesc to reduce memory pressure.

terner, why do we have to lock the INTERNER only when updating it? - Sergio Pena On March 7, 2017, 1:22 a.m., Misha Dmitriev wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 58516: HIVE-16213 : ObjectStore can leak Queries when rollbackTransaction throws an exception

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58516/#review172556 --- Ship it! It looks good. - Sergio Pena On April 18, 2017, 7

Re: [VOTE] Apache Hive 1.2.2 Release Candidate 0

+1 (no-binding) I unpacked the bin and src packages. Verified gpg and md5 signatures. Check license and release notes files. Run a few queries from hive-cli. - Sergio On Tue, Apr 4, 2017 at 11:12 AM, Ashutosh Chauhan wrote: > Verified md5 of src and binary tar balls. >

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

: https://reviews.apache.org/r/57626/diff/7/ Changes: https://reviews.apache.org/r/57626/diff/6-7/ Testing --- HiveQA showed only one test failure. it is fixed, and waiting for HiveQA to complete 100% tests. Thanks, Sergio Pena

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

> As I said, you can simply add a new method called > > getunmodifiableParameters() which returns > > Collections.unmodifiableMap(parameters) without the need for this copy. > > Sergio Pena wrote: > We want to avoid that an external listener gets a reference to the > mutabl

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

> As I said, you can simply add a new method called > > getunmodifiableParameters() which returns > > Collections.unmodifiableMap(parameters) without the need for this copy. > > Sergio Pena wrote: > We want to avoid that an external listener gets a reference to the > mutabl

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

is that you cannot override an existing key/value. Because we don't control the external listeners, we prefered to return an inmutable map whenever getParameters() was called. Does it make sense? - Sergio ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57626/#review170576 --

Re: Review Request 57805: HIVE-16049: upgrade to jetty 9

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57805/#review170400 --- Ship it! Ship It! - Sergio Pena On March 29, 2017, 2:15 p.m

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

/ Changes: https://reviews.apache.org/r/57626/diff/5-6/ Testing --- HiveQA showed only one test failure. it is fixed, and waiting for HiveQA to complete 100% tests. Thanks, Sergio Pena

Re: Review Request 57728: HIVE-16231: Parquet timestamp may be stored differently since HIVE-12767

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57728/#review170236 --- Ship it! Ship It! - Sergio Pena On March 27, 2017, 8 a.m

Re: Review Request 57805: HIVE-16049: upgrade to jetty 9

it unlimited before? - Sergio Pena On March 27, 2017, 4:31 p.m., Aihua Xu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

, and waiting for HiveQA to complete 100% tests. Thanks, Sergio Pena

Re: Review Request 57728: HIVE-16231: Parquet timestamp may be stored differently since HIVE-12767

- Sergio Pena On March 24, 2017, 9:56 a.m., Barna Zsombor Klara wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 57728: HIVE-16231: Parquet timestamp may be stored differently since HIVE-12767

77 (patched) <https://reviews.apache.org/r/57728/#comment242748> Empty line. - Sergio Pena On March 24, 2017, 9:56 a.m., Barna Zsombor Klara wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

ameters is null. I like that idea of just ignoring the null and not adding anything to the parameters. That's why I used the 'addParameters' name instead of 'setParameter' to giving a meaning. - Sergio --- This is

Re: Review Request 57728: HIVE-16231: Parquet timestamp may be stored differently since HIVE-12767

> On March 22, 2017, 6:27 p.m., Sergio Pena wrote: > > common/src/java/org/apache/hive/common/util/DateUtils.java > > Lines 84 (patched) > > <https://reviews.apache.org/r/57728/diff/2/?file=1670971#file1670971line84> > > > > Is there another class

Re: Alter table partition rename with location - moves partition back to hive warehouse

I don't think that behavior is correct. The rename should create the new partition name in the same location of the table. Could you create a JIRA for that? On Wed, Mar 22, 2017 at 10:24 AM, Ying Chen wrote: > cross posting from u...@hive.apache.org. (sorry for additional

Re: Review Request 57728: HIVE-16231: Parquet timestamp may be stored differently since HIVE-12767

84 (patched) <https://reviews.apache.org/r/57728/#comment242327> Is there another class where to put this method? I don't think DateUtils is the place where we should keep this. - Sergio Pena On March 21, 2017, 5:28 p.m., Barna Zsombor Klara

Re: Review Request 57805: HIVE-16049: upgrade to jetty 9

on Hive. Should we create another JIRA for this? I think this is an important change so that the community is aware of the JIRA instead of keeping it hide on the Jetty upgrade. - Sergio Pena On March 21, 2017, 1:15 p.m., Aihua Xu wrote

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

, and waiting for HiveQA to complete 100% tests. Thanks, Sergio Pena

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

method ,and accept at least 6 parameters like the above code. Sasha, Mohit, which option would you think is ideal? I can also go back to the original code, and keep the for() loops to walk through each listener. - Sergio -----

Re: Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

(patched) <https://reviews.apache.org/r/57503/#comment241669> Is this actually adding new partitios to the metastore? Those are already discovered above. I think this part is not testing the changes correctly. - Sergio Pena On March 16, 2017, 3:55 p.m., Barna Zsombor Klara

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

Diff: https://reviews.apache.org/r/57626/diff/3/ Changes: https://reviews.apache.org/r/57626/diff/2-3/ Testing --- HiveQA showed only one test failure. it is fixed, and waiting for HiveQA to complete 100% tests. Thanks, Sergio Pena

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

generated e-mail. To reply, visit: https://reviews.apache.org/r/57626/#review169238 ------- On March 16, 2017, 10:36 p.m., Sergio Pena wrote: > > --- > Thi

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

ava/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > bae39acafeb86d04ac8ec66098be125cd3cef3e0 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 07eca38190c1b05bb4a3977e9154423449828957 > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListenerNotifier.java > PRE-CREATION > > metastore/src/java/org/apache/hadoop/hive/metastore/events/ListenerEvent.java > 62aeb8cc343fc4aab72e76da890e36ac3a16b7bf > metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java > 1f87eeb18f6edf7351b3c8da6a6826c08656e48c > > > Diff: https://reviews.apache.org/r/57626/diff/2/ > > > Testing > --- > > HiveQA showed only one test failure. it is fixed, and waiting for HiveQA to > complete 100% tests. > > > Thanks, > > Sergio Pena > >

Re: HiveQA is unable to add lira comments

The bug was fixed some time ago on the server. The following steps to check if the bug is still there are passing: https://confluence.atlassian.com/kb/unable-to-connect-to-ssl-services-due-to-pkix-path-building-failed-779355358.html Anyway, I see there are a couple of package upgrades available

Re: Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

/TestObjectStore.java 1f87eeb18f6edf7351b3c8da6a6826c08656e48c Diff: https://reviews.apache.org/r/57626/diff/2/ Changes: https://reviews.apache.org/r/57626/diff/1-2/ Testing --- HiveQA showed only one test failure. it is fixed, and waiting for HiveQA to complete 100% tests. Thanks, Sergio Pena

Re: [ANNOUNCE] New PMC Member : Eugene Koifman

Congratulations Eugene !! On Wed, Mar 15, 2017 at 5:41 AM, Prasanth Jayachandran < pjayachand...@hortonworks.com> wrote: > Congratulations Eugene! > > Thanks > Prasanth > > > > > On Tue, Mar 14, 2017 at 10:02 PM -1000, "Zoltan Haindrich" < >

Review Request 57626: HIVE-16164: Provide mechanism for passing HMS notification ID between transactional and non-transactional listeners.

/ Testing --- HiveQA showed only one test failure. it is fixed, and waiting for HiveQA to complete 100% tests. Thanks, Sergio Pena

Re: Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

ioned, we're just storing two values (partition name + table name), so that consumes less memory than using the hive.getPartition() method call. - Sergio Pena On March 10, 2017, 10:36 a.m., Barna Zsombor

Re: Backward incompatible changes

Hey Ashutosh, thanks for soliciting feedback on this. I like the idea you're proposing; maintaining compatibility and at the same time adding newer features to Hive consumes a lot of development time and effort. However, I think some users and companies have just started to use Hive 2.x branch

Re: Green unit test results

r > fruit. > So, I think we need to make some changes here. > > Any ideas what we can do to ensure green builds going forward? > > Thanks, > Ashutosh > > On Thu, Mar 9, 2017 at 8:07 AM, Sergio Pena <sergio.p...@cloudera.com> > wrote: > > > It's actually blu

Re: Green unit test results

It's actually blue Peter :). But good job, I see that the console output is: {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 10336 tests passed On Thu, Mar 9, 2017 at 8:12 AM, Peter Vary wrote: > Hi, > >

Re: Pre-commit job failing - No disk space

/185_UTBatch_service_8_tests/logs/hive.log You can see all the logs from this link: http://104.198.109.242/logs/ On Fri, Mar 3, 2017 at 2:21 PM, Sergio Pena <sergio.p...@cloudera.com> wrote: > Hey Vihang, > > The ptest master shows how the jobs has increased the log size, could you >

Re: Pre-commit job failing - No disk space

Hey Vihang, The ptest master shows how the jobs has increased the log size, could you investigate what causes this increase? 44G PreCommit-HIVE-Build-3902 44G PreCommit-HIVE-Build-3900 44G PreCommit-HIVE-Build-3899 44G PreCommit-HIVE-Build-3898 44G PreCommit-HIVE-Build-3897

Re: [VOTE] Drop support for Java7 in master branch

Thanks Alan for the proposal. JDK8 seems to have very useful API. It should be good to start using it. +1. On Tue, Feb 28, 2017 at 12:55 AM, Rajat Khandelwal < rajat.khandel...@inmobi.com> wrote: > +1 > > On Tue, Feb 28, 2017 at 10:37 AM, Prasanth Jayachandran < > pjayachand...@hortonworks.com>

Re: Review Request 56334: HIVE-12767: Implement table property to address Parquet int96 timestamp bug

> On Feb. 27, 2017, 11:20 p.m., Sergio Pena wrote: > > Ship It! Thanks Zsombor. This is good work. - Sergio --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56334/#rev

  1   2   3   4   5   >