[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13739267#comment-13739267
]
Navis commented on HIVE-4579:
-
Sorry for late comment, but would it be better to remove MINA
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13737283#comment-13737283
]
Hudson commented on HIVE-4579:
--
SUCCESS: Integrated in Hive-trunk-hadoop1-ptest #124 (See
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736456#comment-13736456
]
Phabricator commented on HIVE-4579:
---
hagleitn has accepted the revision HIVE-4579 [jira]
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736458#comment-13736458
]
Gunther Hagleitner commented on HIVE-4579:
--
+1
I really like this new interface.
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736487#comment-13736487
]
Gunther Hagleitner commented on HIVE-4579:
--
20/20S look good, but compile fails
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736499#comment-13736499
]
Gunther Hagleitner commented on HIVE-4579:
--
Committed to trunk. Thanks Owen!
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736517#comment-13736517
]
Hudson commented on HIVE-4579:
--
FAILURE: Integrated in Hive-trunk-hadoop2 #353 (See
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736565#comment-13736565
]
Hudson commented on HIVE-4579:
--
FAILURE: Integrated in Hive-trunk-h0.21 #2262 (See
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736566#comment-13736566
]
Hudson commented on HIVE-4579:
--
FAILURE: Integrated in Hive-trunk-hadoop2-ptest #54 (See
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736103#comment-13736103
]
Owen O'Malley commented on HIVE-4579:
-
All of the unit tests pass on my machine and
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736108#comment-13736108
]
Edward Capriolo commented on HIVE-4579:
---
I think I roughly understand the interface,
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736110#comment-13736110
]
Edward Capriolo commented on HIVE-4579:
---
{code}
+private final
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736112#comment-13736112
]
Edward Capriolo commented on HIVE-4579:
---
Other then the Deque and ArrayDeque I am +1.
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736113#comment-13736113
]
Edward Capriolo commented on HIVE-4579:
---
One other q.
{quote}
+ public static enum
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736162#comment-13736162
]
Owen O'Malley commented on HIVE-4579:
-
Ed,
I changed the Stack to a Deque with the
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736172#comment-13736172
]
Owen O'Malley commented on HIVE-4579:
-
Ed,
I forgot to answer your previous question.
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736193#comment-13736193
]
Hive QA commented on HIVE-4579:
---
{color:green}Overall{color}: +1 all checks pass
Here are
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735462#comment-13735462
]
Owen O'Malley commented on HIVE-4579:
-
Eric,
In the current subset of SARGS, it isn't
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735773#comment-13735773
]
Hive QA commented on HIVE-4579:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13731448#comment-13731448
]
Gunther Hagleitner commented on HIVE-4579:
--
This is cool. Looks good. A few
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13711611#comment-13711611
]
Owen O'Malley commented on HIVE-4579:
-
I need to update HIVE-4242, but all that
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13701760#comment-13701760
]
Ashutosh Chauhan commented on HIVE-4579:
Does this interface make HIVE-4242
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669027#comment-13669027
]
Owen O'Malley commented on HIVE-4579:
-
I need to add the null-safe equals as an
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669472#comment-13669472
]
Owen O'Malley commented on HIVE-4579:
-
Just to be clear, the sql semantics are:
||
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669545#comment-13669545
]
Eric Hanson commented on HIVE-4579:
---
Since SARGs are always for filters, not for
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669548#comment-13669548
]
Mark Wagner commented on HIVE-4579:
---
This looks good. My one comment is that it would be
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13668881#comment-13668881
]
Eric Hanson commented on HIVE-4579:
---
Overall this looks great. One issue that I think
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669008#comment-13669008
]
Owen O'Malley commented on HIVE-4579:
-
Eric, thanks for the comments!
You're right
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13664293#comment-13664293
]
Ashit Gosalia commented on HIVE-4579:
-
This is a broad enough interface. You may also
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13664321#comment-13664321
]
Eric Hanson commented on HIVE-4579:
---
Consider adding Column IN (list-of-constants) as a
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13663437#comment-13663437
]
Owen O'Malley commented on HIVE-4579:
-
Another alternative is to put the expression
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13662486#comment-13662486
]
Owen O'Malley commented on HIVE-4579:
-
I plan to support SARGs such as:
{code}
SARG:
32 matches
Mail list logo
