[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867608#comment-13867608
]
Viraj Bhat commented on HIVE-6115:
--
Hi Brock,
Thanks for creating this Jira. I am +1 with
[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13868504#comment-13868504
]
Sushanth Sowmyan commented on HIVE-6115:
I've tested the latest patch, and I'm +1
[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13868510#comment-13868510
]
Xuefu Zhang commented on HIVE-6115:
---
+1
Remove redundant code in
[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13866741#comment-13866741
]
Brock Noland commented on HIVE-6115:
Sounds good to me. Thank you for looking at this!!
[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867382#comment-13867382
]
Hive QA commented on HIVE-6115:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13866051#comment-13866051
]
Sushanth Sowmyan commented on HIVE-6115:
Having read through addResources order
[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13866055#comment-13866055
]
Sushanth Sowmyan commented on HIVE-6115:
The above code will only pick up those
[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13864317#comment-13864317
]
Brock Noland commented on HIVE-6115:
Linking with HIVE-5659.
Remove redundant code in
[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13863454#comment-13863454
]
Sushanth Sowmyan commented on HIVE-6115:
Hi guys,
Looking through the code, there
[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13863459#comment-13863459
]
Sushanth Sowmyan commented on HIVE-6115:
I'd love to have [~viraj] also comment -
[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13863466#comment-13863466
]
Brock Noland commented on HIVE-6115:
Hi,
Thanks for this. The issue is that this code
[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13863510#comment-13863510
]
Sushanth Sowmyan commented on HIVE-6115:
There are two purposes served - one, to
[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13863563#comment-13863563
]
Brock Noland commented on HIVE-6115:
Do you know why the tests pass after removing this
[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13863581#comment-13863581
]
Sushanth Sowmyan commented on HIVE-6115:
I think we have e2e tests that run on an
[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13863771#comment-13863771
]
Nick Dimiduk commented on HIVE-6115:
[~sushanth]:
bq. testing under a local
[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13863806#comment-13863806
]
Sushanth Sowmyan commented on HIVE-6115:
I mentioned this on HIVE-5659 as well, but
[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13863824#comment-13863824
]
Nick Dimiduk commented on HIVE-6115:
I agree with you, [~sushanth], on principal, but
[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13863909#comment-13863909
]
Swarnim Kulkarni commented on HIVE-6115:
My 0.02 but two of the properties that we
[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859606#comment-13859606
]
Brock Noland commented on HIVE-6115:
Ashutosh, any idea when Sushanth will be around to
[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859629#comment-13859629
]
Ashutosh Chauhan commented on HIVE-6115:
I think he should be around later this
[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13858027#comment-13858027
]
Brock Noland commented on HIVE-6115:
OK it'd be great to know so we can add comments
[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857721#comment-13857721
]
Hive QA commented on HIVE-6115:
---
{color:green}Overall{color}: +1 all checks pass
Here are
[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857743#comment-13857743
]
Brock Noland commented on HIVE-6115:
I describe why the code is redundant here:
[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857824#comment-13857824
]
Xuefu Zhang commented on HIVE-6115:
---
+1
Remove redundant code in
[
https://issues.apache.org/jira/browse/HIVE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857853#comment-13857853
]
Ashutosh Chauhan commented on HIVE-6115:
There was a reason for this, but I forgot
25 matches
Mail list logo
