Re: Review Request 47242: HIVE-13726

2016-05-12 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47242/ --- (Updated May 12, 2016, 7:30 a.m.) Review request for hive and Rui Li. Bugs:

Re: Review Request 47242: HIVE-13726

2016-05-12 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47242/ --- (Updated May 12, 2016, 6:07 a.m.) Review request for hive and Rui Li.

Re: Review Request 47242: HIVE-13726

2016-05-12 Thread Rui Li
> On May 12, 2016, 5:48 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java, line 3074 > > > > > > It could have been. Feels cleaner to me as non-static. Just a matter of > >

Re: Review Request 47242: HIVE-13726

2016-05-11 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47242/#review132822 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line

Re: Review Request 47242: HIVE-13726

2016-05-11 Thread Rui Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47242/#review132821 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line