Re: Review Request: HIVE-2049. Push down partition pruning to JDO filtering for a subset of partition predicates

2011-03-21 Thread Ning Zhang
On 2011-03-16 20:19:58, M IS wrote: trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java, line 1786 https://reviews.apache.org/r/489/diff/2/?file=14162#file14162line1786 Why can't we just do : code return (value instanceof String); /code

Re: Review Request: HIVE-2049. Push down partition pruning to JDO filtering for a subset of partition predicates

2011-03-21 Thread Ning Zhang
On 2011-03-16 16:37:44, Ning Zhang wrote: trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java, line 244 https://reviews.apache.org/r/489/diff/1/?file=13887#file13887line244 I agree in general we should use a generic interface in the declaration, but

Re: Review Request: HIVE-2049. Push down partition pruning to JDO filtering for a subset of partition predicates

2011-03-21 Thread namit jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/489/#review341 --- trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java

Re: Review Request: HIVE-2049. Push down partition pruning to JDO filtering for a subset of partition predicates

2011-03-21 Thread namit jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/489/#review342 --- It would be very useful to have the JDO expression for the table under

Re: Review Request: HIVE-2049. Push down partition pruning to JDO filtering for a subset of partition predicates

2011-03-21 Thread namit jain
On 2011-03-21 13:45:49, namit jain wrote: It would be very useful to have the JDO expression for the table under consideration in the explain plan (extended). The client side logs are very difficult to debug with. - namit ---

Re: Review Request: HIVE-2049. Push down partition pruning to JDO filtering for a subset of partition predicates

2011-03-21 Thread Ning Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/489/ --- (Updated 2011-03-21 16:02:55.219077) Review request for hive. Changes ---

Re: Review Request: HIVE-2049. Push down partition pruning to JDO filtering for a subset of partition predicates

2011-03-16 Thread Ning Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/489/#review333 --- trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java

Re: Review Request: HIVE-2049. Push down partition pruning to JDO filtering for a subset of partition predicates

2011-03-16 Thread Ning Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/489/ --- (Updated 2011-03-16 16:50:15.347839) Review request for hive. Changes ---

Re: Review Request: HIVE-2049. Push down partition pruning to JDO filtering for a subset of partition predicates

2011-03-16 Thread M IS
On 2011-03-16 16:37:44, Ning Zhang wrote: trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java, line 244 https://reviews.apache.org/r/489/diff/1/?file=13887#file13887line244 I agree in general we should use a generic interface in the declaration, but

Re: Review Request: HIVE-2049. Push down partition pruning to JDO filtering for a subset of partition predicates

2011-03-16 Thread M IS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/489/#review336 --- trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java

Re: Review Request: HIVE-2049. Push down partition pruning to JDO filtering for a subset of partition predicates

2011-03-13 Thread M IS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/489/#review325 --- trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java

Review Request: HIVE-2049. Push down partition pruning to JDO filtering for a subset of partition predicates

2011-03-11 Thread Ning Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/489/ --- Review request for hive. Summary --- * expose