Re: Review Request 21846: HIVE-7117: Partitions not inheriting table permissions after alter rename partition

2014-06-03 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21846/ --- (Updated June 3, 2014, 9:16 p.m.) Review request for hive and Szehon Ho. Chan

Re: Review Request 21846: HIVE-7117: Partitions not inheriting table permissions after alter rename partition

2014-06-03 Thread Ashish Singh
> On June 3, 2014, 2:37 p.m., Swarnim Kulkarni wrote: > > common/src/java/org/apache/hadoop/hive/common/FileUtils.java, line 591 > > > > > > Like I said its pretty minor but in my opinion its easy to miss the > > inte

Re: Review Request 21846: HIVE-7117: Partitions not inheriting table permissions after alter rename partition

2014-06-03 Thread Ashish Singh
> On June 3, 2014, 5:57 a.m., Szehon Ho wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java, line 208 > > > > > > I missed this earlier, can we just return the value returned from here > > in

Re: Review Request 21846: HIVE-7117: Partitions not inheriting table permissions after alter rename partition

2014-06-03 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21846/ --- (Updated June 3, 2014, 9:10 p.m.) Review request for hive and Szehon Ho. Chan

Re: Review Request 21846: HIVE-7117: Partitions not inheriting table permissions after alter rename partition

2014-06-03 Thread Swarnim Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21846/#review44626 --- common/src/java/org/apache/hadoop/hive/common/FileUtils.java

Re: Review Request 21846: HIVE-7117: Partitions not inheriting table permissions after alter rename partition

2014-06-02 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21846/#review44602 --- Thanks for rebasing! One minor suggestion (apologies for not seeing

Re: Review Request 21846: HIVE-7117: Partitions not inheriting table permissions after alter rename partition

2014-06-02 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21846/ --- (Updated June 3, 2014, 3:38 a.m.) Review request for hive and Szehon Ho. Chan

Re: Review Request 21846: HIVE-7117: Partitions not inheriting table permissions after alter rename partition

2014-06-02 Thread Ashish Singh
> On May 23, 2014, 5:54 a.m., Swarnim Kulkarni wrote: > > common/src/java/org/apache/hadoop/hive/common/FileUtils.java, line 591 > > > > > > Minor but this method seems to be doing more than just renaming. Should > >

Re: Review Request 21846: HIVE-7117: Partitions not inheriting table permissions after alter rename partition

2014-05-28 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21846/ --- (Updated May 28, 2014, 10:10 p.m.) Review request for hive and Szehon Ho. Cha

Re: Review Request 21846: HIVE-7117: Partitions not inheriting table permissions after alter rename partition

2014-05-27 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21846/ --- (Updated May 27, 2014, 6:38 p.m.) Review request for hive and Szehon Ho. Summ

Re: Review Request 21846: HIVE-7117: Partitions not inheriting table permissions after alter rename partition

2014-05-22 Thread Swarnim Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21846/#review43810 --- common/src/java/org/apache/hadoop/hive/common/FileUtils.java

Re: Review Request 21846: HIVE-7117: Partitions not inheriting table permissions after alter rename partition

2014-05-22 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21846/ --- (Updated May 23, 2014, 4:42 a.m.) Review request for hive and Szehon Ho. Chan

Review Request 21846: HIVE-7117: Partitions not inheriting table permissions after alter rename partition

2014-05-22 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21846/ --- Review request for hive and Szehon Ho. Repository: hive-git Description -