Re: Review Request 25178: HIVE-7100 Add DROP TABLE PURGE

2014-09-16 Thread david seraf
On Sept. 13, 2014, 3:54 a.m., Xuefu Zhang wrote: metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 1409 https://reviews.apache.org/r/25178/diff/3/?file=684101#file684101line1409 Maybe I wasn't clear, I was only talking about the two methods added in

Re: Review Request 25178: HIVE-7100 Add DROP TABLE PURGE

2014-09-16 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25178/#review53612 ---

Re: Review Request 25178: HIVE-7100 Add DROP TABLE PURGE

2014-09-16 Thread david seraf
On Sept. 16, 2014, 10:21 p.m., Xuefu Zhang wrote: metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 1409 https://reviews.apache.org/r/25178/diff/3/?file=684101#file684101line1409 Maybe I'm misunderstanding. the added dropTableData(Path, boolean) is

Re: Review Request 25178: HIVE-7100 Add DROP TABLE PURGE

2014-09-16 Thread david seraf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25178/ --- (Updated Sept. 16, 2014, 11:52 p.m.) Review request for hive and Xuefu Zhang.

Re: Review Request 25178: HIVE-7100 Add DROP TABLE PURGE

2014-09-15 Thread david seraf
On Sept. 13, 2014, 3:54 a.m., Xuefu Zhang wrote: metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 1409 https://reviews.apache.org/r/25178/diff/3/?file=684101#file684101line1409 Maybe I wasn't clear, I was only talking about the two methods added in

Re: Review Request 25178: HIVE-7100 Add DROP TABLE PURGE

2014-09-12 Thread david seraf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25178/ --- (Updated Sept. 12, 2014, 8:28 p.m.) Review request for hive and Xuefu Zhang.

Re: Review Request 25178: HIVE-7100 Add DROP TABLE PURGE

2014-09-12 Thread david seraf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25178/ --- (Updated Sept. 12, 2014, 8:28 p.m.) Review request for hive and Xuefu Zhang.

Re: Review Request 25178: HIVE-7100 Add DROP TABLE PURGE

2014-09-12 Thread david seraf
On Sept. 10, 2014, 6:40 p.m., Xuefu Zhang wrote: metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 1409 https://reviews.apache.org/r/25178/diff/3/?file=684101#file684101line1409 Nit: should we just pass ifPurge as boolean to the method unless

Re: Review Request 25178: HIVE-7100 Add DROP TABLE PURGE

2014-09-12 Thread david seraf
On Sept. 4, 2014, 9:39 p.m., Mithun Radhakrishnan wrote: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java, line 1748 https://reviews.apache.org/r/25178/diff/2/?file=674626#file674626line1748 We're going to need this too, for the solution to be complete. We'll need a new

Re: Review Request 25178: HIVE-7100 Add DROP TABLE PURGE

2014-09-12 Thread david seraf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25178/ --- (Updated Sept. 12, 2014, 9:51 p.m.) Review request for hive and Xuefu Zhang.

Re: Review Request 25178: HIVE-7100 Add DROP TABLE PURGE

2014-09-12 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25178/#review53259 ---