Re: Review Request 46597: HIVE-13445 LLAP: token should encode application and cluster ids

2016-05-03 Thread Siddharth Seth
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46597/#review131512 --- Ship it! Looks good. - Siddharth Seth On May 2, 2016, 10:01

Re: Review Request 46597: HIVE-13445 LLAP: token should encode application and cluster ids

2016-05-02 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46597/ --- (Updated May 2, 2016, 10:01 p.m.) Review request for hive and Siddharth Seth.

Re: Review Request 46597: HIVE-13445 LLAP: token should encode application and cluster ids

2016-04-30 Thread Siddharth Seth
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46597/#review131248 --- Minor comment which should be fixed. Regarding exceptions - the

Re: Review Request 46597: HIVE-13445 LLAP: token should encode application and cluster ids

2016-04-25 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46597/ --- (Updated April 26, 2016, 12:58 a.m.) Review request for hive and Siddharth

Re: Review Request 46597: HIVE-13445 LLAP: token should encode application and cluster ids

2016-04-25 Thread Sergey Shelukhin
> On April 25, 2016, 9:50 a.m., Siddharth Seth wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/ContainerRunner.java, > > line 32 > > > > > > Throw something other than IOException, which typically

Re: Review Request 46597: HIVE-13445 LLAP: token should encode application and cluster ids

2016-04-25 Thread Siddharth Seth
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46597/#review130369 ---

Re: Review Request 46597: HIVE-13445 LLAP: token should encode application and cluster ids

2016-04-22 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46597/ --- (Updated April 23, 2016, 2:08 a.m.) Review request for hive and Siddharth

Review Request 46597: HIVE-13445 LLAP: token should encode application and cluster ids

2016-04-22 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46597/ --- Review request for hive and Siddharth Seth. Repository: hive-git Description