Re: Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

2017-09-01 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61165/ --- (Updated Sept. 1, 2017, 10:21 p.m.) Review request for hive and Ashutosh

Re: Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

2017-09-01 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61165/ --- (Updated Sept. 1, 2017, 7 p.m.) Review request for hive and Ashutosh Chauhan.

Re: Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

2017-09-01 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61165/#review184359 --- ql/src/test/queries/clientpositive/join_reordering_no_stats.q

Re: Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

2017-09-01 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61165/#review184356 --- ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java

Re: Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

2017-09-01 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61165/ --- (Updated Sept. 1, 2017, 7:49 a.m.) Review request for hive and Ashutosh

Re: Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

2017-08-31 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61165/ --- (Updated Sept. 1, 2017, 5:20 a.m.) Review request for hive and Ashutosh

Re: Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

2017-08-31 Thread Vineet Garg
> On Aug. 29, 2017, 9:26 p.m., Ashutosh Chauhan wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Lines 1672 (patched) > > > > > > varchar has length in its type. We shall use that. Can you

Re: Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

2017-08-31 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61165/ --- (Updated Sept. 1, 2017, 12:04 a.m.) Review request for hive and Ashutosh

Re: Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

2017-08-31 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61165/#review184318 --- Latest patch doesn't address all review comments. Shall I wait

Re: Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

2017-08-31 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61165/ --- (Updated Aug. 31, 2017, 10:02 p.m.) Review request for hive and Ashutosh

Re: Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

2017-08-31 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61165/ --- (Updated Aug. 31, 2017, 9:58 p.m.) Review request for hive and Ashutosh

Re: Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

2017-08-29 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61165/#review184071 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Lines

Re: Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

2017-08-27 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61165/ --- (Updated Aug. 27, 2017, 11:11 p.m.) Review request for hive and Ashutosh

Re: Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

2017-08-25 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61165/ --- (Updated Aug. 26, 2017, 12:49 a.m.) Review request for hive and Ashutosh

Re: Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

2017-08-23 Thread Vineet Garg
> On Aug. 16, 2017, 10:58 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java > > Lines 304 (patched) > > > > > > Can this ever be null ? I think it could

Re: Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

2017-08-16 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61165/#review183080 --- - Ashutosh Chauhan On Aug. 8, 2017, 8:10 p.m., Vineet Garg

Re: Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

2017-08-16 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61165/#review183073 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Lines

Re: Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

2017-08-08 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61165/ --- (Updated Aug. 8, 2017, 8:10 p.m.) Review request for hive and Ashutosh

Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

2017-07-26 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61165/ --- Review request for hive and Ashutosh Chauhan. Bugs: HIVE-16811