Re: Review Request 61188: HIVE-16614

2017-08-24 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61188/ --- (Updated Aug. 24, 2017, 4:41 p.m.) Review request for hive and Ashutosh

Re: Review Request 61188: HIVE-16614

2017-08-24 Thread Jesús Camacho Rodríguez
> On Aug. 24, 2017, 3:03 p.m., Ashutosh Chauhan wrote: > > ql/src/test/queries/clientpositive/localtimezone.q > > Lines 27 (patched) > > > > > > Shouldn't tpye be now : timestamp with *local* time zone? Yes, I

Re: Review Request 61188: HIVE-16614

2017-08-24 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61188/#review183739 --- ql/src/test/queries/clientpositive/localtimezone.q Lines 27

Re: Review Request 61188: HIVE-16614

2017-08-23 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61188/ --- (Updated Aug. 23, 2017, 9:02 p.m.) Review request for hive and Ashutosh

Re: Review Request 61188: HIVE-16614

2017-08-23 Thread Jesús Camacho Rodríguez
> On Aug. 23, 2017, 12:44 a.m., Ashutosh Chauhan wrote: > > common/src/java/org/apache/hadoop/hive/common/type/TimestampTZUtil.java > > Lines 55 (patched) > > > > > > This may come from config to allow parsing of

Re: Review Request 61188: HIVE-16614

2017-08-23 Thread Jesús Camacho Rodríguez
> On Aug. 23, 2017, 12:44 a.m., Ashutosh Chauhan wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java > > Line 74 (original) > > > > > > Not

Re: Review Request 61188: HIVE-16614

2017-08-23 Thread Jesús Camacho Rodríguez
> On Aug. 23, 2017, 12:44 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java > > Line 966 (original), 966 (patched) > > > > > > missing

Re: Review Request 61188: HIVE-16614

2017-08-22 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61188/#review183557 ---

Review Request 61188: HIVE-16614

2017-07-27 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61188/ --- Review request for hive and Ashutosh Chauhan. Bugs: HIVE-16614