Re: Review Request 65219: HIVE-18486: Create tests to cover methods for adding Partitions

2018-01-27 Thread Marta Kuczora via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65219/ --- (Updated Jan. 27, 2018, 10:01 a.m.) Review request for hive, Peter Vary and

Re: Review Request 65219: HIVE-18486: Create tests to cover methods for adding Partitions

2018-01-25 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65219/#review196256 --- Ship it! Ship It! - Peter Vary On Jan. 25, 2018, 2:40 p.m.,

Re: Review Request 65219: HIVE-18486: Create tests to cover methods for adding Partitions

2018-01-25 Thread Marta Kuczora via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65219/ --- (Updated Jan. 25, 2018, 2:40 p.m.) Review request for hive, Peter Vary and

Re: Review Request 65219: HIVE-18486: Create tests to cover methods for adding Partitions

2018-01-25 Thread Marta Kuczora via Review Board
> On Jan. 19, 2018, 4:36 p.m., Adam Szita wrote: > > Looks good! I added small issues to fix, similarly with the dropPartitions > > change: some helper methods could be static (the ones that don't depend on > > HMS client certainly) and some could use Lists.newArrayList Thanks a lot Adam for

Re: Review Request 65219: HIVE-18486: Create tests to cover methods for adding Partitions

2018-01-25 Thread Marta Kuczora via Review Board
> On Jan. 19, 2018, 1:56 p.m., Peter Vary wrote: > > Thanks Marta for the patch. > > Some questions below. > > Also I think it would be nice to have test for the default values when > > adding a partition. > > > > Thanks, > > Peter Thanks a lot Peter for the review. That's a good idea, added

Re: Review Request 65219: HIVE-18486: Create tests to cover methods for adding Partitions

2018-01-19 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65219/#review195825 --- Looks good! I added small issues to fix, similarly with the

Re: Review Request 65219: HIVE-18486: Create tests to cover methods for adding Partitions

2018-01-19 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65219/#review195811 --- Thanks Marta for the patch. Some questions below. Also I think it

Review Request 65219: HIVE-18486: Create tests to cover methods for adding Partitions

2018-01-18 Thread Marta Kuczora via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65219/ --- Review request for hive, Peter Vary and Adam Szita. Bugs: HIVE-18486