Re: Review Request 65284: Create tests to cover listPartition(s) methods

2018-01-25 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65284/#review196255 --- Ship it! Ship It! - Peter Vary On Jan. 25, 2018, 1:47 p.m.,

Re: Review Request 65284: Create tests to cover listPartition(s) methods

2018-01-25 Thread Marta Kuczora via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65284/#review196246 --- Ship it! Ship It! - Marta Kuczora On Jan. 25, 2018, 1:47 p.m

Re: Review Request 65284: Create tests to cover listPartition(s) methods

2018-01-25 Thread Adam Szita via Review Board
> On Jan. 25, 2018, 11:37 a.m., Marta Kuczora wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java > > Lines 762-765 (patched) > > > > > > Is this the same use

Re: Review Request 65284: Create tests to cover listPartition(s) methods

2018-01-25 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65284/ --- (Updated Jan. 25, 2018, 1:47 p.m.) Review request for hive, Marta Kuczora and P

Re: Review Request 65284: Create tests to cover listPartition(s) methods

2018-01-25 Thread Marta Kuczora via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65284/#review196236 --- Thanks a lot Adam for the patch. It looks really good to me, I jus

Re: Review Request 65284: Create tests to cover listPartition(s) methods

2018-01-24 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65284/ --- (Updated Jan. 24, 2018, 11:22 a.m.) Review request for hive, Marta Kuczora and

Re: Review Request 65284: Create tests to cover listPartition(s) methods

2018-01-23 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65284/#review195996 --- That is a hugh number of tests. Might add some more. Please check

Review Request 65284: Create tests to cover listPartition(s) methods

2018-01-23 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65284/ --- Review request for hive, Marta Kuczora and Peter Vary. Bugs: HIVE-18484 htt