Re: Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

2018-09-24 Thread Andrew Sherman via Review Board
> On Sept. 20, 2018, 10:56 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Lines 316 (patched) > > > > > > 1) Does

Re: Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

2018-09-24 Thread Laszlo Pinter via Review Board
> On Sept. 20, 2018, 10:56 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Lines 316 (patched) > > > > > > 1) Does

Re: Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

2018-09-24 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68767/ --- (Updated Sept. 24, 2018, 12:16 p.m.) Review request for hive, Alexander

Re: Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

2018-09-21 Thread Andrew Sherman via Review Board
> On Sept. 20, 2018, 10:56 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Lines 316 (patched) > > > > > > 1) Does

Re: Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

2018-09-21 Thread Andrew Sherman via Review Board
> On Sept. 21, 2018, 12:04 a.m., denys kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Line 311 (original), 311 (patched) > > > > > >

Re: Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

2018-09-21 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68767/ --- (Updated Sept. 21, 2018, 3:21 p.m.) Review request for hive, Alexander

Re: Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

2018-09-21 Thread Laszlo Pinter via Review Board
> On Sept. 20, 2018, 10:56 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Lines 316 (patched) > > > > > > 1) Does

Re: Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

2018-09-21 Thread Laszlo Pinter via Review Board
> On Sept. 20, 2018, 10:56 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Line 316 (original), 315 (patched) > > > > > >

Re: Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

2018-09-20 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68767/#review208827 ---

Re: Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

2018-09-20 Thread Andrew Sherman via Review Board
> On Sept. 20, 2018, 10:56 p.m., Andrew Sherman wrote: > > This all looks good, I haver questions... - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68767/#review208821

Re: Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

2018-09-20 Thread Andrew Sherman via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68767/#review208821 ---

Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

2018-09-19 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68767/ --- Review request for hive, Alexander Kolbasov, Peter Vary, and Vihang