Re: Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

2018-10-19 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68975/ --- (Updated Oct. 19, 2018, 8:30 a.m.) Review request for hive and Peter Vary.

Re: Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

2018-10-18 Thread Laszlo Pinter via Review Board
> On Oct. 18, 2018, 9:13 a.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java > > Lines 1921 (patched) > > > > > > nit: one extra space done. > On Oct. 18, 2018, 9:13 a.m., Peter

Re: Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

2018-10-18 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68975/#review209735 --- Thanks Laci! 1 serions question 1 mild one and several annoying

Re: Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

2018-10-18 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68975/ --- (Updated Oct. 18, 2018, 7:01 a.m.) Review request for hive and Peter Vary.

Re: Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

2018-10-17 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68975/ --- (Updated Oct. 17, 2018, 1:44 p.m.) Review request for hive and Peter Vary.

Re: Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

2018-10-13 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68975/ --- (Updated Oct. 13, 2018, 9:55 a.m.) Review request for hive and Peter Vary.

Re: Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

2018-10-13 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68975/ --- (Updated Oct. 13, 2018, 7:56 a.m.) Review request for hive and Peter Vary.

Re: Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

2018-10-13 Thread Laszlo Pinter via Review Board
> On Oct. 11, 2018, 8:54 a.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java > > Lines 1896 (patched) > > > > > > What does this method do? > > Moving files and updating

Re: Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

2018-10-11 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68975/#review209443 --- Thanks Laszlo! This is a big patch indeed. Comments below. Could

Review Request 68975: HIVE-20661: Dynamic partitions loading calls add partition for every partition 1-by-1

2018-10-10 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68975/ --- Review request for hive and Peter Vary. Repository: hive-git Description