This is old code, hard to attribute to jiras
Okay, HIVE-2337 was way back in release 0.8.0 so I think we can safely omit
version information. If anyone objects, I can link the wikidoc to that
ticket. (And I've marked HIVE-2337 as being related to HIVE-279 in the
JIRA.)
Thanks for all the
Happy to fix the sentence and the link. I pointed out the name change just
so you would review it, so please don't apologize!
One more question: why am I not finding getQualifiedAliases() in the
SemanticAnalyzer class? It turns up in OpProcFactory.java with javadoc
comments, but I can't find
getQualifiedAliases is a private method in JoinPPD.
Maybe we should remove the section on Hive Implementation here. It is in the
Design doc; this information only concerns developers.
regards,
Harish.
On Dec 11, 2013, at 3:05 AM, Lefty Leverenz leftylever...@gmail.com wrote:
Happy to fix
Maybe we should remove the section on Hive Implementation here.
It is in the Design doc; this information only concerns developers.
But this is the Design doc (unless there's another one somewhere -- maybe
attached to a JIRA ticket?) and it's in the Resources for Contributors part
of the wiki,
I see. Let's leave it in.
This is old code, hard to attribute to jiras:
- The PPD code comes from: HIVE-279, HIVE-2337
- I cannot tell when the join condition parsing code was added.
regards,
Harish.
On Dec 11, 2013, at 5:17 PM, Lefty Leverenz leftylever...@gmail.com wrote:
Maybe we should
Okay, then monospace with () after the method name is a good way to show
them: parseJoinCondition() and getQualifiedAlias() ... but I only found
the latter pluralized, instead of singular, so should it be
getQualifiedAliases() or am I missing something?
trunk *grep -nr 'getQualifiedAlias'
You are correct, it is plural.
regards,
Harish.
On Dec 10, 2013, at 4:03 AM, Lefty Leverenz leftylever...@gmail.com wrote:
Okay, then monospace with () after the method name is a good way to show
them: parseJoinCondition() and getQualifiedAlias() ... but I only found the
latter pluralized,
How's this? Hive
Implementationhttps://cwiki.apache.org/confluence/display/Hive/OuterJoinBehavior#OuterJoinBehavior-HiveImplementation
Also, I moved the link on the Design Docs
pagehttps://cwiki.apache.org/confluence/display/Hive/DesignDocsfrom
*Proposed* to *Other*. (It's called SQL Outer Join
I can see why you would rename.
But this sentence is not correct:
'Hive enforces the predicate pushdown rules by these methods in the
SemanticAnalyzer and JoinPPD classes:'
It should be:
Hive enforces the rules by these methods in the SemanticAnalyzer and JoinPPD
classes:
(The implementation
The Outer Join Behavior
wikidochttps://cwiki.apache.org/confluence/display/Hive/OuterJoinBehavioris
done, with links from the Design
Docs https://cwiki.apache.org/confluence/display/Hive/DesignDocs page and
the Joins
Looks great!
Thanks for also linking to it from the other relevant docs!
On Mon, Dec 9, 2013 at 1:52 AM, Lefty Leverenz leftylever...@gmail.com wrote:
The Outer Join Behavior
wikidochttps://cwiki.apache.org/confluence/display/Hive/OuterJoinBehavioris
done, with links from the Design
Docs
Looks good. Thanks for doing this.
Minor point:
Rule 1: During QBJoinTree construction in Plan Gen, the parse Join Condition
logic applies this rule.
Rule 2: During JoinPPD (Join Predicate Pushdown) the get Qualified Alias logic
applies this rule.
FYI 'parseJoinCondition' and
FYI, Harish has a written a very nice doc describing predicate push
down rules for join. I have attached it to the design doc page. It
will be very useful for anyone looking at joins.
https://cwiki.apache.org/confluence/download/attachments/27362075/OuterJoinBehavior.html
(any help converting it
Easy as 3.14159 (I can take a hint.)
-- Lefty
On Mon, Dec 2, 2013 at 5:34 PM, Thejas Nair the...@hortonworks.com wrote:
FYI, Harish has a written a very nice doc describing predicate push
down rules for join. I have attached it to the design doc page. It
will be very useful for anyone
:)
On Mon, Dec 2, 2013 at 6:18 PM, Lefty Leverenz leftylever...@gmail.com wrote:
Easy as 3.14159 (I can take a hint.)
-- Lefty
On Mon, Dec 2, 2013 at 5:34 PM, Thejas Nair the...@hortonworks.com wrote:
FYI, Harish has a written a very nice doc describing predicate push
down rules
15 matches
Mail list logo