Review Request 65500: Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-02 Thread Vihang Karajgaonkar via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65500/
---

Review request for hive, Aihua Xu, Gopal V, Matt McCline, and Sahil Takiar.


Bugs: HIVE-18449
https://issues.apache.org/jira/browse/HIVE-18449


Repository: hive-git


Description
---

See JIRA.


Diffs
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
4f2e6d31af85cf1d9866ad1419f5c06a18eea347 
  ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticColumn.txt 
b5011c3adcedf8974d3241994733e0021a851cbd 
  ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticScalar.txt 
cbec1abcc2b66f3ffc91b4778daf5017eff4379d 
  ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt 
3e955578933dd7990939865527c3bd11023b3a90 
  ql/src/gen/vectorization/ExpressionTemplates/ColumnUnaryMinus.txt 
f0ab4711e79c8a1bfceebcde9a3dda2b4e15a38a 
  ql/src/gen/vectorization/ExpressionTemplates/ScalarArithmeticColumn.txt 
e95baa6199e138a4e0c009e62ce495b626e5909c 
  
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorExpressionDescriptor.java
 bbe78c8720e16163b642f54d27fdf6b65ba9850b 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 
d46eb8d737cf2885b7f34004a9bd9eadbcf6af7a 
  
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColModuloLongColumnChecked.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/OverflowUtils.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/PosModDoubleToDouble.java
 75ec419aa9ea5c3fcc5e7314fbac756d6a5d36d5 
  
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/PosModLongToLong.java
 6b4d714c9a79a55593c4a4d254267a3035abb10f 
  
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorExpression.java
 710165033627b33d9b238cc847dbac36c07ee5f6 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java 
af8552caa02f2896f393a5099abdb1ae5abd4c16 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java 
e2a638da518a2071ff15b8da6899646ec45c832a 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java 
99d1ad7f203d946fd89d26074bd0e00dec8b3a1a 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPNegative.java 
4e45788936559bbb7cfe65e9ffd083747b37dcc2 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java 
b1200e673e6b470b5fd1cc856270a6da615f16cb 
  
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestUnaryMinus.java
 ab6f6b79316818cac458390dc2d087091057c63b 
  
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorArithmeticExpressions.java
 02dec659ce421eef06f924bb6973070878d57be3 
  ql/src/test/queries/clientpositive/vectorization_numeric_overflows.q 
PRE-CREATION 
  ql/src/test/results/clientpositive/vectorization_numeric_overflows.q.out 
PRE-CREATION 
  vector-code-gen/src/org/apache/hadoop/hive/tools/GenVectorCode.java 
657ea34e11f7465e6c77d45128b298e7326a057b 


Diff: https://reviews.apache.org/r/65500/diff/1/


Testing
---


Thanks,

Vihang Karajgaonkar

[jira] [Created] (HIVE-18617) Workload management Action parser does not generate the correct pool path.

2018-02-02 Thread Harish Jaiprakash (JIRA) 
Harish Jaiprakash created HIVE-18617:


 Summary: Workload management Action parser does not generate the 
correct pool path.
 Key: HIVE-18617
 URL: https://issues.apache.org/jira/browse/HIVE-18617
 Project: Hive
  Issue Type: Bug
Reporter: Harish Jaiprakash
Assignee: Harish Jaiprakash


For expression:  "MOVE TO plan_2.pool", generated path is "plan_2..", but 
expected plan_2.pool



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 65498: HIVE-18281: HiveServer2 HA for LLAP and Workload Manager

2018-02-02 Thread j . prasanth . j 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65498/
---

Review request for hive, Sergey Shelukhin and Thejas Nair.


Bugs: HIVE-18281
https://issues.apache.org/jira/browse/HIVE-18281


Repository: hive-git


Description
---

HIVE-18281: HiveServer2 HA for LLAP and Workload Manager


Diffs
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
4f2e6d31af85cf1d9866ad1419f5c06a18eea347 
  itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestActivePassiveHA.java 
PRE-CREATION 
  
itests/util/src/main/java/org/apache/hive/jdbc/miniHS2/AbstractHiveService.java 
6cab8cdd7d0f2dcc6c55800dba69786fad638cea 
  itests/util/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java 
8bbf8a40e2400ea5ec56f76078b0e227dfe7e95a 
  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceRegistry.java 
5d7f8131f54f7401888dae47f3b1e75ab3c81b06 
  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java
 c88198ffa154dd7ed405f7c79eca21a67eaba45a 
  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapRegistryService.java
 80a6abaed4c015c43b08b610a42d6cb63fa678a8 
  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapZookeeperRegistryImpl.java
 83392309bb1dabfd4e93656385775b5bccb335d3 
  
llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenClient.java 
32d5caa51bec0c0ec97c641356278221280916d1 
  llap-client/src/java/org/apache/hadoop/hive/registry/RegistryUtilities.java 
PRE-CREATION 
  llap-client/src/java/org/apache/hadoop/hive/registry/ServiceInstance.java 
908b3bbe14196f86aaa090e0469a5c279ee55193 
  llap-client/src/java/org/apache/hadoop/hive/registry/ServiceInstanceSet.java 
34fba5c3fab85073590260612cc59893c45da57d 
  
llap-client/src/java/org/apache/hadoop/hive/registry/impl/ServiceInstanceBase.java
 db3d788de5def33b30023993820422a077e02c90 
  llap-client/src/java/org/apache/hadoop/hive/registry/impl/TezAmInstance.java 
0724cf5b1fc57101f79832def9dd2ff26f86643a 
  
llap-client/src/java/org/apache/hadoop/hive/registry/impl/TezAmRegistryImpl.java
 417e571b8d884bc80edf9384d363ea6973cdaa39 
  llap-client/src/java/org/apache/hadoop/hive/registry/impl/ZkRegistryBase.java 
17269dddf7ba8b43c34580311effcda5d3d27fbe 
  llap-common/src/java/org/apache/hadoop/hive/llap/metrics/MetricsUtils.java 
9666517a354b97f02914f93773b22316ed872cf2 
  llap-ext-client/src/java/org/apache/hadoop/hive/llap/LlapBaseInputFormat.java 
0120639955683b69886d262e07240b0526136d86 
  
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/services/impl/LlapWebServices.java
 58bf8dce9c33dd000eb5c91975369d7abe21caed 
  
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java
 66de3b805a752dd5527fd01e17939eb4b190f54f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 
82fdf6cf2f0299ff78e63acad00b8b5e6b62ac90 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 
b98fb58f0ba113f58ca0c724b3f3b0a58180c10d 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/Utils.java 
b33f027e40481efd31989c9b18d94f5706138a63 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapClusterStateForCompile.java
 a8d729d797e0c616fde2cbaf9e7cc21895cc791f 
  ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java 
d261623eb136b4f109210eb62ccb87d10e2174a8 
  
service/src/java/org/apache/hive/service/server/HS2ActivePassiveHARegistry.java 
PRE-CREATION 
  
service/src/java/org/apache/hive/service/server/HS2ActivePassiveHARegistryClient.java
 PRE-CREATION 
  service/src/java/org/apache/hive/service/server/HiveServer2.java 
2a528cd14511d0db1df51b5785dc27425fa6f880 
  service/src/java/org/apache/hive/service/server/HiveServer2HAInstanceSet.java 
PRE-CREATION 
  service/src/java/org/apache/hive/service/server/HiveServer2Instance.java 
PRE-CREATION 
  service/src/java/org/apache/hive/service/servlet/HS2LeadershipStatus.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/65498/diff/1/


Testing
---


Thanks,

Prasanth_J

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-02 Thread Eugene Koifman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/#review196778
---




ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java
Line 507 (original), 507 (patched)


This seems to change the logic. isAcidTable() used to mean full acid, but 
now it less than that...



ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java
Line 376 (original), 376 (patched)


compactor doesn't rewrite MM tables.  So it always assumed full acid



ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java
Line 839 (original), 839 (patched)


why is this null?  it used to be that a table with "transactional=true" 
would become full acid - is that still the case?  there are a few places where 
the last param in 
AcidUtils.setAcidOperationalProperties(conf, true, null);
is nulll


- Eugene Koifman


On Jan. 29, 2018, 11:12 p.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65413/
> ---
> 
> (Updated Jan. 29, 2018, 11:12 p.m.)
> 
> 
> Review request for hive and Eugene Koifman.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> .
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
> b7d3e99e1a505f576a06c530080fc72dddcd85ba 
>   
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java
>  5ee8aadfa774a85a0bdbcaf78a636ff6593c43e2 
>   
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java
>  5e12614cfe17030f8fcb56ef8c83b53b8b870c97 
>   
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java
>  c98d22be2e6216e95d9c13f3a26540ca03e7405e 
>   
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java
>  13059023516edbb58a9129ba9aa49de7e40129e6 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java
>  d252279be973201227da52d8aecf83b3fcc4656b 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java
>  68bb168bd23b84dd150cdc4da63d73657f1b33bb 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 
> a7dace955d6fb3dabc4c5e77ef68f83617eb48d1 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 
> 270b576199c57c109195b85d43e216743a607955 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java 
> abd42ec651927503e7c8c2d9a7d3d415cc9c4ac4 
>   ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 
> eb75308e8393cadf8e69e0e30b303474b89df03e 
>   ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 
> c3b846c4d2fee8691b4952b9f6cf4dd1d8bd632f 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 
> ff2cc0455c64ed210d8ff14a9f112cd91b7314be 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 
> 61565ef0305006a57b7f608e60ddcdf2b6ff474d 
>   
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java
>  da200049bcbc8f2fe1d793acc7b84f8b99ae67cc 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 
> 7b157e648646c5a199aaebf04484b81ff1c12478 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 
> 923372d5b6da42446997051d0758e9aab4881e2e 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 
> 190771ea6b1cbf4b669a8919271b25a689af941b 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 
> 661446df0b9fbb5cf248d76205e47dbaa113026f 
>   ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 
> 9152b4e08a7a1044fc7f844d47ae8e180162b78b 
>   ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 
> 26a96a47f1935de8e985d382b40c8aae604a9880 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 
> 92f005d1dc837ea5ba7d8579892b6e7325940120 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java 
> c6a866a1644f087d260f78e280d07867d81cbc0c 
>   
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java
>  65508f4ddd66140a273c8c447c0ee93f4f139454 
> 
> 
> Diff: https://reviews.apache.org/r/65413/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

[jira] [Created] (HIVE-18616) work around HADOOP-15171 p2

2018-02-02 Thread Sergey Shelukhin (JIRA) 
Sergey Shelukhin created HIVE-18616:
---

 Summary: work around HADOOP-15171 p2
 Key: HIVE-18616
 URL: https://issues.apache.org/jira/browse/HIVE-18616
 Project: Hive
  Issue Type: Bug
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
 Fix For: 3.0.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: ptest seems stuck

2018-02-02 Thread Vihang Karajgaonkar 
https://builds.apache.org/job/PreCommit-HIVE-Build/

It looks like there are no executors available to run the job.

On Fri, Feb 2, 2018 at 2:15 PM, Deepak Jaiswal 
wrote:

> Hi All,
>
> It looks like ptest is stuck. Cant figure out the cause.
>
> Regards,
> Deepak
>

ptest seems stuck

2018-02-02 Thread Deepak Jaiswal 
Hi All,

It looks like ptest is stuck. Cant figure out the cause.

Regards,
Deepak

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-02 Thread Deepak Jaiswal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65130/
---

(Updated Feb. 2, 2018, 10:11 p.m.)


Review request for hive, Ashutosh Chauhan, Eugene Koifman, Gopal V, Jason Dere, 
and Thejas Nair.


Changes
---

Fixed the test failures.


Bugs: HIVE-18350
https://issues.apache.org/jira/browse/HIVE-18350


Repository: hive-git


Description
---

Made changes for both bucketed and non-bucketed tables.
Added a positive test for non-bucketed table which renames the loaded file.
Added couple of negative tests for bucketed table which reject a load with 
inconsistent file name.


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/CustomPartitionVertex.java 
26afe90faa 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/CustomVertexConfiguration.java 
ef5e7edcd6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java 9885038588 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 9b0ffe0e91 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java 
dc698c8de8 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/metainfo/annotation/OpTraitsRulesProcFactory.java
 69d9f3125a 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java
 bacc44482a 
  ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 
54f5bab6de 
  ql/src/java/org/apache/hadoop/hive/ql/plan/OpTraits.java 9621c3be53 
  ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java aa95d2fcdc 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_2.q e5fdcb57e4 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_4.q abf09e5534 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_5.q b85c4a7aa3 
  ql/src/test/queries/clientpositive/auto_sortmerge_join_7.q bd780861e3 
  ql/src/test/results/clientnegative/bucket_mapjoin_mismatch1.q.out b9c2e6f827 
  ql/src/test/results/clientpositive/auto_sortmerge_join_2.q.out 5cfc35aa73 
  ql/src/test/results/clientpositive/auto_sortmerge_join_4.q.out 0d586fd26b 
  ql/src/test/results/clientpositive/auto_sortmerge_join_5.q.out 45704d1253 
  ql/src/test/results/clientpositive/auto_sortmerge_join_7.q.out 1959075912 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_2.q.out 
054b0d00be 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_4.q.out 
95d329862c 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_5.q.out 
e711715aa5 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_7.q.out 
53c685cb11 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_2.q.out 
8cfa113794 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_4.q.out 
fce5e0cfc4 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_5.q.out 
8250eca099 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_7.q.out 
eb813c1734 
  standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h df646a7d17 
  standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 
27f8c0f2fc 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java
 f317b0393f 
  standalone-metastore/src/gen/thrift/gen-php/metastore/Types.php 6878ee1be7 
  standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 
25e9a889b2 
  standalone-metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 3a11a0582a 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
 b3d99a1da5 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MTable.java
 6c40ae8753 
  standalone-metastore/src/main/thrift/hive_metastore.thrift 93f3e53de2 
  
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
 abc400a928 


Diff: https://reviews.apache.org/r/65130/diff/9/

Changes: https://reviews.apache.org/r/65130/diff/8-9/


Testing
---


Thanks,

Deepak Jaiswal

Re: Review Request 65276: HIVE-18516

2018-02-02 Thread Deepak Jaiswal 


> On Feb. 2, 2018, 8 p.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
> > Line 3470 (original), 3484 (patched)
> > 
> >
> > Also, shouldn't it be an error if one of the input files has .gz?  This 
> > would normally mean someone manyally compressed the file which should not 
> > be the case for ORC.  Or is this checked elsewhere?
> > 
> > Silently ignoring this most likely will mask an error until someone 
> > tries to read these files

This is checked elsewhere much earlier.


> On Feb. 2, 2018, 8 p.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
> > Lines 3485 (patched)
> > 
> >
> > The logic here seems to be changed.
> > if taskid == -1, then "name" is computed but ignored which wasn't the 
> > case previously

Yes. That means it is not ACID table so we keep the existing behavior which is 
to use the fullname.
The name is only used when the file already exists which is handled right below.


- Deepak


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65276/#review196725
---


On Feb. 1, 2018, 7:10 p.m., Deepak Jaiswal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65276/
> ---
> 
> (Updated Feb. 1, 2018, 7:10 p.m.)
> 
> 
> Review request for hive, Eugene Koifman and Jason Dere.
> 
> 
> Bugs: HIVE-18516
> https://issues.apache.org/jira/browse/HIVE-18516
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> load data should rename files consistent with insert statements for ACID 
> Tables.
> Includes test change for a missed test.
> 
> 
> Diffs
> -
> 
>   itests/src/test/resources/testconfiguration.properties d86ff58840 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 3b97dac8ca 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 
> 5868d4dd56 
>   ql/src/test/org/apache/hadoop/hive/ql/TestTxnLoadData.java a9cba456ef 
>   ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveCopyFiles.java 
> c6a4a8926b 
>   ql/src/test/queries/clientnegative/load_data_into_acid.q 2ac5b561ae 
>   ql/src/test/queries/clientpositive/load_data_acid_rename.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/smb_mapjoin_7.q 4a6afb0496 
>   ql/src/test/results/clientnegative/load_data_into_acid.q.out 46b5cdd2c8 
>   ql/src/test/results/clientpositive/beeline/smb_mapjoin_7.q.out 7a6f8c53a5 
>   ql/src/test/results/clientpositive/llap/load_data_acid_rename.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientpositive/smb_mapjoin_7.q.out b71c5b87c1 
>   ql/src/test/results/clientpositive/spark/smb_mapjoin_7.q.out ac49c02913 
> 
> 
> Diff: https://reviews.apache.org/r/65276/diff/7/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Deepak Jaiswal
> 
>

Re: Review Request 65276: HIVE-18516

2018-02-02 Thread Eugene Koifman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65276/#review196725
---




ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
Line 3470 (original), 3484 (patched)


Also, shouldn't it be an error if one of the input files has .gz?  This 
would normally mean someone manyally compressed the file which should not be 
the case for ORC.  Or is this checked elsewhere?

Silently ignoring this most likely will mask an error until someone tries 
to read these files



ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
Lines 3485 (patched)


The logic here seems to be changed.
if taskid == -1, then "name" is computed but ignored which wasn't the case 
previously


- Eugene Koifman


On Feb. 1, 2018, 7:10 p.m., Deepak Jaiswal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65276/
> ---
> 
> (Updated Feb. 1, 2018, 7:10 p.m.)
> 
> 
> Review request for hive, Eugene Koifman and Jason Dere.
> 
> 
> Bugs: HIVE-18516
> https://issues.apache.org/jira/browse/HIVE-18516
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> load data should rename files consistent with insert statements for ACID 
> Tables.
> Includes test change for a missed test.
> 
> 
> Diffs
> -
> 
>   itests/src/test/resources/testconfiguration.properties d86ff58840 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 3b97dac8ca 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 
> 5868d4dd56 
>   ql/src/test/org/apache/hadoop/hive/ql/TestTxnLoadData.java a9cba456ef 
>   ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveCopyFiles.java 
> c6a4a8926b 
>   ql/src/test/queries/clientnegative/load_data_into_acid.q 2ac5b561ae 
>   ql/src/test/queries/clientpositive/load_data_acid_rename.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/smb_mapjoin_7.q 4a6afb0496 
>   ql/src/test/results/clientnegative/load_data_into_acid.q.out 46b5cdd2c8 
>   ql/src/test/results/clientpositive/beeline/smb_mapjoin_7.q.out 7a6f8c53a5 
>   ql/src/test/results/clientpositive/llap/load_data_acid_rename.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientpositive/smb_mapjoin_7.q.out b71c5b87c1 
>   ql/src/test/results/clientpositive/spark/smb_mapjoin_7.q.out ac49c02913 
> 
> 
> Diff: https://reviews.apache.org/r/65276/diff/7/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Deepak Jaiswal
> 
>

[jira] [Created] (HIVE-18615) Prevent deserializing transaction list in the materializations invalidation cache multiple times

2018-02-02 Thread Jesus Camacho Rodriguez (JIRA) 
Jesus Camacho Rodriguez created HIVE-18615:
--

 Summary: Prevent deserializing transaction list in the 
materializations invalidation cache multiple times
 Key: HIVE-18615
 URL: https://issues.apache.org/jira/browse/HIVE-18615
 Project: Hive
  Issue Type: Improvement
  Components: Materialized views
Affects Versions: 3.0.0
Reporter: Jesus Camacho Rodriguez
Assignee: Jesus Camacho Rodriguez






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (HIVE-18614) Fix sys db creation in Hive

2018-02-02 Thread Miklos Gergely (JIRA) 
Miklos Gergely created HIVE-18614:
-

 Summary: Fix sys db creation in Hive
 Key: HIVE-18614
 URL: https://issues.apache.org/jira/browse/HIVE-18614
 Project: Hive
  Issue Type: Bug
  Components: Hive
Affects Versions: 3.0.0
Reporter: Miklos Gergely
Assignee: Miklos Gergely
 Fix For: 3.0.0
 Attachments: HIVE-18614.patch

Sys db can not be created due to several server side issues.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (HIVE-18613) Extend JsonSerDe to support BINARY type

2018-02-02 Thread Jesus Camacho Rodriguez (JIRA) 
Jesus Camacho Rodriguez created HIVE-18613:
--

 Summary: Extend JsonSerDe to support BINARY type
 Key: HIVE-18613
 URL: https://issues.apache.org/jira/browse/HIVE-18613
 Project: Hive
  Issue Type: Bug
  Components: Serializers/Deserializers
Affects Versions: 3.0.0
Reporter: Jesus Camacho Rodriguez
Assignee: Jesus Camacho Rodriguez


It seems only type not supported currently, from the code:
{code}
case BINARY:
  throw new IOException("JsonSerDe does not support BINARY type");
{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Yetus JDK version

2018-02-02 Thread Adam Szita 
Hi,

I've taken a look on this, and I think the problem is that although setting
JAVA_HOME to 1.8 JDK makes maven use 1.8 java and javac, any subprocess
forked only use "java" executable which is on PATH (and not checking
JAVA_HOME value.)
And on the server that is a 1.7 JRE so I'm proposing a fix in:
https://issues.apache.org/jira/browse/HIVE-18612
This is currently being tested, once it's good to go and the change is
committed we'll also need to redeploy the hiveptest war on our precommit
server.

Thanks,
Adam

On 2 February 2018 at 07:29, Thejas Nair  wrote:

> + Peter, Adam (The Yetus experts)
>
>
> On Thu, Feb 1, 2018 at 9:49 AM, Alan Gates  wrote:
>
>> Ok, looking briefly at it, it looks like if we changed
>> testutils/…/TestScripts.java line 76 to set javaHome to 1.8 instead of 1.7
>> that we’ll be running ptest with 1.8.  I’m not familiar with ptest, but
>> I’m
>> guessing that someone would need to make this change and then re-deploy
>> ptest in our test infrastructure.  Is there anything else we need to do?
>> We clearly already have 1.8 installed on the test machines because the
>> code
>> compiles with 1.8, but I don’t know what the path is, etc.
>>
>> Alan.
>>
>> On Tue, Jan 30, 2018 at 4:58 PM, Alan Gates  wrote:
>>
>> > I put code in the latest patch for HIVE-17983 that executes one of the
>> > compiled classes as part of the maven build.  (It does this to
>> > automatically generate the config template.)  This works locally and in
>> the
>> > ptest build.  But in the Yetus tests it fails with:
>> >
>> > Exception in thread "main" java.lang.UnsupportedClassVersionError:
>> > org/apache/hadoop/hive/metastore/conf/ConfTemplatePrinter : Unsupported
>> > major.minor version 52.0
>> >
>> > This means that it is compiling with JDK 1.8 but running it with 1.7.
>> How
>> > do we switch the Yetus build so it runs maven with the correct JDK
>> version?
>> >
>> > Alan.
>> >
>>
>
>

[jira] [Created] (HIVE-18612) Build subprocesses under Yetus in Ptest use 1.7 jre instead of 1.8

2018-02-02 Thread Adam Szita (JIRA) 
Adam Szita created HIVE-18612:
-

 Summary: Build subprocesses under Yetus in Ptest use 1.7 jre 
instead of 1.8
 Key: HIVE-18612
 URL: https://issues.apache.org/jira/browse/HIVE-18612
 Project: Hive
  Issue Type: Bug
  Components: Testing Infrastructure
Reporter: Adam Szita
Assignee: Adam Szita


As per this jira comment made by Yetus maven plugins that want to use {{java}} 
executable are seeing a 1.7 java binary. In this particular case Yetus sets 
JAVA_HOME to a 1.8 JDK installation, and thus maven uses that, but any 
subsequent {{java}} executes will use the JRE which they see on PATH.

This should be fixed by adding the proper java/bin (that of JAVA_HOME setting) 
to PATH.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 65480: HIVE-18545 Add UDF to parse complex types from json

2018-02-02 Thread Zoltan Haindrich 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65480/
---

Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-18545
https://issues.apache.org/jira/browse/HIVE-18545


Repository: hive-git


Description
---

add json_read udf


Diffs
-

  
itests/hive-jmh/src/main/java/org/apache/hive/benchmark/udf/json_read/JsonReadBench.java
 PRE-CREATION 
  
itests/hive-jmh/src/main/resources/org/apache/hive/benchmark/udf/json_read/val1.json
 PRE-CREATION 
  
itests/hive-jmh/src/main/resources/org/apache/hive/benchmark/udf/json_read/val1.type
 PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 
76e85636d1ecddc720d6b6e3680194354a6e157c 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFJsonRead.java 
PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFJsonRead.java 
PRE-CREATION 
  ql/src/test/queries/clientpositive/udf_json_read.q PRE-CREATION 
  ql/src/test/results/clientpositive/show_functions.q.out 
43e4a5de393d4b23c4c0257f08c32dd650eaaadc 
  ql/src/test/results/clientpositive/udf_json_read.q.out PRE-CREATION 


Diff: https://reviews.apache.org/r/65480/diff/1/


Testing
---


Thanks,

Zoltan Haindrich

Review Request 65479: HIVE-18523 Fix summary row in case there are no inputs

2018-02-02 Thread Zoltan Haindrich 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65479/
---

Review request for hive, Ashutosh Chauhan and Prasanth_J.


Bugs: HIVE-18523
https://issues.apache.org/jira/browse/HIVE-18523


Repository: hive-git


Description
---

* ensure that mapper operators are started up - but only if empty grouping is 
present


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java 
6a0f0de2a5e84770c6446af41710d972d813c7bc 
  ql/src/java/org/apache/hadoop/hive/ql/exec/IConfigureJobConf.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 
d7b3e4b2fd3ee1a8e2795095a6c55442de2b38e0 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 
976b537033abda5d5ab8b77a7e7d6fb9c84e5a19 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecMapRunner.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecMapper.java 
150382a8d58fd4ba44e4d9b78a80173ab984e776 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HiveSplitGenerator.java 
98f4bc01c8526422348a38f8d8632e0899d695ee 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java 
45d809a1820fcb6ea5e1e5c15aee7de91a4c36c8 
  ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java 
e4dfc009d95f4302bd1fcdff2276e11bed68d2e0 
  ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 
c3b846c4d2fee8691b4952b9f6cf4dd1d8bd632f 
  ql/src/java/org/apache/hadoop/hive/ql/io/NullRowsInputFormat.java 
6a372a3f47e3ac2ae2b2e583541b3a19e5d525f3 
  ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 
f2b2fc57a03b368707968eb503139e51218008ca 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceWork.java 
ecfb118b41bfa5b7d593b7e801a37f0a7b5b0b5e 
  ql/src/test/queries/clientpositive/groupby_rollup_empty.q 
432d8c448a05f51db9ecf9940bce599dfd598a70 
  ql/src/test/results/clientpositive/groupby_rollup_empty.q.out 
7359140e29fc63eebbab42ab385187be6bfc66e1 
  ql/src/test/results/clientpositive/llap/groupby_rollup_empty.q.out 
d2b57455a3640387d8bc5f2d415a7af25eb55341 


Diff: https://reviews.apache.org/r/65479/diff/1/


Testing
---

added new testcase for union


Thanks,

Zoltan Haindrich

Re: Review Request 65415: HIVE-18571 stats issues for MM tables

2018-02-02 Thread Zoltan Haindrich 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65415/#review196696
---




ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
Lines 1947 (patched)


I think this should be in somewhere in the BasicStat related class; or this 
can't be moved there?



ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java
Line 127 (original), 127 (patched)


It seems to me that the old conditionals have done almost the same...by 
changing p.isAcid to p.isTransactional ; I don't see any difference; since if 
its being rewritten the flag will be turned on



ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java
Line 157 (original), 162 (patched)


I feel that currently the stats system is half-blind when it comes to acid 
tables...because the autogather operations are somewhat useless on them...
I was thinking about the following: removing this condition to collect 
stats even in case basic stats are off; would enable the stats to gather a 
total "rowtraffic" - which might be good enough for an estimation ; and it may 
give the join order optimization a chance to do its job better for 
acid/insert_only tables which have not been updated explicitly updated for a 
long time...

This could be probably done as a separate change (because it will probably 
rewrite every second q.out) - what do you think about it?



standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
Lines 650 (patched)


I might be missing something but I don't see why should quickstats be 
calculated differently for transactional tables...quickstats is num_files and 
total bytes on disk - these things apply to acid tables as well



standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
Lines 674 (patched)


I don't understand why



standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
Lines 676 (patched)


I totally agree...it's very inconvinient to have this in the metastore


- Zoltan Haindrich


On Jan. 31, 2018, 2:15 a.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65415/
> ---
> 
> (Updated Jan. 31, 2018, 2:15 a.m.)
> 
> 
> Review request for hive and Eugene Koifman.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> f.,v fbghdscd
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 114d455ff8 
>   
> ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/table/LoadPartitions.java
>  bad7962373 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 63bcedc000 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 
> 6c73dc54a7 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 
> 5868d4dd56 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> dbf9363d11 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/BasicStatsWork.java a4e770ce95 
>   ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsNoJobTask.java 
> 946c300750 
>   ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java b48379013d 
>   ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 78f48b169a 
>   ql/src/java/org/apache/hadoop/hive/ql/stats/fs/FSStatsAggregator.java 
> d84cf136d5 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
>  89354a2d34 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
>  ecc464418d 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
>  50f873a013 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
>  2599ab103e 
> 
> 
> Diff: https://reviews.apache.org/r/65415/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

2018-02-02 Thread cheng xu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65478/
---

Review request for hive.


Repository: hive-git


Description
---

VectorizedParquetReader throws an exception when trying to reading from a 
parquet table on which new columns are added.


Diffs
-

  
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/BaseVectorizedColumnReader.java
 907a9b8 
  
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/DefaultParquetDataColumnReader.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/ParquetDataColumnReaderFactory.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/VectorizedDummyColumnReader.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/VectorizedParquetRecordReader.java
 08ac57b 
  
ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestVectorizedColumnReader.java
 9e414dc 
  
ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestVectorizedDictionaryEncodingColumnReader.java
 3e5d831 
  
ql/src/test/org/apache/hadoop/hive/ql/io/parquet/VectorizedColumnReaderTestBase.java
 5d3ebd6 
  ql/src/test/queries/clientpositive/schema_evol_par_vec_table.q PRE-CREATION 
  ql/src/test/results/clientpositive/schema_evol_par_vec_table.q.out 
PRE-CREATION 


Diff: https://reviews.apache.org/r/65478/diff/1/


Testing
---

Newly added UT passed and qtest passed locally.


Thanks,

cheng xu

[GitHub] hive pull request #298: HIVE-18478: Avoiding creation of CM recycle file in ...

2018-02-02 Thread maheshk114 
Github user maheshk114 closed the pull request at:

https://github.com/apache/hive/pull/298


---

Re: Review Request 65431: HIVE-16605 : NOT NULL constraint enforcement

2018-02-02 Thread Ashutosh Chauhan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65431/#review196691
---




ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java
Line 781 (original), 781 (patched)


Should leave a TODO that if not null constraint is enabled on existing 
table via alter statement, we need to validate existing data which we currently 
don't.



ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java
Line 795 (original), 795 (patched)


instead : if (enable && !constraintName.equals("not null")) ?



ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
Lines 6700 (patched)


Add dest in error msg.



ql/src/test/queries/clientpositive/enforce_constraint_notnull.q
Lines 88-89 (patched)


We need -ve test for this as well where query fails because of constraint 
violation.



ql/src/test/queries/clientpositive/enforce_constraint_notnull.q
Lines 92 (patched)


We need -ve test for this as well where query fails because of constraint 
violation after enabling constraints.



ql/src/test/queries/clientpositive/enforce_constraint_notnull.q
Lines 114 (patched)


We need -ve test for this as well where query fails because of constraint 
violation.



ql/src/test/queries/clientpositive/enforce_constraint_notnull.q
Lines 148-149 (patched)


We need -ve test for this as well where query fails because of constraint 
violation.


- Ashutosh Chauhan


On Jan. 31, 2018, 8:42 a.m., Vineet Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65431/
> ---
> 
> (Updated Jan. 31, 2018, 8:42 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez.
> 
> 
> Bugs: HIVE-16605
> https://issues.apache.org/jira/browse/HIVE-16605
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> This patch introduces support for enable NOT NULL constraint enforcement for 
> following type of statements:
> 
> * INSERT INTO
> * INSERT as SELECT
> * INSERT OVERWRITE
> * UPDATE
> * MERGE
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b7d3e99e1a 
>   itests/src/test/resources/testconfiguration.properties d86ff58840 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 76e85636d1 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 63bcedc000 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 
> 372cfad866 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> dbf9363d11 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 
> 9fcde76d21 
>   ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java e3a9e62bdb 
>   
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEnforceNotNullConstraint.java
>  PRE-CREATION 
>   ql/src/test/queries/clientnegative/create_with_constraints_enable.q 
> 59ebb1e9b2 
>   ql/src/test/queries/clientnegative/create_with_constraints_enforced.q 
> 5b90c0efc9 
>   ql/src/test/queries/clientnegative/insert_into_acid_notnull.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/insert_into_notnull_constraint.q 
> PRE-CREATION 
>   ql/src/test/queries/clientnegative/insert_multi_into_notnull.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/insert_overwrite_notnull_constraint.q 
> PRE-CREATION 
>   ql/src/test/queries/clientpositive/enforce_constraint_notnull.q 
> PRE-CREATION 
>   ql/src/test/results/clientnegative/create_with_constraints_enable.q.out 
> 2b244120e9 
>   ql/src/test/results/clientnegative/create_with_constraints_enforced.q.out 
> 2b244120e9 
>   ql/src/test/results/clientnegative/insert_into_acid_notnull.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientnegative/insert_into_notnull_constraint.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientnegative/insert_multi_into_notnull.q.out 
> PRE-CREATION 
>   
> ql/src/test/results/clientnegative/insert_overwrite_notnull_constraint.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientpositive/show_functions.q.out 43e4a5de39 
> 
> 
> Diff: https://reviews.apache.org/r/65431/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>