Review Request 69058: HIVE-19647 use bitvectors in IN operators

2018-10-16 Thread Zoltan Haindrich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69058/ --- Review request for hive and Ashutosh Chauhan. Bugs: HIVE-19647

Review Request 69031: Changed default config of hive.tez.llap.min.reducer.per.executor to 0.33

2018-10-16 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69031/ --- Review request for hive. Bugs: HIVE-20572

[jira] [Created] (HIVE-20759) hive.server2.enable.doAs=false is not honored

2018-10-16 Thread Xiaoyu Yao (JIRA)
Xiaoyu Yao created HIVE-20759: - Summary: hive.server2.enable.doAs=false is not honored Key: HIVE-20759 URL: https://issues.apache.org/jira/browse/HIVE-20759 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-20758) Constraints: Show create table does not show constraints

2018-10-16 Thread Gopal V (JIRA)
Gopal V created HIVE-20758: -- Summary: Constraints: Show create table does not show constraints Key: HIVE-20758 URL: https://issues.apache.org/jira/browse/HIVE-20758 Project: Hive Issue Type: Bug

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

2018-10-16 Thread Vihang Karajgaonkar via Review Board
> On Oct. 16, 2018, 8:59 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Lines 291 (patched) > > > > > > What is someone has

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

2018-10-16 Thread Vihang Karajgaonkar via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69054/ --- (Updated Oct. 16, 2018, 10:47 p.m.) Review request for hive, Andrew Sherman,

Re: Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

2018-10-16 Thread Andrew Sherman via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69054/#review209662 --- This all looks good, I just have annoying questions

Review Request 69054: HIVE-20740 : Remove global lock in ObjectStore.setConf method

2018-10-16 Thread Vihang Karajgaonkar via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69054/ --- Review request for hive, Andrew Sherman, Alan Gates, and Peter Vary. Bugs:

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread denys kuzmenko via Review Board
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 125 (original), 120 (patched) > > > > > > we might need to re-think how

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread denys kuzmenko via Review Board
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/LocalHiveSparkClient.java > > Line 73 (original), 73 (patched) > > > > > > if we expect multiple sessions to

[jira] [Created] (HIVE-20757) Autogather stats doesn't work when SDPO (sort dynamic partition optimization) is ON

2018-10-16 Thread Vineet Garg (JIRA)
Vineet Garg created HIVE-20757: -- Summary: Autogather stats doesn't work when SDPO (sort dynamic partition optimization) is ON Key: HIVE-20757 URL: https://issues.apache.org/jira/browse/HIVE-20757

[jira] [Created] (HIVE-20756) Disable SARG leaf creation for date column until ORC-135

2018-10-16 Thread Chiran Ravani (JIRA)
Chiran Ravani created HIVE-20756: Summary: Disable SARG leaf creation for date column until ORC-135 Key: HIVE-20756 URL: https://issues.apache.org/jira/browse/HIVE-20756 Project: Hive Issue

[jira] [Created] (HIVE-20755) Add the ability to push Dynamic Between and Bloom filters to JDBC handler

2018-10-16 Thread Jesus Camacho Rodriguez (JIRA)
Jesus Camacho Rodriguez created HIVE-20755: -- Summary: Add the ability to push Dynamic Between and Bloom filters to JDBC handler Key: HIVE-20755 URL: https://issues.apache.org/jira/browse/HIVE-20755

Re: Review Request 69050: HIVE-20720: Add partition column option to JDBC handler

2018-10-16 Thread Daniel Dai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69050/ --- (Updated Oct. 16, 2018, 5:08 p.m.) Review request for hive. Repository:

Review Request 69050: HIVE-20720: Add partition column option to JDBC handler

2018-10-16 Thread Daniel Dai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69050/ --- Review request for hive. Repository: hive-git Description --- See

[jira] [Created] (HIVE-20754) JDBC: Add some missing classes to jdbc standalone jar (follow up to HIVE-19801)

2018-10-16 Thread Vaibhav Gumashta (JIRA)
Vaibhav Gumashta created HIVE-20754: --- Summary: JDBC: Add some missing classes to jdbc standalone jar (follow up to HIVE-19801) Key: HIVE-20754 URL: https://issues.apache.org/jira/browse/HIVE-20754

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread denys kuzmenko via Review Board
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 352 (original) > > > > > > why remove this? > > denys kuzmenko wrote: >

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69022/ --- (Updated Oct. 16, 2018, 4:49 p.m.) Review request for hive, Sahil Takiar and

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread denys kuzmenko via Review Board
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 352 (original) > > > > > > why remove this? > > denys kuzmenko wrote: >

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread denys kuzmenko via Review Board
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 352 (original) > > > > > > why remove this? > > denys kuzmenko wrote: >

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread denys kuzmenko via Review Board
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 352 (original) > > > > > > why remove this? > > denys kuzmenko wrote: >

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread denys kuzmenko via Review Board
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 352 (original) > > > > > > why remove this? > > denys kuzmenko wrote: >

Re: Review Request 68474: HIVE-20440

2018-10-16 Thread Sahil Takiar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68474/#review209628 --- Could we add some more E2E integration tests? I'm thinking they

Re: Review Request 68474: HIVE-20440

2018-10-16 Thread Sahil Takiar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68474/#review209626 ---

[jira] [Created] (HIVE-20753) Derby thread interrupt during ptest

2018-10-16 Thread Zoltan Haindrich (JIRA)
Zoltan Haindrich created HIVE-20753: --- Summary: Derby thread interrupt during ptest Key: HIVE-20753 URL: https://issues.apache.org/jira/browse/HIVE-20753 Project: Hive Issue Type: Bug

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread Sahil Takiar
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/LocalHiveSparkClient.java > > Line 73 (original), 73 (patched) > > > > > > if we expect multiple sessions to

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread denys kuzmenko via Review Board
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Lines 112-116 (original) > > > > > > do we have unit tests that cover this? >

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread denys kuzmenko via Review Board
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Lines 112-116 (original) > > > > > > do we have unit tests that cover this? >

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread denys kuzmenko via Review Board
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/LocalHiveSparkClient.java > > Line 73 (original), 73 (patched) > > > > > > if we expect multiple sessions to

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread Sahil Takiar
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 125 (original), 120 (patched) > > > > > > we might need to re-think how

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread Sahil Takiar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69022/#review209617 ---

[jira] [Created] (HIVE-20752) In case of LLAP start failure add info how to find YARN logs

2018-10-16 Thread Miklos Gergely (JIRA)
Miklos Gergely created HIVE-20752: - Summary: In case of LLAP start failure add info how to find YARN logs Key: HIVE-20752 URL: https://issues.apache.org/jira/browse/HIVE-20752 Project: Hive

[jira] [Created] (HIVE-20751) Upgrade arrow version to 0.10.0

2018-10-16 Thread Shubham Chaurasia (JIRA)
Shubham Chaurasia created HIVE-20751: Summary: Upgrade arrow version to 0.10.0 Key: HIVE-20751 URL: https://issues.apache.org/jira/browse/HIVE-20751 Project: Hive Issue Type: Bug

[GitHub] hive pull request #447: HIVE-20708: Load an external table as an external ta...

2018-10-16 Thread ashutosh-bapat
GitHub user ashutosh-bapat opened a pull request: https://github.com/apache/hive/pull/447 HIVE-20708: Load an external table as an external table on target with the same location as on the source Dump an external table as an external table. When loading an external table

Re: Review Request 68946: HIVE-20707: Automatic MSCK REPAIR for external tables

2018-10-16 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68946/ --- (Updated Oct. 16, 2018, 7:02 a.m.) Review request for hive, Ashutosh Chauhan

Re: Review Request 68946: HIVE-20707: Automatic MSCK REPAIR for external tables

2018-10-16 Thread j . prasanth . j
> On Oct. 16, 2018, 2:28 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java > > Lines 4761 (patched) > > > > > > Should this be on by default? If there are a lot of external tables