> On Oct. 16, 2018, 8:59 p.m., Andrew Sherman wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Lines 291 (patched) > > <https://reviews.apache.org/r/69054/diff/1/?file=2098724#file2098724line291> > > > > What is someone has set ConfVars.MANAGER_FACTORY_CLASS to some > > non-default value? Is this still correct?
Yes, looks like it will fail in that case although I am not sure the use-cases where you will use a different PersistenceManagerFactory. This code has been there since before the patch and has not been changed in this patch. Perhaps we can look at this as a separate JIRA. - Vihang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69054/#review209662 ----------------------------------------------------------- On Oct. 16, 2018, 10:47 p.m., Vihang Karajgaonkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69054/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2018, 10:47 p.m.) > > > Review request for hive, Andrew Sherman, Alan Gates, and Peter Vary. > > > Bugs: HIVE-20740 > https://issues.apache.org/jira/browse/HIVE-20740 > > > Repository: hive-git > > > Description > ------- > > HIVE-20740 : Remove global lock in ObjectStore.setConf method > > > Diffs > ----- > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 66977d79c946f1ac57aacfbe8704d37bfbac3ea3 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java > b74c3048fa2e18adc7f0d7cc813a180d4466fa36 > > > Diff: https://reviews.apache.org/r/69054/diff/2/ > > > Testing > ------- > > > Thanks, > > Vihang Karajgaonkar > >
