Re: Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

2020-04-22 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72387/#review220426 --- Ship it!

Re: Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

2020-04-22 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72387/ --- (Updated April 22, 2020, 3:27 p.m.) Review request for hive, Marton Bod and

Re: Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

2020-04-22 Thread Denys Kuzmenko via Review Board
> On April 22, 2020, 3:22 p.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/ValidTxnManager.java > > Line 113 (original), 112 (patched) > > > > > > Isn't reference level check is risky here? good

[jira] [Created] (HIVE-23273) Add fix order to cbo_limit.q queries + improve readability

2020-04-22 Thread Miklos Gergely (Jira)
Miklos Gergely created HIVE-23273: - Summary: Add fix order to cbo_limit.q queries + improve readability Key: HIVE-23273 URL: https://issues.apache.org/jira/browse/HIVE-23273 Project: Hive

[jira] [Created] (HIVE-23275) Represent UNBOUNDED in window functions in CBO correctly

2020-04-22 Thread Jesus Camacho Rodriguez (Jira)
Jesus Camacho Rodriguez created HIVE-23275: -- Summary: Represent UNBOUNDED in window functions in CBO correctly Key: HIVE-23275 URL: https://issues.apache.org/jira/browse/HIVE-23275 Project:

[jira] [Created] (HIVE-23276) remove HttpException NPE possibility

2020-04-22 Thread Eugene Chung (Jira)
Eugene Chung created HIVE-23276: --- Summary: remove HttpException NPE possibility Key: HIVE-23276 URL: https://issues.apache.org/jira/browse/HIVE-23276 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-23268) Eliminate beanutils transitive dependency

2020-04-22 Thread Ashutosh Chauhan (Jira)
Ashutosh Chauhan created HIVE-23268: --- Summary: Eliminate beanutils transitive dependency Key: HIVE-23268 URL: https://issues.apache.org/jira/browse/HIVE-23268 Project: Hive Issue Type:

[jira] [Created] (HIVE-23269) Unsafe compares bigints and chars

2020-04-22 Thread Zhihua Deng (Jira)
Zhihua Deng created HIVE-23269: -- Summary: Unsafe compares bigints and chars Key: HIVE-23269 URL: https://issues.apache.org/jira/browse/HIVE-23269 Project: Hive Issue Type: Improvement

Re: Review Request 72378: HIVE-23201: Improve logging in locking

2020-04-22 Thread Marton Bod
> On April 21, 2020, 10:38 a.m., Denys Kuzmenko wrote: > > LGTM, just number of comments Thanks for the review Denys! As per your comments, I have elevated the log levels, removed the less useful log lines and changed the original statements to prepared statements. - Marton

Re: Review Request 72378: HIVE-23201: Improve logging in locking

2020-04-22 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72378/#review220419 --- Looks good, however I don't really like change with

[jira] [Created] (HIVE-23277) HiveProtoLogger should carry out JSON conversion in its own thread

2020-04-22 Thread Rajesh Balamohan (Jira)
Rajesh Balamohan created HIVE-23277: --- Summary: HiveProtoLogger should carry out JSON conversion in its own thread Key: HIVE-23277 URL: https://issues.apache.org/jira/browse/HIVE-23277 Project: Hive

Re: Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

2020-04-22 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72387/ --- (Updated April 22, 2020, 2:29 p.m.) Review request for hive, Marton Bod and

[jira] [Created] (HIVE-23270) Optimize isValidTxnListState to reduce the numbers of HMS calls

2020-04-22 Thread Peter Vary (Jira)
Peter Vary created HIVE-23270: - Summary: Optimize isValidTxnListState to reduce the numbers of HMS calls Key: HIVE-23270 URL: https://issues.apache.org/jira/browse/HIVE-23270 Project: Hive

[jira] [Created] (HIVE-23271) Can't start Hive Interactive Server in HDP 3.1.4 Cluster

2020-04-22 Thread Jira
Gerardo Adrián Aguirre Vivar created HIVE-23271: --- Summary: Can't start Hive Interactive Server in HDP 3.1.4 Cluster Key: HIVE-23271 URL: https://issues.apache.org/jira/browse/HIVE-23271

[jira] [Created] (HIVE-23272) Fix and reenable timestamptz_2.q

2020-04-22 Thread Peter Vary (Jira)
Peter Vary created HIVE-23272: - Summary: Fix and reenable timestamptz_2.q Key: HIVE-23272 URL: https://issues.apache.org/jira/browse/HIVE-23272 Project: Hive Issue Type: Test

Review Request 72417: Move q tests to TestMiniLlapLocal from TestCliDriver where the output is different, batch 1

2020-04-22 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72417/ --- Review request for hive. Bugs: HIVE-23274

[jira] [Created] (HIVE-23274) Move q tests to TestMiniLlapLocal from TestCliDriver where the output is different, batch 1

2020-04-22 Thread Miklos Gergely (Jira)
Miklos Gergely created HIVE-23274: - Summary: Move q tests to TestMiniLlapLocal from TestCliDriver where the output is different, batch 1 Key: HIVE-23274 URL: https://issues.apache.org/jira/browse/HIVE-23274

Review Request 72420: Move q tests to TestMiniLlapLocal from TestCliDriver where the output is different, batch 1

2020-04-22 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72420/ --- Review request for hive. Bugs: HIVE-23274

Re: Review Request 72420: Move q tests to TestMiniLlapLocal from TestCliDriver where the output is different, batch 1

2020-04-22 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72420/ --- (Updated April 22, 2020, 8:22 p.m.) Review request for hive. Bugs:

Re: Review Request 72417: Move q tests to TestMiniLlapLocal from TestCliDriver where the output is different, batch 1

2020-04-22 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72417/ --- (Updated April 22, 2020, 8:22 p.m.) Review request for hive. Bugs:

Review Request 72421: Move q tests to TestMiniLlapLocal from TestCliDriver where the output is different, batch 1

2020-04-22 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72421/ --- Review request for hive. Bugs: HIVE-23274

Re: Hive Grammar Parser Visualization

2020-04-22 Thread Driesprong, Fokko
Thanks for sharing David, It looks great. I think this would give great insights into how Hive parses queries. Cheers, Fokko Op do 16 apr. 2020 om 16:49 schreef David Mollitor : > Hello Gang, > > https://issues.apache.org/jira/browse/HIVE-23171 > > I just wanted to share with you a tool that I