Re: [VOTE] Apache Hive 4.0.0-alpha-2 Release Candidate 0

2022-10-28 Thread Denys Kuzmenko
Extending voting for 24hr. 1 more +1 is needed from the PMC to promote the release. If not given, I'll be closing this vote as unsuccessful. On Thu, Oct 27, 2022 at 11:16 PM Chris Nauroth wrote: > +1 (non-binding) > > * Verified all checksums. > * Verified all signatures. > * Built from source.

Updating Wiki about Hikari Configuration Properties

2022-10-28 Thread Chris Nauroth
Hi everyone, Regarding this page: https://cwiki.apache.org/confluence/display/hive/configuration+properties#ConfigurationProperties-HiveMetastoreConnectionPoolingConfiguration It states that the metastore's Hikari connection pool can be configured by specifying properties prefixed as "hikari".

Re: [VOTE] Apache Hive 4.0.0-alpha-2 Release Candidate 0

2022-10-28 Thread Denys Kuzmenko
Hi Stamatis, My bad, sorry. Removed the ".imp" files and updated the release artifacts.* *** NO CODE CHANGES I was following the alpha-1 release and the NOTICE wasn't updated there as well. I don't think that should be a blocker. Noted that + javadoc artifacts for the new RC.

Re: [VOTE] Apache Hive 4.0.0-alpha-2 Release Candidate 0

2022-10-28 Thread Stamatis Zampetakis
I think that having a proper NOTICE file in jars is important to comply with the ASF release policy: * https://www.apache.org/legal/release-policy.html#licensing-documentation * https://www.apache.org/legal/src-headers.html#notice * https://www.apache.org/legal/src-headers.html#faq-binaries The

Re: [VOTE] Apache Hive 4.0.0-alpha-2 Release Candidate 0

2022-10-28 Thread Stamatis Zampetakis
-1 (non-binding) Ubuntu 20.04.5 LTS, java version "1.8.0_261", Apache Maven 3.6.3 * Verified signatures and checksums OK * Checked diff between git repo and release sources (diff -qr hive-git hive-src) KO (among other *.iml files present in release sources but not in git) * Checked LICENSE,

Re: Updating Wiki about Hikari Configuration Properties

2022-10-28 Thread Denys Kuzmenko
Hi Chris, Please try now On Fri, Oct 28, 2022 at 12:43 PM Stamatis Zampetakis wrote: > Hive PMC members can provide edit rights to the wiki. > > @Naveen, Dennys, Adam: Can someone please give write privileges to Chris? > > Best, > Stamatis > > On Fri, Oct 28, 2022 at 8:41 AM Chris Nauroth

Re: [VOTE] Apache Hive 4.0.0-alpha-2 Release Candidate 0

2022-10-28 Thread Ayush Saxena
+1 (non-binding) * Built from source. * Verified Checksums. * Verified Signatures * Ran some basic unit tests. * Ran some basic ACID & Iceberg related queries with Tez. * Skimmed through the Maven Artifacts, Looks Good. Thanx Denys for driving the release. Good Luck!!! -Ayush On Fri, 28 Oct

Re: Updating Wiki about Hikari Configuration Properties

2022-10-28 Thread Stamatis Zampetakis
Hive PMC members can provide edit rights to the wiki. @Naveen, Dennys, Adam: Can someone please give write privileges to Chris? Best, Stamatis On Fri, Oct 28, 2022 at 8:41 AM Chris Nauroth wrote: > Hi everyone, > > Regarding this page: > > >

Re: Updating Wiki about Hikari Configuration Properties

2022-10-28 Thread Ayush Saxena
Hi Chris, Just curious: > > BTW, the reason I discovered this is that I recently upgraded a cluster > from Hive 2.x (default BoneCP) to Hive 3.x (default HikariCP). As you said the prefix change happened in HIVE-17317 which is in 4.0.0-alpha-1 [1] and you migrated to Hive 3.x, Then how did you

[jira] [Created] (HIVE-26676) Count distinct in subquery returning wrong results

2022-10-28 Thread Steve Carlin (Jira)
Steve Carlin created HIVE-26676: --- Summary: Count distinct in subquery returning wrong results Key: HIVE-26676 URL: https://issues.apache.org/jira/browse/HIVE-26676 Project: Hive Issue Type:

Re: Updating Wiki about Hikari Configuration Properties

2022-10-28 Thread Chris Nauroth
Thank you, Denys. Unfortunately, I still don't see the Edit button like I do on other projects where I have access (Hadoop, Zookeeper). I just realized my Confluence login is actually just "cnauroth", so maybe I caused some confusion by stating it as "cnaur...@apache.org"? Ayush, to further