[jira] [Created] (HIVE-2160) Few code improvements in the metastore,hwi and ql packages.

2011-05-12 Thread Chinna Rao Lalam (JIRA)
Few code improvements in the metastore,hwi and ql packages.
---

 Key: HIVE-2160
 URL: https://issues.apache.org/jira/browse/HIVE-2160
 Project: Hive
  Issue Type: Bug
  Components: Metastore, Query Processor, Web UI
Affects Versions: 0.8.0
 Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 
10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5).
Reporter: Chinna Rao Lalam
Assignee: Chinna Rao Lalam


Few code improvements in the metastore,hwi and ql packages.
1) Little performance Improvements 
2) Effective varaible management.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Hive partioning

2011-05-12 Thread Pulkit Agrawal
Hi ,

 

Can you please explain what is partitioning in hive?

 

I am newbie for hive.

 

Thanks in advance.

 

Regards,

Pulkit Agrawal



[jira] [Updated] (HIVE-2096) throw a error if the input is larger than a threshold for index input format

2011-05-12 Thread Wojciech Galuba (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wojciech Galuba updated HIVE-2096:
--

Attachment: HIVE-2096.2.patch.txt

Adds the two options to HiveConf and hive-default.xml. Negative unit tests now 
work correctly.

 throw a error if the input is larger than a threshold for index input format
 

 Key: HIVE-2096
 URL: https://issues.apache.org/jira/browse/HIVE-2096
 Project: Hive
  Issue Type: Bug
Affects Versions: 0.8.0
Reporter: Namit Jain
 Attachments: HIVE-2096.1.patch.txt, HIVE-2096.2.patch.txt


 This can hang for ever.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-2096) throw a error if the input is larger than a threshold for index input format

2011-05-12 Thread Wojciech Galuba (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wojciech Galuba updated HIVE-2096:
--

Status: Patch Available  (was: Open)

 throw a error if the input is larger than a threshold for index input format
 

 Key: HIVE-2096
 URL: https://issues.apache.org/jira/browse/HIVE-2096
 Project: Hive
  Issue Type: Bug
Affects Versions: 0.8.0
Reporter: Namit Jain
 Attachments: HIVE-2096.1.patch.txt, HIVE-2096.2.patch.txt


 This can hang for ever.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-2147) Add api to send / receive message to metastore

2011-05-12 Thread Ashutosh Chauhan (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13032573#comment-13032573
 ] 

Ashutosh Chauhan commented on HIVE-2147:


@Carl, Looks like RB is not coming back up. I am not sure if I am the only one 
not able to create new review request. Don't know with whom to followup for it? 
In the meantime, Carl if you have comments can you please post them here.

 Add api to send / receive message to metastore
 --

 Key: HIVE-2147
 URL: https://issues.apache.org/jira/browse/HIVE-2147
 Project: Hive
  Issue Type: Improvement
  Components: Metastore
Reporter: Ashutosh Chauhan
Assignee: Ashutosh Chauhan
 Fix For: 0.8.0

 Attachments: api-without-thrift.patch


 This is follow-up work on HIVE-2038.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-2157) NPE in MapJoinObjectKey

2011-05-12 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13032615#comment-13032615
 ] 

Hudson commented on HIVE-2157:
--

Integrated in Hive-trunk-h0.20 #726 (See 
[https://builds.apache.org/hudson/job/Hive-trunk-h0.20/726/])


 NPE in MapJoinObjectKey
 ---

 Key: HIVE-2157
 URL: https://issues.apache.org/jira/browse/HIVE-2157
 Project: Hive
  Issue Type: Bug
Reporter: He Yongqiang
Assignee: He Yongqiang
 Attachments: HIVE-2157.1.patch




--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-2151) Too many open files in running negative cli tests

2011-05-12 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13032616#comment-13032616
 ] 

Hudson commented on HIVE-2151:
--

Integrated in Hive-trunk-h0.20 #726 (See 
[https://builds.apache.org/hudson/job/Hive-trunk-h0.20/726/])


 Too many open files in running negative cli tests
 -

 Key: HIVE-2151
 URL: https://issues.apache.org/jira/browse/HIVE-2151
 Project: Hive
  Issue Type: Bug
  Components: CLI, Testing Infrastructure
Reporter: He Yongqiang
Assignee: He Yongqiang
 Fix For: 0.8.0

 Attachments: HIVE-2151.1.patch, HIVE-2151.2.patch, HIVE-2151.3.patch, 
 HIVE-2151.4.patch




--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-2153) Stats JDBC LIKE queries should escape '_' and '%'

2011-05-12 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13032617#comment-13032617
 ] 

Hudson commented on HIVE-2153:
--

Integrated in Hive-trunk-h0.20 #726 (See 
[https://builds.apache.org/hudson/job/Hive-trunk-h0.20/726/])


 Stats JDBC LIKE queries should escape '_' and '%'
 -

 Key: HIVE-2153
 URL: https://issues.apache.org/jira/browse/HIVE-2153
 Project: Hive
  Issue Type: Bug
Reporter: Ning Zhang
Assignee: Ning Zhang
 Fix For: 0.8.0

 Attachments: HIVE-2153.2.patch, HIVE-2153.patch


 DELETE /* Hive stats aggregation: 
 org.apache.hadoop.hive.ql.stats.jdbc.JDBCStatsAggregator */ FROM 
 PARTITION_STAT_TBL WHERE ID LIKE 
 'hdfs://dfsnode:9000/tmp/hive-root/hive_2011-05-09_04-30-28_586_4184342157898880918/-ext-1/ds=2011-05-08/table_name=dim_page_to_user_suggest_assoc/%'
 It is a prefix query but the '_' in the ID column should be escaped. The same 
 applies to '%' if they appear in ID. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-1095) Hive in Maven

2011-05-12 Thread Carl Steinbach (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13032618#comment-13032618
 ] 

Carl Steinbach commented on HIVE-1095:
--

@Amareshwari: I looked at the patch and noticed a couple things that should be 
fixed (e.g. there's already a copy of the ASF license in LICENSE, so no need 
to add LICENSE-2.0.txt). If you post the patch to reviewboard I will add 
comments, or I can do the updates myself in the next couple of days.

 Hive in Maven
 -

 Key: HIVE-1095
 URL: https://issues.apache.org/jira/browse/HIVE-1095
 Project: Hive
  Issue Type: Task
  Components: Build Infrastructure
Affects Versions: 0.6.0
Reporter: Gerrit Jansen van Vuuren
Priority: Minor
 Fix For: 0.7.1

 Attachments: HIVE-1095-trunk.patch, HIVE-1095.v2.PATCH, 
 HIVE-1095.v3.PATCH, HIVE-1095.v4.PATCH, HIVE-1095.v5.PATCH, 
 HIVE-1095.v6.patch, hiveReleasedToMaven.tar.gz, make-maven.log


 Getting hive into maven main repositories
 Documentation on how to do this is on:
 http://maven.apache.org/guides/mini/guide-central-repository-upload.html

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-1937) DDLSemanticAnalyzer won't take newly set Hive parameters

2011-05-12 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13032614#comment-13032614
 ] 

Hudson commented on HIVE-1937:
--

Integrated in Hive-trunk-h0.20 #726 (See 
[https://builds.apache.org/hudson/job/Hive-trunk-h0.20/726/])


 DDLSemanticAnalyzer won't take newly set Hive parameters
 

 Key: HIVE-1937
 URL: https://issues.apache.org/jira/browse/HIVE-1937
 Project: Hive
  Issue Type: Bug
Reporter: Ning Zhang
Assignee: Ning Zhang
 Attachments: HIVE-1937.2.patch, HIVE-1937.3.patch, HIVE-1937.patch


 Hive DDLSemanticAnalyzer maintains a static reservedPartitionValue set whose 
 values come from several Hive parameters. However even if these parameters 
 are set to new values, the reservedPartitionValue are not changed. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Review Request: HIVE-2147: Add api to send / receive message to metastore

2011-05-12 Thread Carl Steinbach

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/737/
---

Review request for hive.


Summary
---

Posted for Ashutosh: 
https://issues.apache.org/jira/secure/attachment/12478073/api-without-thrift.patch


This addresses bug HIVE-2147.
https://issues.apache.org/jira/browse/HIVE-2147


Diffs
-

  metastore/if/hive_metastore.thrift 6be3f93 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
1247887 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
5562ffc 
  metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
2ce02bb 
  
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java 
75e01ec 
  metastore/src/java/org/apache/hadoop/hive/metastore/events/MessageEvent.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/737/diff


Testing
---


Thanks,

Carl



Re: Review Request: HIVE-2147: Add api to send / receive message to metastore

2011-05-12 Thread Carl Steinbach

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/737/#review666
---



metastore/src/java/org/apache/hadoop/hive/metastore/events/MessageEvent.java
https://reviews.apache.org/r/737/#comment1328

Missing ASF license.


- Carl


On 2011-05-12 19:56:03, Carl Steinbach wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/737/
 ---
 
 (Updated 2011-05-12 19:56:03)
 
 
 Review request for hive.
 
 
 Summary
 ---
 
 Posted for Ashutosh: 
 https://issues.apache.org/jira/secure/attachment/12478073/api-without-thrift.patch
 
 
 This addresses bug HIVE-2147.
 https://issues.apache.org/jira/browse/HIVE-2147
 
 
 Diffs
 -
 
   metastore/if/hive_metastore.thrift 6be3f93 
   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
 1247887 
   
 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
 5562ffc 
   metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
 2ce02bb 
   
 metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java
  75e01ec 
   
 metastore/src/java/org/apache/hadoop/hive/metastore/events/MessageEvent.java 
 PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/737/diff
 
 
 Testing
 ---
 
 
 Thanks,
 
 Carl
 




[jira] [Commented] (HIVE-2147) Add api to send / receive message to metastore

2011-05-12 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13032624#comment-13032624
 ] 

jirapos...@reviews.apache.org commented on HIVE-2147:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/737/
---

Review request for hive.


Summary
---

Posted for Ashutosh: 
https://issues.apache.org/jira/secure/attachment/12478073/api-without-thrift.patch


This addresses bug HIVE-2147.
https://issues.apache.org/jira/browse/HIVE-2147


Diffs
-

  metastore/if/hive_metastore.thrift 6be3f93 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
1247887 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
5562ffc 
  metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
2ce02bb 
  
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java 
75e01ec 
  metastore/src/java/org/apache/hadoop/hive/metastore/events/MessageEvent.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/737/diff


Testing
---


Thanks,

Carl



 Add api to send / receive message to metastore
 --

 Key: HIVE-2147
 URL: https://issues.apache.org/jira/browse/HIVE-2147
 Project: Hive
  Issue Type: Improvement
  Components: Metastore
Reporter: Ashutosh Chauhan
Assignee: Ashutosh Chauhan
 Fix For: 0.8.0

 Attachments: api-without-thrift.patch


 This is follow-up work on HIVE-2038.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-2147) Add api to send / receive message to metastore

2011-05-12 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13032628#comment-13032628
 ] 

jirapos...@reviews.apache.org commented on HIVE-2147:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/737/#review666
---



metastore/src/java/org/apache/hadoop/hive/metastore/events/MessageEvent.java
https://reviews.apache.org/r/737/#comment1328

Missing ASF license.


- Carl


On 2011-05-12 19:56:03, Carl Steinbach wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/737/
bq.  ---
bq.  
bq.  (Updated 2011-05-12 19:56:03)
bq.  
bq.  
bq.  Review request for hive.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  Posted for Ashutosh: 
https://issues.apache.org/jira/secure/attachment/12478073/api-without-thrift.patch
bq.  
bq.  
bq.  This addresses bug HIVE-2147.
bq.  https://issues.apache.org/jira/browse/HIVE-2147
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.metastore/if/hive_metastore.thrift 6be3f93 
bq.metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
1247887 
bq.
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
5562ffc 
bq.
metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
2ce02bb 
bq.
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java 
75e01ec 
bq.
metastore/src/java/org/apache/hadoop/hive/metastore/events/MessageEvent.java 
PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/737/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Carl
bq.  
bq.



 Add api to send / receive message to metastore
 --

 Key: HIVE-2147
 URL: https://issues.apache.org/jira/browse/HIVE-2147
 Project: Hive
  Issue Type: Improvement
  Components: Metastore
Reporter: Ashutosh Chauhan
Assignee: Ashutosh Chauhan
 Fix For: 0.8.0

 Attachments: api-without-thrift.patch


 This is follow-up work on HIVE-2038.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HIVE-2161) Remaining patch for HIVE-2148

2011-05-12 Thread Ashutosh Chauhan (JIRA)
Remaining patch for HIVE-2148
-

 Key: HIVE-2161
 URL: https://issues.apache.org/jira/browse/HIVE-2161
 Project: Hive
  Issue Type: Task
Reporter: Ashutosh Chauhan
Assignee: Ashutosh Chauhan
 Fix For: 0.8.0


Follow-up jira for HIVE-2148.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-2161) Remaining patch for HIVE-2148

2011-05-12 Thread Ashutosh Chauhan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Chauhan updated HIVE-2161:
---

Attachment: hive_2161.patch

Same patch as on hive-2148.

 Remaining patch for HIVE-2148
 -

 Key: HIVE-2161
 URL: https://issues.apache.org/jira/browse/HIVE-2161
 Project: Hive
  Issue Type: Task
Reporter: Ashutosh Chauhan
Assignee: Ashutosh Chauhan
 Fix For: 0.8.0

 Attachments: hive_2161.patch


 Follow-up jira for HIVE-2148.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-2161) Remaining patch for HIVE-2148

2011-05-12 Thread Ashutosh Chauhan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Chauhan updated HIVE-2161:
---

Status: Patch Available  (was: Open)

 Remaining patch for HIVE-2148
 -

 Key: HIVE-2161
 URL: https://issues.apache.org/jira/browse/HIVE-2161
 Project: Hive
  Issue Type: Task
Reporter: Ashutosh Chauhan
Assignee: Ashutosh Chauhan
 Fix For: 0.8.0

 Attachments: hive_2161.patch


 Follow-up jira for HIVE-2148.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (HIVE-2162) Upgrade dependencies to Hadoop 0.20.2 and 0.20.203.0

2011-05-12 Thread Owen O'Malley (JIRA)
Upgrade dependencies to Hadoop 0.20.2 and 0.20.203.0


 Key: HIVE-2162
 URL: https://issues.apache.org/jira/browse/HIVE-2162
 Project: Hive
  Issue Type: Improvement
Reporter: Owen O'Malley


Hadoop has released 0.20.203.0 and we should upgrade Hive's dependency to it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-2162) Upgrade dependencies to Hadoop 0.20.2 and 0.20.203.0

2011-05-12 Thread Todd Lipcon (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13032658#comment-13032658
 ] 

Todd Lipcon commented on HIVE-2162:
---

Are you suggesting that we no longer support 0.20.2? Or that the secure-Hadoop 
dependency be on 0.20.203?

 Upgrade dependencies to Hadoop 0.20.2 and 0.20.203.0
 

 Key: HIVE-2162
 URL: https://issues.apache.org/jira/browse/HIVE-2162
 Project: Hive
  Issue Type: Improvement
Reporter: Owen O'Malley

 Hadoop has released 0.20.203.0 and we should upgrade Hive's dependency to it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-2162) Upgrade dependencies to Hadoop 0.20.2 and 0.20.203.0

2011-05-12 Thread Owen O'Malley (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13032660#comment-13032660
 ] 

Owen O'Malley commented on HIVE-2162:
-

I'm suggesting that we upgrade from cdh3 to hadoop 0.20.203.0. At the same 
time, we should probably upgrade from 0.20.1 to 0.20.2.

 Upgrade dependencies to Hadoop 0.20.2 and 0.20.203.0
 

 Key: HIVE-2162
 URL: https://issues.apache.org/jira/browse/HIVE-2162
 Project: Hive
  Issue Type: Improvement
Reporter: Owen O'Malley

 Hadoop has released 0.20.203.0 and we should upgrade Hive's dependency to it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-2162) Upgrade dependencies to Hadoop 0.20.2 and 0.20.203.0

2011-05-12 Thread Todd Lipcon (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13032662#comment-13032662
 ] 

Todd Lipcon commented on HIVE-2162:
---

Gotcha. Makes sense.

 Upgrade dependencies to Hadoop 0.20.2 and 0.20.203.0
 

 Key: HIVE-2162
 URL: https://issues.apache.org/jira/browse/HIVE-2162
 Project: Hive
  Issue Type: Improvement
Reporter: Owen O'Malley

 Hadoop has released 0.20.203.0 and we should upgrade Hive's dependency to it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Review Request: HIVE-2147 : Add api to send / receive message to metastore

2011-05-12 Thread Ashutosh Chauhan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/738/
---

Review request for hive and Carl Steinbach.


Summary
---

Updated patch to include missing ASF license and generated thrift code.


This addresses bug HIVE-2147.
https://issues.apache.org/jira/browse/HIVE-2147


Diffs
-

  trunk/metastore/if/hive_metastore.thrift 1102450 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1102450 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1102450 
  
trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 
1102450 
  
trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
 1102450 
  trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 
1102450 
  
trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 
1102450 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 
1102450 
  trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1102450 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
1102450 
  
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
 1102450 
  
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
1102450 
  
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java
 1102450 
  
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/MessageEvent.java
 PRE-CREATION 
  trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java 
1102450 
  
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
 1102450 

Diff: https://reviews.apache.org/r/738/diff


Testing
---

Updated TestMetaStoreEventListener to test new api.


Thanks,

Ashutosh



[jira] [Commented] (HIVE-2147) Add api to send / receive message to metastore

2011-05-12 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13032677#comment-13032677
 ] 

jirapos...@reviews.apache.org commented on HIVE-2147:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/738/
---

Review request for hive and Carl Steinbach.


Summary
---

Updated patch to include missing ASF license and generated thrift code.


This addresses bug HIVE-2147.
https://issues.apache.org/jira/browse/HIVE-2147


Diffs
-

  trunk/metastore/if/hive_metastore.thrift 1102450 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1102450 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1102450 
  
trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 
1102450 
  
trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
 1102450 
  trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 
1102450 
  
trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 
1102450 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 
1102450 
  trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1102450 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
1102450 
  
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
 1102450 
  
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
1102450 
  
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java
 1102450 
  
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/MessageEvent.java
 PRE-CREATION 
  trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java 
1102450 
  
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
 1102450 

Diff: https://reviews.apache.org/r/738/diff


Testing
---

Updated TestMetaStoreEventListener to test new api.


Thanks,

Ashutosh



 Add api to send / receive message to metastore
 --

 Key: HIVE-2147
 URL: https://issues.apache.org/jira/browse/HIVE-2147
 Project: Hive
  Issue Type: Improvement
  Components: Metastore
Reporter: Ashutosh Chauhan
Assignee: Ashutosh Chauhan
 Fix For: 0.8.0

 Attachments: api-without-thrift.patch


 This is follow-up work on HIVE-2038.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-2162) Upgrade dependencies to Hadoop 0.20.2 and 0.20.203.0

2011-05-12 Thread John Sichi (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13032703#comment-13032703
 ] 

John Sichi commented on HIVE-2162:
--

I'll look into getting the tarballs into 
http://mirror.facebook.net/facebook/hive-deps

 Upgrade dependencies to Hadoop 0.20.2 and 0.20.203.0
 

 Key: HIVE-2162
 URL: https://issues.apache.org/jira/browse/HIVE-2162
 Project: Hive
  Issue Type: Improvement
Reporter: Owen O'Malley

 Hadoop has released 0.20.203.0 and we should upgrade Hive's dependency to it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-2155) Improve error messages emitted during semantic analysis

2011-05-12 Thread Syed S. Albiz (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Syed S. Albiz updated HIVE-2155:


Attachment: HIVE-2155.3.patch

Instead of changing the overall structure, I decided to move the logic to print 
that context token into the new generateErrorMessage method, which prevents 
breaking existing error messages which rely on that behavior of an error token 
finishing the message.

 Improve error messages emitted during semantic analysis
 ---

 Key: HIVE-2155
 URL: https://issues.apache.org/jira/browse/HIVE-2155
 Project: Hive
  Issue Type: Improvement
Reporter: Syed S. Albiz
Assignee: Syed S. Albiz
 Attachments: HIVE-2155.1.patch, HIVE-2155.2.patch, HIVE-2155.3.patch


 Follow-up to HIVE-1731.
 A number of issues raised in HIVE-1731 were caused by SemanticAnalyzer not 
 reporting errors correctly.
 Specifically, the following issues need to be addressed:
 - Line numbers are not always provided and sometimes emitted as (0:-1), which 
 is useless
 - Insufficient or unclear context strings are provided
 Specific issues described in HIVE-1731:
 FAILED: Error in semantic analysis: Schema of both sides of union should 
 match: destinationid:_col1 _col2
 * No line/col numbers, context strings provide internal aliases instead of 
 actual column names
 FAILED: Error in semantic analysis: line 0:-1 Both Left and Right Aliases 
 Encountered in Join time
 * Incorrect line/col number info, no context strings to describe the aliases 
 encountered
 FAILED: Error in semantic analysis: AS clause has an invalid number of aliases
 * No line/col numbers, not context string to show the aliases encountered
 FAILED: Error in semantic analysis: line 1:94 Expression Not In Group By Key a
 * testcase: SELECT a.id, VAR(a.cnt) FROM mytable a
 * Context string is unhelpful, needs to provide the actual expression, not 
 just the table reference

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-2155) Improve error messages emitted during semantic analysis

2011-05-12 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13032753#comment-13032753
 ] 

jirapos...@reviews.apache.org commented on HIVE-2155:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/731/
---

(Updated 2011-05-12 23:44:48.689718)


Review request for hive and John Sichi.


Changes
---

Updated based on John's comments in the JIRA, instead of changing the overall 
structure, I decided to move the logic to print that context token into the new 
generateErrorMessage, which prevents breaking existing error messages which 
rely on that behavior.


Summary
---

Attaches line/column number to the vast majority of SemanticExceptions thrown. 
In addition, the context strings for the error messages relating to UNION ALLs 
and GROUP BY keys have been changed to provide more meaningful context.


This addresses bug HIVE-2155.
https://issues.apache.org/jira/browse/HIVE-2155


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java dc96a1f 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 2fe37b6 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 4ddf5b9 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 9cb407c 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java bca37fd 
  ql/src/test/queries/clientnegative/union3.q PRE-CREATION 
  ql/src/test/results/clientnegative/analyze_view.q.out ef76106 
  ql/src/test/results/clientnegative/clusterbydistributeby.q.out 4c1ebfb 
  ql/src/test/results/clientnegative/clusterbysortby.q.out f76d4a7 
  ql/src/test/results/clientnegative/clustern3.q.out da71016 
  ql/src/test/results/clientnegative/clustern4.q.out 1519e48 
  ql/src/test/results/clientnegative/create_view_failure3.q.out 70e365a 
  ql/src/test/results/clientnegative/ddltime.q.out 11d00c3 
  ql/src/test/results/clientnegative/drop_partition_failure.q.out 1a0ac10 
  ql/src/test/results/clientnegative/dyn_part2.q.out cc0cd3c 
  ql/src/test/results/clientnegative/fileformat_void_input.q.out 5a7a05a 
  ql/src/test/results/clientnegative/groupby_key.q.out c6218a4 
  ql/src/test/results/clientnegative/input1.q.out 73f1657 
  ql/src/test/results/clientnegative/input2.q.out 0c460a6 
  ql/src/test/results/clientnegative/invalidate_view1.q.out 9f61228 
  ql/src/test/results/clientnegative/joinneg.q.out d85d508 
  ql/src/test/results/clientnegative/line_terminator.q.out b672bd8 
  ql/src/test/results/clientnegative/load_wrong_noof_part.q.out 4d8c8d8 
  ql/src/test/results/clientnegative/nopart_insert.q.out 42bca76 
  ql/src/test/results/clientnegative/notable_alias3.q.out d48d5e1 
  ql/src/test/results/clientnegative/orderbysortby.q.out 73b83a4 
  ql/src/test/results/clientnegative/regex_col_1.q.out 7547858 
  ql/src/test/results/clientnegative/regex_col_2.q.out f570010 
  ql/src/test/results/clientnegative/regex_col_groupby.q.out 8497718 
  ql/src/test/results/clientnegative/semijoin1.q.out 739931f 
  ql/src/test/results/clientnegative/semijoin2.q.out 2b418de 
  ql/src/test/results/clientnegative/semijoin3.q.out a803b50 
  ql/src/test/results/clientnegative/semijoin4.q.out 86a834b 
  ql/src/test/results/clientnegative/split_sample_out_of_range.q.out 0761955 
  ql/src/test/results/clientnegative/split_sample_wrong_format.q.out 19b1417 
  ql/src/test/results/clientnegative/strict_orderby.q.out 2d3ba6b 
  ql/src/test/results/clientnegative/subq_insert.q.out 8c3ce79 
  ql/src/test/results/clientnegative/udf_array_contains_wrong1.q.out d6b98b4 
  ql/src/test/results/clientnegative/udf_array_contains_wrong2.q.out 7b8dca6 
  ql/src/test/results/clientnegative/udf_case_type_wrong.q.out 75b9638 
  ql/src/test/results/clientnegative/udf_case_type_wrong2.q.out 126fa4e 
  ql/src/test/results/clientnegative/udf_case_type_wrong3.q.out fd62771 
  ql/src/test/results/clientnegative/udf_coalesce.q.out a5279f5 
  ql/src/test/results/clientnegative/udf_elt_wrong_args_len.q.out 22a085a 
  ql/src/test/results/clientnegative/udf_elt_wrong_type.q.out fc83f23 
  ql/src/test/results/clientnegative/udf_field_wrong_args_len.q.out 3bf97d9 
  ql/src/test/results/clientnegative/udf_field_wrong_type.q.out 2a2e944 
  ql/src/test/results/clientnegative/udf_if_not_bool.q.out a3c8902 
  ql/src/test/results/clientnegative/udf_if_wrong_args_len.q.out 89b23c8 
  ql/src/test/results/clientnegative/udf_in.q.out 50a6b98 
  ql/src/test/results/clientnegative/udf_instr_wrong_args_len.q.out 7f66db7 
  ql/src/test/results/clientnegative/udf_instr_wrong_type.q.out 89d8542 
  ql/src/test/results/clientnegative/udf_locate_wrong_args_len.q.out 46613e8 
  ql/src/test/results/clientnegative/udf_locate_wrong_type.q.out 42cc4b6 
  

[jira] [Created] (HIVE-2163) SquirrelSQL 3.2.1 doesn't work with Hive 0.7.0

2011-05-12 Thread Carl Steinbach (JIRA)
SquirrelSQL 3.2.1 doesn't work with Hive 0.7.0
--

 Key: HIVE-2163
 URL: https://issues.apache.org/jira/browse/HIVE-2163
 Project: Hive
  Issue Type: Bug
  Components: JDBC
Affects Versions: 0.7.0
Reporter: Carl Steinbach


I tried using SquirrelSQL 3.2.1 with Hive 0.7.0 following the directions 
located here: http://wiki.apache.org/hadoop/Hive/HiveJDBCInterface

I registered the Hive JDBC driver with SquirrelSQL, and then get the following 
exception when I try to connect to the Hive Server process:

{noformat}
java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: 
java.lang.RuntimeException: java.io.IOException: failure to login 
at org.apache.hadoop.hive.ql.session.SessionState.start(SessionState.java:226) 
at org.apache.hadoop.hive.jdbc.HiveConnection.init(HiveConnection.java:72) 
at org.apache.hadoop.hive.jdbc.HiveDriver.connect(HiveDriver.java:110) 
at 
net.sourceforge.squirrel_sql.fw.sql.SQLDriverManager.getConnection(SQLDriverManager.java:133)
 
at 
net.sourceforge.squirrel_sql.client.mainframe.action.OpenConnectionCommand.execute(OpenConnectionCommand.java:97)
 
at 
net.sourceforge.squirrel_sql.client.mainframe.action.ConnectToAliasCommand$SheetHandler.run(ConnectToAliasCommand.java:281)
at 
net.sourceforge.squirrel_sql.client.mainframe.action.ConnectToAliasCommand$SheetHandler.performOK(ConnectToAliasCommand.java:238)
at 
net.sourceforge.squirrel_sql.client.gui.db.ConnectionInternalFrame.connect(ConnectionInternalFrame.java:311)
 
at 
net.sourceforge.squirrel_sql.client.gui.db.ConnectionInternalFrame.access$300(ConnectionInternalFrame.java:56)
 
at 
net.sourceforge.squirrel_sql.client.gui.db.ConnectionInternalFrame$MyOkClosePanelListener.okPressed(ConnectionInternalFrame.java:461)
at 
net.sourceforge.squirrel_sql.client.gui.OkClosePanel.fireButtonPressed(OkClosePanel.java:148)
 
at 
net.sourceforge.squirrel_sql.client.gui.OkClosePanel.access$100(OkClosePanel.java:33)
 
at 
net.sourceforge.squirrel_sql.client.gui.OkClosePanel$1.actionPerformed(OkClosePanel.java:174)
 
at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2028) 
at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2351) 
at 
javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387) 
at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242) 
at 
javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236)
 
at java.awt.Component.processMouseEvent(Component.java:6374) 
at javax.swing.JComponent.processMouseEvent(JComponent.java:3267) 
at java.awt.Component.processEvent(Component.java:6139) 
at java.awt.Container.processEvent(Container.java:2085) 
at java.awt.Component.dispatchEventImpl(Component.java:4736) 
at java.awt.Container.dispatchEventImpl(Container.java:2143) 
at java.awt.Component.dispatchEvent(Component.java:4566) 
at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4621) 
at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4282) 
at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4212) 
at java.awt.Container.dispatchEventImpl(Container.java:2129) 
at java.awt.Window.dispatchEventImpl(Window.java:2478) 
at java.awt.Component.dispatchEvent(Component.java:4566) 
at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:680) 
at java.awt.EventQueue.access$000(EventQueue.java:86) 
at java.awt.EventQueue$1.run(EventQueue.java:639) 
at java.awt.EventQueue$1.run(EventQueue.java:637) 
at java.security.AccessController.doPrivileged(Native Method) 
at 
java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
 
at 
java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:98)
 
at java.awt.EventQueue$2.run(EventQueue.java:653) 
at java.awt.EventQueue$2.run(EventQueue.java:651) 
at java.security.AccessController.doPrivileged(Native Method) 
at 
java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
 
at java.awt.EventQueue.dispatchEvent(EventQueue.java:650) 
at net.sourceforge.squirrel_sql.client.Main$1.dispatchEvent(Main.java:93) 
at 
java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:296)
 
at 
java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211) 
at 
java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:201)
 
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:196) 
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:188) 
at java.awt.EventDispatchThread.run(EventDispatchThread.java:122) 
Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: 
java.lang.RuntimeException: java.io.IOException: failure to login 
at 
org.apache.hadoop.hive.ql.metadata.HiveUtils.getAuthenticator(HiveUtils.java:225)
 
at 

[jira] [Commented] (HIVE-2163) SquirrelSQL 3.2.1 doesn't work with Hive 0.7.0

2011-05-12 Thread Carl Steinbach (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13032765#comment-13032765
 ] 

Carl Steinbach commented on HIVE-2163:
--

There's a workaround.

Ignore the directions on the wiki. Instead, set HADOOP_HOME, HIVE_HOME, PATH, 
and CLASSPATH as follows before running squirrel-sql.sh:

{noformat}

export HADOOP_HOME=YOUR_HADOOP_HOME
export HIVE_HOME=YOUR_HIVE_HOME
export PATH=$HIVE_HOME/bin:$HADOOP_HOME/bin:$PATH

# You'll need to manually expand the wildcards
export CLASSPATH=$HADOOP_HOME/hadoop-*.jar:$HIVE_HOME/conf:$HIVE_HOME/lib/*.jar
{noformat}


 SquirrelSQL 3.2.1 doesn't work with Hive 0.7.0
 --

 Key: HIVE-2163
 URL: https://issues.apache.org/jira/browse/HIVE-2163
 Project: Hive
  Issue Type: Bug
  Components: JDBC
Affects Versions: 0.7.0
Reporter: Carl Steinbach

 I tried using SquirrelSQL 3.2.1 with Hive 0.7.0 following the directions 
 located here: http://wiki.apache.org/hadoop/Hive/HiveJDBCInterface
 I registered the Hive JDBC driver with SquirrelSQL, and then get the 
 following exception when I try to connect to the Hive Server process:
 {noformat}
 java.lang.RuntimeException: org.apache.hadoop.hive.ql.metadata.HiveException: 
 java.lang.RuntimeException: java.io.IOException: failure to login 
 at 
 org.apache.hadoop.hive.ql.session.SessionState.start(SessionState.java:226) 
 at org.apache.hadoop.hive.jdbc.HiveConnection.init(HiveConnection.java:72) 
 at org.apache.hadoop.hive.jdbc.HiveDriver.connect(HiveDriver.java:110) 
 at 
 net.sourceforge.squirrel_sql.fw.sql.SQLDriverManager.getConnection(SQLDriverManager.java:133)
  
 at 
 net.sourceforge.squirrel_sql.client.mainframe.action.OpenConnectionCommand.execute(OpenConnectionCommand.java:97)
  
 at 
 net.sourceforge.squirrel_sql.client.mainframe.action.ConnectToAliasCommand$SheetHandler.run(ConnectToAliasCommand.java:281)
 at 
 net.sourceforge.squirrel_sql.client.mainframe.action.ConnectToAliasCommand$SheetHandler.performOK(ConnectToAliasCommand.java:238)
 at 
 net.sourceforge.squirrel_sql.client.gui.db.ConnectionInternalFrame.connect(ConnectionInternalFrame.java:311)
  
 at 
 net.sourceforge.squirrel_sql.client.gui.db.ConnectionInternalFrame.access$300(ConnectionInternalFrame.java:56)
  
 at 
 net.sourceforge.squirrel_sql.client.gui.db.ConnectionInternalFrame$MyOkClosePanelListener.okPressed(ConnectionInternalFrame.java:461)
 at 
 net.sourceforge.squirrel_sql.client.gui.OkClosePanel.fireButtonPressed(OkClosePanel.java:148)
  
 at 
 net.sourceforge.squirrel_sql.client.gui.OkClosePanel.access$100(OkClosePanel.java:33)
  
 at 
 net.sourceforge.squirrel_sql.client.gui.OkClosePanel$1.actionPerformed(OkClosePanel.java:174)
  
 at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2028) 
 at 
 javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2351) 
 at 
 javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
  
 at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242) 
 at 
 javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236)
  
 at java.awt.Component.processMouseEvent(Component.java:6374) 
 at javax.swing.JComponent.processMouseEvent(JComponent.java:3267) 
 at java.awt.Component.processEvent(Component.java:6139) 
 at java.awt.Container.processEvent(Container.java:2085) 
 at java.awt.Component.dispatchEventImpl(Component.java:4736) 
 at java.awt.Container.dispatchEventImpl(Container.java:2143) 
 at java.awt.Component.dispatchEvent(Component.java:4566) 
 at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4621) 
 at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4282) 
 at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4212) 
 at java.awt.Container.dispatchEventImpl(Container.java:2129) 
 at java.awt.Window.dispatchEventImpl(Window.java:2478) 
 at java.awt.Component.dispatchEvent(Component.java:4566) 
 at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:680) 
 at java.awt.EventQueue.access$000(EventQueue.java:86) 
 at java.awt.EventQueue$1.run(EventQueue.java:639) 
 at java.awt.EventQueue$1.run(EventQueue.java:637) 
 at java.security.AccessController.doPrivileged(Native Method) 
 at 
 java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
  
 at 
 java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:98)
  
 at java.awt.EventQueue$2.run(EventQueue.java:653) 
 at java.awt.EventQueue$2.run(EventQueue.java:651) 
 at java.security.AccessController.doPrivileged(Native Method) 
 at 
 java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
  
 at java.awt.EventQueue.dispatchEvent(EventQueue.java:650) 
 at 

Re: Review Request: HIVE-2155 Improve error messages emitted during semantic analysis

2011-05-12 Thread Syed Albiz

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/731/
---

(Updated 2011-05-12 23:44:48.689718)


Review request for hive and John Sichi.


Changes
---

Updated based on John's comments in the JIRA, instead of changing the overall 
structure, I decided to move the logic to print that context token into the new 
generateErrorMessage, which prevents breaking existing error messages which 
rely on that behavior.


Summary
---

Attaches line/column number to the vast majority of SemanticExceptions thrown. 
In addition, the context strings for the error messages relating to UNION ALLs 
and GROUP BY keys have been changed to provide more meaningful context.


This addresses bug HIVE-2155.
https://issues.apache.org/jira/browse/HIVE-2155


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java dc96a1f 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 2fe37b6 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 4ddf5b9 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 9cb407c 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java bca37fd 
  ql/src/test/queries/clientnegative/union3.q PRE-CREATION 
  ql/src/test/results/clientnegative/analyze_view.q.out ef76106 
  ql/src/test/results/clientnegative/clusterbydistributeby.q.out 4c1ebfb 
  ql/src/test/results/clientnegative/clusterbysortby.q.out f76d4a7 
  ql/src/test/results/clientnegative/clustern3.q.out da71016 
  ql/src/test/results/clientnegative/clustern4.q.out 1519e48 
  ql/src/test/results/clientnegative/create_view_failure3.q.out 70e365a 
  ql/src/test/results/clientnegative/ddltime.q.out 11d00c3 
  ql/src/test/results/clientnegative/drop_partition_failure.q.out 1a0ac10 
  ql/src/test/results/clientnegative/dyn_part2.q.out cc0cd3c 
  ql/src/test/results/clientnegative/fileformat_void_input.q.out 5a7a05a 
  ql/src/test/results/clientnegative/groupby_key.q.out c6218a4 
  ql/src/test/results/clientnegative/input1.q.out 73f1657 
  ql/src/test/results/clientnegative/input2.q.out 0c460a6 
  ql/src/test/results/clientnegative/invalidate_view1.q.out 9f61228 
  ql/src/test/results/clientnegative/joinneg.q.out d85d508 
  ql/src/test/results/clientnegative/line_terminator.q.out b672bd8 
  ql/src/test/results/clientnegative/load_wrong_noof_part.q.out 4d8c8d8 
  ql/src/test/results/clientnegative/nopart_insert.q.out 42bca76 
  ql/src/test/results/clientnegative/notable_alias3.q.out d48d5e1 
  ql/src/test/results/clientnegative/orderbysortby.q.out 73b83a4 
  ql/src/test/results/clientnegative/regex_col_1.q.out 7547858 
  ql/src/test/results/clientnegative/regex_col_2.q.out f570010 
  ql/src/test/results/clientnegative/regex_col_groupby.q.out 8497718 
  ql/src/test/results/clientnegative/semijoin1.q.out 739931f 
  ql/src/test/results/clientnegative/semijoin2.q.out 2b418de 
  ql/src/test/results/clientnegative/semijoin3.q.out a803b50 
  ql/src/test/results/clientnegative/semijoin4.q.out 86a834b 
  ql/src/test/results/clientnegative/split_sample_out_of_range.q.out 0761955 
  ql/src/test/results/clientnegative/split_sample_wrong_format.q.out 19b1417 
  ql/src/test/results/clientnegative/strict_orderby.q.out 2d3ba6b 
  ql/src/test/results/clientnegative/subq_insert.q.out 8c3ce79 
  ql/src/test/results/clientnegative/udf_array_contains_wrong1.q.out d6b98b4 
  ql/src/test/results/clientnegative/udf_array_contains_wrong2.q.out 7b8dca6 
  ql/src/test/results/clientnegative/udf_case_type_wrong.q.out 75b9638 
  ql/src/test/results/clientnegative/udf_case_type_wrong2.q.out 126fa4e 
  ql/src/test/results/clientnegative/udf_case_type_wrong3.q.out fd62771 
  ql/src/test/results/clientnegative/udf_coalesce.q.out a5279f5 
  ql/src/test/results/clientnegative/udf_elt_wrong_args_len.q.out 22a085a 
  ql/src/test/results/clientnegative/udf_elt_wrong_type.q.out fc83f23 
  ql/src/test/results/clientnegative/udf_field_wrong_args_len.q.out 3bf97d9 
  ql/src/test/results/clientnegative/udf_field_wrong_type.q.out 2a2e944 
  ql/src/test/results/clientnegative/udf_if_not_bool.q.out a3c8902 
  ql/src/test/results/clientnegative/udf_if_wrong_args_len.q.out 89b23c8 
  ql/src/test/results/clientnegative/udf_in.q.out 50a6b98 
  ql/src/test/results/clientnegative/udf_instr_wrong_args_len.q.out 7f66db7 
  ql/src/test/results/clientnegative/udf_instr_wrong_type.q.out 89d8542 
  ql/src/test/results/clientnegative/udf_locate_wrong_args_len.q.out 46613e8 
  ql/src/test/results/clientnegative/udf_locate_wrong_type.q.out 42cc4b6 
  ql/src/test/results/clientnegative/udf_size_wrong_args_len.q.out b05731e 
  ql/src/test/results/clientnegative/udf_size_wrong_type.q.out 0c91c8f 
  ql/src/test/results/clientnegative/udf_when_type_wrong.q.out bec3725 
  ql/src/test/results/clientnegative/udf_when_type_wrong2.q.out 5b06467