Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

2018-02-05 Thread Vihang Karajgaonkar via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65478/#review196867 ---

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-05 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/ --- (Updated Feb. 6, 2018, 7:03 a.m.) Review request for hive, Ashutosh Chauhan,

[jira] [Created] (HIVE-18632) TYPE CASTING ERROR: CONVERTING FORM INT TO STRING

2018-02-05 Thread shiva (JIRA)
shiva created HIVE-18632: Summary: TYPE CASTING ERROR: CONVERTING FORM INT TO STRING Key: HIVE-18632 URL: https://issues.apache.org/jira/browse/HIVE-18632 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-18631) Hive metastore schema initialization failing on mysql

2018-02-05 Thread Deepesh Khandelwal (JIRA)
Deepesh Khandelwal created HIVE-18631: - Summary: Hive metastore schema initialization failing on mysql Key: HIVE-18631 URL: https://issues.apache.org/jira/browse/HIVE-18631 Project: Hive

[jira] [Created] (HIVE-18630) Resource plan validate/activate does not verify trigger expressions.

2018-02-05 Thread Harish Jaiprakash (JIRA)
Harish Jaiprakash created HIVE-18630: Summary: Resource plan validate/activate does not verify trigger expressions. Key: HIVE-18630 URL: https://issues.apache.org/jira/browse/HIVE-18630 Project:

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-05 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65413/ --- (Updated Feb. 6, 2018, 3:29 a.m.) Review request for hive and Eugene Koifman.

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-05 Thread Sergey Shelukhin
> On Feb. 5, 2018, 6:52 p.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java > > Line 862 (original), 863 (patched) > > > > > > is 'job' cloned somewhere between invocations?

Re: Review Request 54341: HIVE-15353: Metastore throws NPE if StorageDescriptor.cols is null

2018-02-05 Thread Anthony Hsu via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54341/ --- (Updated 二月 6, 2018, 3:01 a.m.) Review request for hive, Carl Steinbach and

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-05 Thread Deepak Jaiswal
> On Feb. 6, 2018, 1:26 a.m., Sergey Shelukhin wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/CustomPartitionVertex.java > > Lines 551 (patched) > > > > > > what's the logic behind "- 2"? needs to be

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

2018-02-05 Thread cheng xu
> On Feb. 6, 2018, 1:46 a.m., Vihang Karajgaonkar wrote: > > Thanks Vihang for your review. Comments left below. > On Feb. 6, 2018, 1:46 a.m., Vihang Karajgaonkar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/ParquetDataColumnReaderFactory.java > > Lines 24 (patched) > >

[jira] [Created] (HIVE-18629) copyValues in BytesColumnVector may be missing null checks

2018-02-05 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-18629: --- Summary: copyValues in BytesColumnVector may be missing null checks Key: HIVE-18629 URL: https://issues.apache.org/jira/browse/HIVE-18629 Project: Hive

[jira] [Created] (HIVE-18628) Make tez dag status check interval configurable

2018-02-05 Thread Prasanth Jayachandran (JIRA)
Prasanth Jayachandran created HIVE-18628: Summary: Make tez dag status check interval configurable Key: HIVE-18628 URL: https://issues.apache.org/jira/browse/HIVE-18628 Project: Hive

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

2018-02-05 Thread Jerry Chen
> On Feb. 5, 2018, 5:46 p.m., Vihang Karajgaonkar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/ParquetDataColumnReaderFactory.java > > Lines 24 (patched) > > > > > > Do we need to override the

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-05 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/#review196846 ---

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-05 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/#review196844 ---

Re: Review Request 65431: HIVE-16605 : NOT NULL constraint enforcement

2018-02-05 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65431/ --- (Updated Feb. 6, 2018, 12:30 a.m.) Review request for hive, Ashutosh Chauhan

[jira] [Created] (HIVE-18627) PPD: Handle FLOAT boxing differently for single/double precision constants

2018-02-05 Thread Gopal V (JIRA)
Gopal V created HIVE-18627: -- Summary: PPD: Handle FLOAT boxing differently for single/double precision constants Key: HIVE-18627 URL: https://issues.apache.org/jira/browse/HIVE-18627 Project: Hive

Re: Review Request 65498: HIVE-18281: HiveServer2 HA for LLAP and Workload Manager

2018-02-05 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65498/ --- (Updated Feb. 5, 2018, 11:05 p.m.) Review request for hive, Sergey Shelukhin

Re: Review Request 65479: HIVE-18523 Fix summary row in case there are no inputs

2018-02-05 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65479/#review196840 ---

Re: Review Request 65500: Vectorized execution handles overflows in a different manner than non-vectorized execution

2018-02-05 Thread Vihang Karajgaonkar via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65500/ --- (Updated Feb. 5, 2018, 8:54 p.m.) Review request for hive, Aihua Xu, Gopal V,

Re: Intellij + Checkstyle setup

2018-02-05 Thread Andrew Sherman
I will try to make things clearer... When debugging checkstyle it can be useful to have the IDE run the checks. Checkstyle uses a file usually called checkstyle.xml for its configuration. The version of checkstyle in Intellij (or in the checkstyle plugin, IDK) does not like the checkstyle.xml

[jira] [Created] (HIVE-18626) Repl load "with" clause does not pass config to tasks

2018-02-05 Thread Daniel Dai (JIRA)
Daniel Dai created HIVE-18626: - Summary: Repl load "with" clause does not pass config to tasks Key: HIVE-18626 URL: https://issues.apache.org/jira/browse/HIVE-18626 Project: Hive Issue Type: Bug

Re: Review Request 65431: HIVE-16605 : NOT NULL constraint enforcement

2018-02-05 Thread Gopal V
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65431/#review196823 ---

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

2018-02-05 Thread Eugene Koifman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65413/#review196819 --- ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java Lines

Review Request 65507: HIVE-18580: Create tests to cover exchange partitions

2018-02-05 Thread Marta Kuczora via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65507/ --- Review request for hive, Peter Vary and Adam Szita. Bugs: HIVE-18580

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

2018-02-05 Thread Vihang Karajgaonkar via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65478/#review196718 ---

[jira] [Created] (HIVE-18624) Parsing time is very high in certain complex expressions

2018-02-05 Thread Amruth S (JIRA)
Amruth S created HIVE-18624: --- Summary: Parsing time is very high in certain complex expressions Key: HIVE-18624 URL: https://issues.apache.org/jira/browse/HIVE-18624 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-18623) Hive throws an exception "Renames across Mount points not supported" when running in a federated cluster

2018-02-05 Thread yangfang (JIRA)
yangfang created HIVE-18623: --- Summary: Hive throws an exception "Renames across Mount points not supported" when running in a federated cluster Key: HIVE-18623 URL: https://issues.apache.org/jira/browse/HIVE-18623

[jira] [Created] (HIVE-18622) Vectorization: IF statement, Comparisons, and more do not handle NULLs correctly

2018-02-05 Thread Matt McCline (JIRA)
Matt McCline created HIVE-18622: --- Summary: Vectorization: IF statement, Comparisons, and more do not handle NULLs correctly Key: HIVE-18622 URL: https://issues.apache.org/jira/browse/HIVE-18622

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

2018-02-05 Thread cheng xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65478/ --- (Updated Feb. 5, 2018, 4:46 p.m.) Review request for hive. Repository: