Re: Review Request 65500: HIVE-18421 : Vectorized execution handles overflows in a different manner than non-vectorized execution

> On Feb. 7, 2018, 2:40 a.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/PosModLongToLong.java > > Lines 46-48 (patched) > > > > > > is there a way to do this check just

Re: Review Request 65500: HIVE-18421 : Vectorized execution handles overflows in a different manner than non-vectorized execution

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65500/ --- (Updated Feb. 7, 2018, 7:13 a.m.) Review request for hive, Aihua Xu, Gopal V,

Re: Unit Test Failing

I took a quick look at the failing tests on your patch and they all look to be the regularly failing ones. Another way to confirm if this is true is by going to the Precommit job's Test Result link posted on your JIRA and checking if Jenkins shows that the test has been failing x number builds.

Unit Test Failing

Hi I am a new committer to Hive. I am working on this JIRA . I have already submitted the patch and various unit test cases are failing which are not related to my code. There is a mail by Vihang Karajgaonkar by subject as *[DISCUSS] 26 unit

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

> On Feb. 6, 2018, 3:06 p.m., Vihang Karajgaonkar wrote: > > ql/src/test/queries/clientpositive/schema_evol_par_vec_table.q > > Lines 71 (patched) > > > > > > Can you please test using timestamps as well.

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

> On Feb. 6, 2018, 3:06 p.m., Vihang Karajgaonkar wrote: > > ql/src/test/queries/clientpositive/schema_evol_par_vec_table.q > > Lines 71 (patched) > > > > > > Can you please test using timestamps as well.

Re: Review Request 65500: HIVE-18421 : Vectorized execution handles overflows in a different manner than non-vectorized execution

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65500/#review196967 --- Fix it, then Ship it! One last comment, otherwise LGTM.

Re: Review Request 65422: HIVE-17626

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65422/#review196950 --- First pass review.

[jira] [Created] (HIVE-18644) archived partitions check is very slow

Sergey Shelukhin created HIVE-18644: --- Summary: archived partitions check is very slow Key: HIVE-18644 URL: https://issues.apache.org/jira/browse/HIVE-18644 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-18643) don't check for archived partitions for ACID ops

Sergey Shelukhin created HIVE-18643: --- Summary: don't check for archived partitions for ACID ops Key: HIVE-18643 URL: https://issues.apache.org/jira/browse/HIVE-18643 Project: Hive Issue

Re: Review Request 65500: HIVE-18421 : Vectorized execution handles overflows in a different manner than non-vectorized execution

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65500/ --- (Updated Feb. 7, 2018, 12:49 a.m.) Review request for hive, Aihua Xu, Gopal V,

Re: Review Request 65500: HIVE-18421 : Vectorized execution handles overflows in a different manner than non-vectorized execution

> On Feb. 7, 2018, 12:17 a.m., Sahil Takiar wrote: > > ql/src/gen/vectorization/TestTemplates/TestClass.txt > > Lines 27 (patched) > > > > > > is this necessary? yes, this is needed since this template is used to

Re: Review Request 65500: HIVE-18421 : Vectorized execution handles overflows in a different manner than non-vectorized execution

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65500/#review196948 --- ql/src/gen/vectorization/TestTemplates/TestClass.txt Lines 27

Review Request 65539: HIVE-17063

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65539/ --- Review request for hive, Ashutosh Chauhan and Eugene Koifman. Bugs: HIVE-1703

Re: Review Request 54341: HIVE-15353: Metastore throws NPE if StorageDescriptor.cols is null

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54341/#review196927 --- Ship it! Ship It! - Carl Steinbach On Feb. 6, 2018, 3:01

[jira] [Created] (HIVE-18642) incorrect assertion in TezSessionPool for WM

Sergey Shelukhin created HIVE-18642: --- Summary: incorrect assertion in TezSessionPool for WM Key: HIVE-18642 URL: https://issues.apache.org/jira/browse/HIVE-18642 Project: Hive Issue Type:

Question on CachedStore cache update

I’m confused by the following code in the CachedStore. This in in the CacheUpdateMasterWork thread, in the updateDatabases method (which is called by update()): *// Skip background updates if we detect change* *if *(*isDatabaseCacheDirty*.compareAndSet(*true*, *false*)) {

[jira] [Created] (HIVE-18641) Remove MCreationMetadata from MTable class

Jesus Camacho Rodriguez created HIVE-18641: -- Summary: Remove MCreationMetadata from MTable class Key: HIVE-18641 URL: https://issues.apache.org/jira/browse/HIVE-18641 Project: Hive

[jira] [Created] (HIVE-18640) Update q.out for TestSparkCliDriver.testCliDriver[ppd_join5]

Sahil Takiar created HIVE-18640: --- Summary: Update q.out for TestSparkCliDriver.testCliDriver[ppd_join5] Key: HIVE-18640 URL: https://issues.apache.org/jira/browse/HIVE-18640 Project: Hive

Re: [DISCUSS] 26 Unit tests failing regularly

I can take a look at the Spark and Encryption ones. On Tue, Feb 6, 2018 at 10:38 AM, Deepak Jaiswal wrote: > I already have JIRA for > org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver. > testCliDriver[bucket_map_join_tez1] > > Will pick up these two, > >

Dataworks Summit San Jose Call for Abstracts closes Friday Feb 9

All, Dataworks Summit San Jose 2018 is June 17-21. The call for abstracts is open through February 9th. One of the tracks is Datawarehousing and Operational Data Store, which is a great fit for Hive talks. You can submit an abstract at https://dataworkssummit.com/san-jose-2018/ Alan.

Re: [DISCUSS] 26 Unit tests failing regularly

I already have JIRA for org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucket_map_join_tez1] Will pick up these two, org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[llap_smb] org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_sortmerge_join_2] On

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/ --- (Updated Feb. 6, 2018, 6:37 p.m.) Review request for hive, Ashutosh Chauhan,

[jira] [Created] (HIVE-18639) HiveMetaStoreFsImpl#deleteDir should check return value of FileUtils#moveToTrash

Sahil Takiar created HIVE-18639: --- Summary: HiveMetaStoreFsImpl#deleteDir should check return value of FileUtils#moveToTrash Key: HIVE-18639 URL: https://issues.apache.org/jira/browse/HIVE-18639

[jira] [Created] (HIVE-18638) Triggers for multi-pool move, failing to initiate the move event

Aswathy Chellammal Sreekumar created HIVE-18638: --- Summary: Triggers for multi-pool move, failing to initiate the move event Key: HIVE-18638 URL: https://issues.apache.org/jira/browse/HIVE-18638

[jira] [Created] (HIVE-18637) WorkloadManagent Event Summary leaving subscribedCounters and currentCounters fields empty

Aswathy Chellammal Sreekumar created HIVE-18637: --- Summary: WorkloadManagent Event Summary leaving subscribedCounters and currentCounters fields empty Key: HIVE-18637 URL:

Re: [DISCUSS] 26 Unit tests failing regularly

I’ll take care of org.apache.hadoop.hive.ql.TestTxnNoBuckets.testCTAS (batchId=280) org.apache.hadoop.hive.ql.TestTxnNoBucketsVectorized.testCTAS (batchId=280) On 2/6/18, 9:54 AM, "Vihang Karajgaonkar" wrote: org.apache.hadoop.hive.ql.TestTxnNoBuckets.testCTAS

[jira] [Created] (HIVE-18636) fix TestTxnNoBuckets.testCTAS - keeps failing on ptest

Eugene Koifman created HIVE-18636: - Summary: fix TestTxnNoBuckets.testCTAS - keeps failing on ptest Key: HIVE-18636 URL: https://issues.apache.org/jira/browse/HIVE-18636 Project: Hive Issue

[DISCUSS] 26 Unit tests failing regularly

I see that the regularly failing unit tests on the master branch is slowly climbing up and its close to ~26 now. Many of these don't seem to be "flaky" test failures since they are consistently failing for a while with the same error message. Some of these can be fixed by a simple q.out update

Re: Review Request 65479: HIVE-18523 Fix summary row in case there are no inputs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65479/ --- (Updated Feb. 6, 2018, 5:15 p.m.) Review request for hive, Ashutosh Chauhan

Re: Review Request 65479: HIVE-18523 Fix summary row in case there are no inputs

> On Feb. 5, 2018, 11:05 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceWork.java > > Lines 213 (patched) > > > > > > Do we need this? Reducers are always launched when when there

Re: Review Request 65479: HIVE-18523 Fix summary row in case there are no inputs

> On Feb. 5, 2018, 11:05 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceWork.java > > Lines 213 (patched) > > > > > > Do we need this? Reducers are always launched when when there

Re: Yetus JDK version

This should be fixed now, https://issues.apache.org/jira/browse/HIVE-18612 is committed and new war is deployed on our ptest server. Alan, can you please go ahead and give it another go to see if it all works fine? Thanks, Adam On 2 February 2018 at 15:42, Adam Szita wrote:

[jira] [Created] (HIVE-18635) Generalize hook dispatch logics in Driver

Zoltan Haindrich created HIVE-18635: --- Summary: Generalize hook dispatch logics in Driver Key: HIVE-18635 URL: https://issues.apache.org/jira/browse/HIVE-18635 Project: Hive Issue Type:

[jira] [Created] (HIVE-18634) Spark artifact alters classpath for tests

Zoltan Haindrich created HIVE-18634: --- Summary: Spark artifact alters classpath for tests Key: HIVE-18634 URL: https://issues.apache.org/jira/browse/HIVE-18634 Project: Hive Issue Type: Bug

Re: Review Request 65479: HIVE-18523 Fix summary row in case there are no inputs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65479/ --- (Updated Feb. 6, 2018, 10:24 a.m.) Review request for hive, Ashutosh Chauhan

Re: Review Request 65479: HIVE-18523 Fix summary row in case there are no inputs

> On Feb. 5, 2018, 11:05 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/IConfigureJobConf.java > > Lines 24 (patched) > > > > > > Add: Intended only for compilation phase. added > On

[jira] [Created] (HIVE-18633) Service discovery for Active/Passive HA mode

Prasanth Jayachandran created HIVE-18633: Summary: Service discovery for Active/Passive HA mode Key: HIVE-18633 URL: https://issues.apache.org/jira/browse/HIVE-18633 Project: Hive

Review Request 65527: HIVE-18628: Make tez dag status check interval configurable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65527/ --- Review request for hive and Sergey Shelukhin. Bugs: HIVE-18628