iption
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
Lines 2520-2525 (patched)
<https://reviews.apache.org/r/72360/#comment308658>
I would do it in setConf, like we did with the numOpenTxns and friends
- Peter Vary
On ápr. 14, 2
/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
Lines 2834 (patched)
<https://reviews.apache.org/r/72336/#comment308593>
nit: extra space
- Peter Vary
On ápr. 8, 2020, 12:20 du, Marta Kuczora
/hadoop/hive/metastore/txn/TxnHandler.java
Lines 1379 (patched)
<https://reviews.apache.org/r/72290/#comment308489>
Will this issue unnecessary queries for read only queries? For Oracle this
could increase exexution time
Also why not use executeQueryiesInBatch for this?
- Pete
45.2314.59
openTxn115k-10 33.1632.0725.9262.4115.66
openTxn125k-10062.1669.2430.08187.642.01
Thanks,
Peter Vary
etastore/metastore-tools/tools-common/src/main/java/org/apache/hadoop/hive/metastore/tools/Util.java
Line 40 (original), 35 (patched)
<https://reviews.apache.org/r/72112/#comment308525>
wildcard import
- Peter Vary
On ápr. 2, 2020, 2:13 du, Zoltan Chovan wrote:
>
> -
andalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
Lines 2599 (patched)
<https://reviews.apache.org/r/72264/#comment308471>
Do we need this? We do not commit temp lock id, so we can have just a
single value which definitely will not appear in
Maybe delete immediately, like:
DELETE FROM TXN_TO_WRITE_ID WHERE T2W_TXNID < (SELECT MIN...)
The hard part is that it is hard to log what happened
- Peter Vary
On márc. 31, 2020, 1:51 du, Laszlo Pin
30.08187.642.01
Thanks,
Peter Vary
he top, since the formatting/parsing and kept this one
because of this is used only here, and only once
- Peter
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72283/#review220103
---
-
On ápr. 1, 2020, 6:53 de, Marton Bod wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72290/
> ---
>
> (Updated ápr. 1, 2020, 6:53 de)
>
>
&
14.59
openTxn115k-10 33.1632.0725.9262.4115.66
openTxn125k-10062.1669.2430.08187.642.01
Thanks,
Peter Vary
> On ápr. 28, 2020, 8:54 de, Peter Vary wrote:
> > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java
> > Lines 113 (patched)
> > <https://reviews.apache.org/r/72444/diff/1/?file=2229091#file2229091line114
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72444/#review220523
---
Ship it!
Ship It!
- Peter Vary
On ápr. 28, 2020, 10:37 de
27 (patched)
<https://reviews.apache.org/r/72388/#comment308964>
Is this public?
- Peter Vary
On ápr. 24, 2020, 3:40 du, Peter Varga wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72436/#review220526
---
Ship it!
Ship It!
- Peter Vary
On ápr. 28, 2020, 4:23 du
88/#comment308934>
Why is this change?
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnStore.java
Line 47 (original), 47 (patched)
<https://reviews.apache.org/r/72388/#comment308931>
What is the reason behind this change?
- Peter Var
s risky here?
- Peter Vary
On ápr. 22, 2020, 2:29 du, Denys Kuzmenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
Lines 4389-4391 (patched)
<https://reviews.apache.org/r/72436/#comment308996>
This is strange for me.
We do not abort the transaction, but throw an TxnAbortedException, but
remove the Locks?
- Peter Vary
On ápr. 27, 2020, 11:24 de, Denys Ku
#comment308987>
Maybe single statement return, like:
return firstAbortedTxnTime + abortedTimeThreshold <
System.currentTimeMillis()
- Peter Vary
On ápr. 28, 2020, 8:39 de, Karen Coppage wrote:
>
> ---
> This is an
> On ápr. 14, 2020, 11:22 de, Peter Vary wrote:
> > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
> > Lines 1325 (patched)
> > <https://reviews.apache.org/r/72359/diff/1/?file=2217523#file2217523line1388>
>
nt309292>
Why is this change?
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
Line 2090 (original), 2081 (patched)
<https://reviews.apache.org/r/72481/#comment309293>
Why is this change?
- Peter Vary
es 305 (patched)
<https://reviews.apache.org/r/72281/#comment309509>
Migth want to add asserts here to check non-null argument
- Peter Vary
On márc. 30, 2020, 6:18 de, Karen Coppage wrote:
>
> ---
> This is an automatic
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72281/#review220822
---
Ship it!
Ship It!
- Peter Vary
On máj. 19, 2020, 5:58 de
> On máj. 18, 2020, 12:51 du, Peter Vary wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java
> > Lines 305 (patched)
> > <https://reviews.apache.org/r/72281/diff/1/?file=2216347#file2216347line305>
> >
> > Migth want to add
rver/src/test/java/org/apache/hadoop/hive/metastore/MetaStoreTestUtils.java
Lines 242 (patched)
<https://reviews.apache.org/r/72480/#comment309539>
Question: Is this again the case when the HMS is started, but the HK
threads are not started? Maybe extend the log line that the HMS is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72470/#review220673
---
Ship it!
Ship It!
- Peter Vary
On máj. 7, 2020, 1:21 du
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72480/#review220839
---
Ship it!
Ship It!
- Peter Vary
On máj. 20, 2020, 2:03 du
/TestWorker.java
443f982d66
Diff: https://reviews.apache.org/r/72553/diff/1/
Testing
---
Created unit tests to check the timeout functionality.
Thanks,
Peter Vary
://reviews.apache.org/r/72553/diff/1-2/
Testing
---
Created unit tests to check the timeout functionality.
Thanks,
Peter Vary
-23725
- Peter Vary
On jún. 9, 2020, 8:52 de, Denys Kuzmenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
801 - 830 of 830 matches
Mail list logo
