Re: [ANNOUNCE] New Hive Committer - Thejas Nair

2013-08-20 Thread Vaibhav Gumashta
Congrats Thejas! On Tue, Aug 20, 2013 at 9:56 AM, Shreepadma Venugopalan shreepa...@cloudera.com wrote: Congrats Tejas! On Tue, Aug 20, 2013 at 9:32 AM, Eugene Koifman ekoif...@hortonworks.com wrote: Congrats Thejas! On Tue, Aug 20, 2013 at 3:31 AM, Carl Steinbach c...@apache.org

Re: [ANNOUNCE] New Hive Committer - Yin Huai

2013-09-04 Thread Vaibhav Gumashta
Congrats Yin! On Tue, Sep 3, 2013 at 11:37 PM, Jarek Jarcec Cecho jar...@apache.orgwrote: Congratulations Yin! Jarcec On Tue, Sep 03, 2013 at 09:49:55PM -0700, Carl Steinbach wrote: The Apache Hive PMC has voted to make Yin Huai a committer on the Apache Hive project. Please join

Re: creating branch 0.12

2013-09-07 Thread Vaibhav Gumashta
Would like to see HIVE-4617 get in. Thanks, --Vaibhav On Sat, Sep 7, 2013 at 6:43 PM, Edward Capriolo edlinuxg...@gmail.comwrote: Going to finish it tonight. On Saturday, September 7, 2013, Carl Steinbach c...@apache.org wrote: Just writing to confirm that HIVE-5087 is a blocker for the

Re: Review Request 14484: HIVE-5440: HiveServer2 doesn't apply SQL operation's config property

2013-10-14 Thread Vaibhav Gumashta
/SQLOperation.java https://reviews.apache.org/r/14484/#comment52582 Possible to test this behaviour as well? - Vaibhav Gumashta On Oct. 4, 2013, 7:16 a.m., Prasad Mujumdar wrote: --- This is an automatically generated e-mail. To reply, visit

Review Request 14719: Better thread management for HiveServer2 async threads

2013-10-17 Thread Vaibhav Gumashta
--- TestEmbeddedThriftBinaryCLIService, TestThriftBinaryCLIService, TestJdbcDriver2 Thanks, Vaibhav Gumashta

Re: Review Request 14719: Better thread management for HiveServer2 async threads

2013-10-24 Thread Vaibhav Gumashta
. Thanks for the feedback! - Vaibhav Gumashta On Oct. 17, 2013, 8:32 p.m., Vaibhav Gumashta wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14719

Re: [ANNOUNCE] New Hive PMC Members - Thejas Nair and Brock Noland

2013-10-24 Thread Vaibhav Gumashta
Congrats Brock and Thejas! On Thu, Oct 24, 2013 at 3:25 PM, Prasad Mujumdar pras...@cloudera.comwrote: Congratulations Thejas and Brock ! thanks Prasad On Thu, Oct 24, 2013 at 3:10 PM, Carl Steinbach c...@apache.org wrote: I am pleased to announce that Thejas Nair and Brock Noland

Review Request 14950: Make JDBC use the new HiveServer2 async execution API by default

2013-10-25 Thread Vaibhav Gumashta
status] Diffs - jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 2912ece Diff: https://reviews.apache.org/r/14950/diff/ Testing --- TestJdbcDriver2 Thanks, Vaibhav Gumashta

Review Request 15151: Better error reporting by async threads in HiveServer2

2013-10-31 Thread Vaibhav Gumashta
ff7166d Diff: https://reviews.apache.org/r/15151/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-10-31 Thread Vaibhav Gumashta
/hive/service/cli/thrift/ThriftCLIServiceTest.java ff7166d Diff: https://reviews.apache.org/r/15151/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: [ANNOUNCE] New Hive Committer - Xuefu Zhang

2013-11-04 Thread Vaibhav Gumashta
Congrats Xuefu! On Mon, Nov 4, 2013 at 9:17 AM, Prasad Mujumdar pras...@cloudera.comwrote: Congratulations Xuefu! thanks Prasad On Sun, Nov 3, 2013 at 8:06 PM, Carl Steinbach cwsteinb...@gmail.com wrote: The Apache Hive PMC has voted to make Xuefu Zhang a committer on the Apache

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-05 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151/#review28168 --- On Nov. 1, 2013, 12:54 a.m., Vaibhav Gumashta wrote

Re: Review Request 14719: Better thread management for HiveServer2 async threads

2013-11-06 Thread Vaibhav Gumashta
service/src/java/org/apache/hive/service/cli/session/SessionManager.java f392d62 Diff: https://reviews.apache.org/r/14719/diff/ Testing --- TestEmbeddedThriftBinaryCLIService, TestThriftBinaryCLIService, TestJdbcDriver2 Thanks, Vaibhav Gumashta

Re: Review Request 14719: Better thread management for HiveServer2 async threads

2013-11-06 Thread Vaibhav Gumashta
/SQLOperation.java f6adf92 service/src/java/org/apache/hive/service/cli/session/SessionManager.java f392d62 Diff: https://reviews.apache.org/r/14719/diff/ Testing --- TestEmbeddedThriftBinaryCLIService, TestThriftBinaryCLIService, TestJdbcDriver2 Thanks, Vaibhav Gumashta

Re: Review Request 14719: Better thread management for HiveServer2 async threads

2013-11-06 Thread Vaibhav Gumashta
f6adf92 service/src/java/org/apache/hive/service/cli/session/SessionManager.java f392d62 Diff: https://reviews.apache.org/r/14719/diff/ Testing --- TestEmbeddedThriftBinaryCLIService, TestThriftBinaryCLIService, TestJdbcDriver2 Thanks, Vaibhav Gumashta

Re: Review Request 14719: Better thread management for HiveServer2 async threads

2013-11-06 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14719/#review28350 --- On Nov. 7, 2013, 4:12 a.m., Vaibhav Gumashta wrote

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-07 Thread Vaibhav Gumashta
volatile, as it can now be accessed from multiple threads. We should also do that for state in Operation.java . But that can be addressed in another thread. Vaibhav Gumashta wrote: It seems we might not need to make this volatile. From the java docs (http://docs.oracle.com/javase/7/docs

Re: [ANNOUNCE] New Hive Committer - Prasad Mujumdar

2013-11-10 Thread Vaibhav Gumashta
Congrats Prasad! On Sun, Nov 10, 2013 at 8:17 PM, Lefty Leverenz leftylever...@gmail.comwrote: Congratulations Prasad! -- Lefty On Sun, Nov 10, 2013 at 11:04 PM, Brock Noland br...@cloudera.com wrote: Congratulations!! On Sunday, November 10, 2013, Thejas Nair wrote: Congrats

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-11 Thread Vaibhav Gumashta
://reviews.apache.org/r/15151/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-11 Thread Vaibhav Gumashta
--- Thanks, Vaibhav Gumashta

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-11 Thread Vaibhav Gumashta
://reviews.apache.org/r/15151/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-11 Thread Vaibhav Gumashta
: https://reviews.apache.org/r/15151/#review28572 --- On Nov. 11, 2013, 7:23 p.m., Vaibhav Gumashta wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 15337: HIVE-5217: Add long polling to asynchronous execution in HiveServer2

2013-11-11 Thread Vaibhav Gumashta
request for hive and Vaibhav Gumashta. Bugs: HIVE-5217 https://issues.apache.org/jira/browse/HIVE-5217 Repository: hive-git Description --- Add long polling to asynchronous execution in HiveServer2 Diffs - common/src/java/org/apache/hadoop/hive/conf

Review Request 15435: Add long polling to asynchronous execution in HiveServer2

2013-11-11 Thread Vaibhav Gumashta
/apache/hive/service/cli/operation/SQLOperation.java 4ee1b74 service/src/test/org/apache/hive/service/cli/CLIServiceTest.java cd9d99a Diff: https://reviews.apache.org/r/15435/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 15435: Add long polling to asynchronous execution in HiveServer2

2013-11-11 Thread Vaibhav Gumashta
, Vaibhav Gumashta

Re: Review Request 15435: Add long polling to asynchronous execution in HiveServer2

2013-11-11 Thread Vaibhav Gumashta
, Vaibhav Gumashta

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-12 Thread Vaibhav Gumashta
--- On Nov. 11, 2013, 7:23 p.m., Vaibhav Gumashta wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-12 Thread Vaibhav Gumashta
--- On Nov. 11, 2013, 7:23 p.m., Vaibhav Gumashta wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151/ --- (Updated Nov. 11

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-12 Thread Vaibhav Gumashta
/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-13 Thread Vaibhav Gumashta
On Nov. 11, 2013, 7:52 p.m., Carl Steinbach wrote: service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java, line 307 https://reviews.apache.org/r/15151/diff/3/?file=381921#file381921line307 Todo: set the status information. Vaibhav Gumashta wrote

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-13 Thread Vaibhav Gumashta
--- Thanks, Vaibhav Gumashta

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-13 Thread Vaibhav Gumashta
/ThriftCLIServiceClient.java 9bb2a0f service/src/test/org/apache/hive/service/cli/CLIServiceTest.java cd9d99a service/src/test/org/apache/hive/service/cli/thrift/ThriftCLIServiceTest.java ff7166d Diff: https://reviews.apache.org/r/15151/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 15435: Add long polling to asynchronous execution in HiveServer2

2013-11-13 Thread Vaibhav Gumashta
--- On Nov. 12, 2013, 2:16 a.m., Vaibhav Gumashta wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15435

Re: Review Request 15435: Add long polling to asynchronous execution in HiveServer2

2013-11-13 Thread Vaibhav Gumashta
--- Thanks, Vaibhav Gumashta

Re: Review Request 15435: Add long polling to asynchronous execution in HiveServer2

2013-11-13 Thread Vaibhav Gumashta
-default.xml.template fe7141e service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 4ee1b74 service/src/test/org/apache/hive/service/cli/CLIServiceTest.java cd9d99a Diff: https://reviews.apache.org/r/15435/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: [ANNOUNCE] New Hive PMC Member - Harish Butani

2013-11-14 Thread Vaibhav Gumashta
Congrats Harish! --Vaibhav On Thu, Nov 14, 2013 at 5:18 PM, Clark Yang (杨卓荦) yangzhuo...@gmail.comwrote: Congrats, Harish! Cheers, Zhuoluo (Clark) Yang 2013/11/15 Carl Steinbach c...@apache.org I am pleased to announce that Harish Butani has been elected to the Hive Project

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-15 Thread Vaibhav Gumashta
://reviews.apache.org/r/15151/#review28949 --- On Nov. 13, 2013, 9:54 p.m., Vaibhav Gumashta wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15151

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-15 Thread Vaibhav Gumashta
/ThriftCLIServiceClient.java 9bb2a0f service/src/test/org/apache/hive/service/cli/CLIServiceTest.java cd9d99a service/src/test/org/apache/hive/service/cli/thrift/ThriftCLIServiceTest.java ff7166d Diff: https://reviews.apache.org/r/15151/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-15 Thread Vaibhav Gumashta
/ThriftCLIServiceClient.java 9bb2a0f service/src/test/org/apache/hive/service/cli/CLIServiceTest.java cd9d99a service/src/test/org/apache/hive/service/cli/thrift/ThriftCLIServiceTest.java ff7166d Diff: https://reviews.apache.org/r/15151/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-15 Thread Vaibhav Gumashta
--- Thanks, Vaibhav Gumashta

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-11-15 Thread Vaibhav Gumashta
/ThriftCLIServiceClient.java 9bb2a0f service/src/test/org/apache/hive/service/cli/CLIServiceTest.java cd9d99a service/src/test/org/apache/hive/service/cli/thrift/ThriftCLIServiceTest.java ff7166d Diff: https://reviews.apache.org/r/15151/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: [ANNOUNCE] New Hive Committer and PMC Member - Lefty Leverenz

2013-11-17 Thread Vaibhav Gumashta
Awesome! Congrats Lefty! On Sun, Nov 17, 2013 at 12:06 AM, Thejas Nair the...@hortonworks.comwrote: Congrats Lefty! On Sat, Nov 16, 2013 at 9:20 PM, Carl Steinbach c...@apache.org wrote: The Apache Hive PMC has voted to make Lefty Leverenz a committer and PMC member on the Apache Hive

Re: [ANNOUNCE] New Hive Committers - Jitendra Nath Pandey and Eric Hanson

2013-11-22 Thread Vaibhav Gumashta
Congrats guys! On Fri, Nov 22, 2013 at 11:54 PM, Vikram Dixit vik...@hortonworks.comwrote: Congrats to both of you! On Fri, Nov 22, 2013 at 9:34 AM, Jason Dere jd...@hortonworks.com wrote: Congrats! On Nov 22, 2013, at 2:25 AM, Biswajit Nayak biswajit.na...@inmobi.com wrote:

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-12-04 Thread Vaibhav Gumashta
--- Thanks, Vaibhav Gumashta

Re: Review Request 15151: Better error reporting by async threads in HiveServer2

2013-12-16 Thread Vaibhav Gumashta
--- Thanks, Vaibhav Gumashta

Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks JDOPersistanceManager

2014-08-06 Thread Vaibhav Gumashta
-CREATION service/src/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java PRE-CREATION Diff: https://reviews.apache.org/r/23320/diff/ Testing --- Manual testing using Yourkit. Thanks, Vaibhav Gumashta

Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks JDOPersistanceManager

2014-08-06 Thread Vaibhav Gumashta
-CREATION service/src/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java PRE-CREATION Diff: https://reviews.apache.org/r/23320/diff/ Testing --- Manual testing using Yourkit. Thanks, Vaibhav Gumashta

Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks JDOPersistanceManager

2014-08-06 Thread Vaibhav Gumashta
/ThreadFactoryWithGarbageCleanup.java PRE-CREATION service/src/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java PRE-CREATION Diff: https://reviews.apache.org/r/23320/diff/ Testing --- Manual testing using Yourkit. Thanks, Vaibhav Gumashta

Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks JDOPersistanceManager

2014-08-11 Thread Vaibhav Gumashta
/HiveSessionImpl.java https://reviews.apache.org/r/23320/#comment87765 I'll move this back to HiveSessionImpl#open as this won't pick the doAs setting since open goes through the appropriate proxy (which has UGI.doAs). - Vaibhav Gumashta On Aug. 6, 2014, 4:11 p.m., Vaibhav Gumashta wrote

Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks JDOPersistanceManager

2014-08-12 Thread Vaibhav Gumashta
, visit: https://reviews.apache.org/r/23320/#review49832 --- On Aug. 6, 2014, 4:11 p.m., Vaibhav Gumashta wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks JDOPersistanceManager

2014-08-12 Thread Vaibhav Gumashta
/ThreadFactoryWithGarbageCleanup.java PRE-CREATION service/src/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java PRE-CREATION Diff: https://reviews.apache.org/r/23320/diff/ Testing --- Manual testing using Yourkit. Thanks, Vaibhav Gumashta

Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks JDOPersistanceManager

2014-08-25 Thread Vaibhav Gumashta
: https://reviews.apache.org/r/23320/diff/ Testing --- Manual testing using Yourkit. Thanks, Vaibhav Gumashta

Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks JDOPersistanceManager

2014-08-26 Thread Vaibhav Gumashta
/apache/hive/service/cli/session/TestSessionGlobalInitFile.java 66fc1fc Diff: https://reviews.apache.org/r/23320/diff/ Testing --- Manual testing using Yourkit. Thanks, Vaibhav Gumashta

Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks JDOPersistanceManager

2014-08-26 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23320/#review51558 --- On Aug. 26, 2014, 5:10 p.m., Vaibhav Gumashta wrote

Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-02 Thread Vaibhav Gumashta
/ Testing --- Manual testing + test cases. Thanks, Vaibhav Gumashta

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-07 Thread Vaibhav Gumashta
. To reply, visit: https://reviews.apache.org/r/25245/#review52116 --- On Sept. 2, 2014, 10:05 a.m., Vaibhav Gumashta wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-07 Thread Vaibhav Gumashta
/service/cli/session/TestSessionGlobalInitFile.java 66fc1fc Diff: https://reviews.apache.org/r/25245/diff/ Testing --- Manual testing + test cases. Thanks, Vaibhav Gumashta

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-07 Thread Vaibhav Gumashta
://reviews.apache.org/r/25245/diff/ Testing --- Manual testing + test cases. Thanks, Vaibhav Gumashta

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-07 Thread Vaibhav Gumashta
://reviews.apache.org/r/25245/diff/ Testing (updated) --- Manual testing. Thanks, Vaibhav Gumashta

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-08 Thread Vaibhav Gumashta
.java 124996c service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java 66fc1fc Diff: https://reviews.apache.org/r/25245/diff/ Testing --- Manual testing. Thanks, Vaibhav Gumashta

Review Request 25460: Recursive root scratch directory creation is not using hdfs umask properly

2014-09-08 Thread Vaibhav Gumashta
/Utilities.java 5bbf3f6 ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 47fe508 Diff: https://reviews.apache.org/r/25460/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 25460: Recursive root scratch directory creation is not using hdfs umask properly

2014-09-09 Thread Vaibhav Gumashta
5dce16f ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 5bbf3f6 ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 08f149a Diff: https://reviews.apache.org/r/25460/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 25460: Recursive root scratch directory creation is not using hdfs umask properly

2014-09-09 Thread Vaibhav Gumashta
5dce16f ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 5bbf3f6 ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 08f149a Diff: https://reviews.apache.org/r/25460/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 25460: Recursive root scratch directory creation is not using hdfs umask properly

2014-09-09 Thread Vaibhav Gumashta
://reviews.apache.org/r/25460/#review52795 --- On Sept. 9, 2014, 11:06 p.m., Vaibhav Gumashta wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-10 Thread Vaibhav Gumashta
service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java 66fc1fc Diff: https://reviews.apache.org/r/25245/diff/ Testing --- Manual testing. Thanks, Vaibhav Gumashta

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-10 Thread Vaibhav Gumashta
--- On Sept. 10, 2014, 9:43 p.m., Vaibhav Gumashta wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25245

Re: Timeline for release of Hive 0.14

2014-09-11 Thread Vaibhav Gumashta
Hi Vikram, Can we also add: https://issues.apache.org/jira/browse/HIVE-6799 https://issues.apache.org/jira/browse/HIVE-7935 to the list. Thanks, --Vaibhav On Wed, Sep 10, 2014 at 12:18 AM, Satish Mittal satish.mit...@inmobi.com wrote: Hi, Can you please include HIVE-7892 (Thrift Set type

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-11 Thread Vaibhav Gumashta
service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java 66fc1fc Diff: https://reviews.apache.org/r/25245/diff/ Testing --- Manual testing. Thanks, Vaibhav Gumashta

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-11 Thread Vaibhav Gumashta
://reviews.apache.org/r/25245/#comment92378 I'll get rid of this import - leftover from different things I was trying. service/src/java/org/apache/hive/service/cli/CLIService.java https://reviews.apache.org/r/25245/#comment92379 Will get rid of this too. - Vaibhav Gumashta On Sept

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-11 Thread Vaibhav Gumashta
: https://reviews.apache.org/r/25245/#review53067 --- On Sept. 11, 2014, 1:08 p.m., Vaibhav Gumashta wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-11 Thread Vaibhav Gumashta
/#review53095 --- On Sept. 11, 2014, 1:08 p.m., Vaibhav Gumashta wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25245

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-11 Thread Vaibhav Gumashta
, Vaibhav Gumashta

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-12 Thread Vaibhav Gumashta
service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java 66fc1fc Diff: https://reviews.apache.org/r/25245/diff/ Testing --- Manual testing. Thanks, Vaibhav Gumashta

Re: [ANNOUNCE] New Hive Committer - Eugene Koifman

2014-09-12 Thread Vaibhav Gumashta
Congrats Eugene! On Fri, Sep 12, 2014 at 3:35 PM, Carl Steinbach c...@apache.org wrote: The Apache Hive PMC has voted to make Eugene Koifman a committer on the Apache Hive Project. Please join me in congratulating Eugene! Thanks. - Carl -- CONFIDENTIALITY NOTICE NOTICE: This message

Re: Timeline for the Hive 0.13 release?

2014-03-04 Thread Vaibhav Gumashta
I'd like to have the following go in: HIVE-4764 [Support Kerberos HTTP authentication for HiveServer2 running in http mode] https://issues.apache.org/jira/browse/HIVE-4764 HIVE-6306 [HiveServer2 running in http mode should support for doAs functionality]

Re: Proposal to switch to pull requests

2014-03-07 Thread Vaibhav Gumashta
+1 for moving to git! Thanks, --Vaibhav On Fri, Mar 7, 2014 at 9:46 AM, Prasad Mujumdar pras...@cloudera.comwrote: while (true) { +1 } +1 // another, just in case ;) thanks Prasad On Fri, Mar 7, 2014 at 6:47 AM, kulkarni.swar...@gmail.com kulkarni.swar...@gmail.com

Re: Review Request 18185: Support Kerberos HTTP authentication for HiveServer2 running in http mode

2014-03-09 Thread Vaibhav Gumashta
Diff: https://reviews.apache.org/r/18185/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 18185: Support Kerberos HTTP authentication for HiveServer2 running in http mode

2014-03-09 Thread Vaibhav Gumashta
beeline in a kerberos setup. Thanks, Vaibhav Gumashta

Re: Review Request 18185: Support Kerberos HTTP authentication for HiveServer2 running in http mode

2014-03-10 Thread Vaibhav Gumashta
/18185/diff/ Testing --- Using beeline in a kerberos setup. Thanks, Vaibhav Gumashta

Re: Timeline for the Hive 0.13 release?

2014-03-11 Thread Vaibhav Gumashta
Can you please consider the following: https://issues.apache.org/jira/browse/HIVE-6602 (committed to trunk), https://issues.apache.org/jira/browse/HIVE-6512, https://issues.apache.org/jira/browse/HIVE-6068, https://issues.apache.org/jira/browse/HIVE-6580. Most of them are bug fixes. Thanks,

Re: Review Request 13845: HIVE-5155: Support secure proxy user access to HiveServer2

2014-03-12 Thread Vaibhav Gumashta
cleanup, but it might involve more work. HIVE-6312 aims to do that (patch available). I'm not sure if doing doAs twice will lead to any new issues (I don't think so). - Vaibhav Gumashta On March 10, 2014, 6:39 p.m., Prasad Mujumdar wrote

Re: Timeline for the Hive 0.13 release?

2014-03-12 Thread Vaibhav Gumashta
-6625 is a minor patch on top of it. Thanks a lot! On Tue, Mar 11, 2014 at 1:17 PM, Harish Butani hbut...@hortonworks.comwrote: ok with the first 3. HIVE-6068 doesn't have a patch yet. Can this be deferred? On Mar 11, 2014, at 12:06 PM, Vaibhav Gumashta vgumas...@hortonworks.com wrote

Re: Review Request 17437: doAs with plain sasl auth should be session aware

2014-03-12 Thread Vaibhav Gumashta
SessionManager is a good idea. A number of other patches seem to rely on this. - Vaibhav Gumashta On Jan. 28, 2014, 1:21 a.m., Navis Ryu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org

Re: Review Request 18185: Support Kerberos HTTP authentication for HiveServer2 running in http mode

2014-03-13 Thread Vaibhav Gumashta
shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java 1f24a94 shims/common/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java e69373a Diff: https://reviews.apache.org/r/18185/diff/ Testing --- Using beeline in a kerberos setup. Thanks, Vaibhav

Re: Review Request 18185: Support Kerberos HTTP authentication for HiveServer2 running in http mode

2014-03-14 Thread Vaibhav Gumashta
. Thanks, Vaibhav Gumashta

Re: Timeline for the Hive 0.13 release?

2014-03-14 Thread Vaibhav Gumashta
Harish, Can we have this in as well: https://issues.apache.org/jira/browse/HIVE-6660. Blocker bug in my opinion. Thanks, --Vaibhav On Fri, Mar 14, 2014 at 2:21 PM, Thejas Nair the...@hortonworks.com wrote: Harish, Can you also include HIVE-6673

Review Request 19328: HiveServer2 running in http mode should support trusted proxy access

2014-03-17 Thread Vaibhav Gumashta
/ Testing --- Thanks, Vaibhav Gumashta

Review Request 19332: Refactor ThriftBinaryCLIService and ThriftHttpCLIService tests.

2014-03-17 Thread Vaibhav Gumashta
/org/apache/hive/service/cli/thrift/TestThriftHttpCLIService.java 43f92a3 service/src/test/org/apache/hive/service/cli/thrift/ThriftCLIServiceTest.java 21dc63b Diff: https://reviews.apache.org/r/19332/diff/ Testing --- Thanks, Vaibhav Gumashta

Review Request 19395: JDBC cancel will not work with current HiveServer2

2014-03-19 Thread Vaibhav Gumashta
/hive/service/cli/operation/SQLOperation.java ace791a Diff: https://reviews.apache.org/r/19395/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 19395: JDBC cancel will not work with current HiveServer2

2014-03-19 Thread Vaibhav Gumashta
, 2014, 11:02 a.m., Vaibhav Gumashta wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19395/ --- (Updated March 19, 2014, 11:02 a.m

Re: Review Request 19395: JDBC cancel will not work with current HiveServer2

2014-03-20 Thread Vaibhav Gumashta
://reviews.apache.org/r/19395/diff/ Testing (updated) --- Added a new test to TestJdbcDriver2 and did testing with standalone jdbc program. Thanks, Vaibhav Gumashta

Re: Review Request 19395: JDBC cancel will not work with current HiveServer2

2014-03-20 Thread Vaibhav Gumashta
testing with standalone jdbc program. Thanks, Vaibhav Gumashta

Re: Review Request 19395: JDBC cancel will not work with current HiveServer2

2014-03-20 Thread Vaibhav Gumashta
--- On March 20, 2014, 7:42 a.m., Vaibhav Gumashta wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19395

Re: Review Request 19599: HiveServer2 secure thrift/http authentication needs to support SPNego

2014-03-25 Thread Vaibhav Gumashta
than these, looks good to me. service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java https://reviews.apache.org/r/19599/#comment70778 Can you verify if this is required at all? - Vaibhav Gumashta On March 25, 2014, 1:23 a.m., dilli dorai wrote

Review Request 19659: Hive printing debug information in stdout after the end of CLI session

2014-03-25 Thread Vaibhav Gumashta
--- Using CLI Thanks, Vaibhav Gumashta

Re: Review Request 19659: Hive printing debug information in stdout after the end of CLI session

2014-03-25 Thread Vaibhav Gumashta
/hive/common/JavaUtils.java 7d3980f Diff: https://reviews.apache.org/r/19659/diff/ Testing --- Using CLI Thanks, Vaibhav Gumashta

Re: Review Request 19801: review request for HIVE-6738, HiveServer2 secure Thrift/HTTP needs to accept doAs parameter from proxying intermediary

2014-03-28 Thread Vaibhav Gumashta
/19801/#comment71349 Similar to the previous comment: I think it'll be good to change the method name to getProxyUserNameParam from getDoAsQueryParam. - Vaibhav Gumashta On March 28, 2014, 9:08 p.m., dilli dorai wrote

Re: Review Request 19801: review request for HIVE-6738, HiveServer2 secure Thrift/HTTP needs to accept doAs parameter from proxying intermediary

2014-03-28 Thread Vaibhav Gumashta
(HiveConf.ConfVars.HIVE_SERVER2_TRANSPORT_MODE).equalsIgnoreCase(http)) { } - Vaibhav Gumashta On March 28, 2014, 9:08 p.m., dilli dorai wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19801

Review Request 19814: HiveServer2 in http mode might send same kerberos client ticket in case of concurrent requests resulting in server throwing a replay exception

2014-03-28 Thread Vaibhav Gumashta
tested on a secure cluster Thanks, Vaibhav Gumashta

Review Request 19827: HiveStatement client transport lock should unlock in finally block.

2014-03-29 Thread Vaibhav Gumashta
, Vaibhav Gumashta

  1   2   3   4   5   6   7   8   9   10   >