Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65478/#review197464 --- Ship it! Thanks for the changes Ferdinand. Patch looks good to

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65478/ --- (Updated Feb. 14, 2018, 9:51 a.m.) Review request for hive. Repository:

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65478/ --- (Updated Feb. 14, 2018, 9:30 a.m.) Review request for hive. Repository:

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65478/ --- (Updated Feb. 13, 2018, 3:43 p.m.) Review request for hive. Repository:

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

> On Feb. 13, 2018, 8:50 a.m., Vihang Karajgaonkar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/VectorizedPrimitiveColumnReader.java > > Lines 253-254 (original), 255-256 (patched) > > > > > >

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65478/ --- (Updated Feb. 13, 2018, 3:34 p.m.) Review request for hive. Repository:

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

> On Feb. 13, 2018, 12:50 a.m., Vihang Karajgaonkar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/VectorizedPrimitiveColumnReader.java > > Lines 253-254 (original), 255-256 (patched) > > > > > >

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

> On Feb. 13, 2018, 8:50 a.m., Vihang Karajgaonkar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/VectorizedPrimitiveColumnReader.java > > Lines 253-254 (original), 255-256 (patched) > > > > > >

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65478/#review197313 --- Fix it, then Ship it! Overall the patch looks good to me. Some

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65478/ --- (Updated Feb. 12, 2018, 4:25 p.m.) Review request for hive. Repository:

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65478/ --- (Updated Feb. 9, 2018, 8:07 p.m.) Review request for hive. Repository:

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

> On Feb. 6, 2018, 3:06 p.m., Vihang Karajgaonkar wrote: > > ql/src/test/queries/clientpositive/schema_evol_par_vec_table.q > > Lines 71 (patched) > > > > > > Can you please test using timestamps as well.

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

> On Feb. 6, 2018, 3:06 p.m., Vihang Karajgaonkar wrote: > > ql/src/test/queries/clientpositive/schema_evol_par_vec_table.q > > Lines 71 (patched) > > > > > > Can you please test using timestamps as well.

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65478/#review196867 ---

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

> On Feb. 6, 2018, 1:46 a.m., Vihang Karajgaonkar wrote: > > Thanks Vihang for your review. Comments left below. > On Feb. 6, 2018, 1:46 a.m., Vihang Karajgaonkar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/ParquetDataColumnReaderFactory.java > > Lines 24 (patched) > >

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

> On Feb. 5, 2018, 5:46 p.m., Vihang Karajgaonkar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/ParquetDataColumnReaderFactory.java > > Lines 24 (patched) > > > > > > Do we need to override the

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65478/#review196718 ---

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65478/ --- (Updated Feb. 5, 2018, 4:46 p.m.) Review request for hive. Repository:

Re: Review Request 65478: HIVE-18553 VectorizedParquetReader fails after adding a new column to table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65478/#review196793 ---