[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2014-02-26 Thread Steven Willis (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13913455#comment-13913455
 ] 

Steven Willis commented on HIVE-5112:
-

The hive downloads page says that hive-0.12.0 is compatible with hadoop-2.x.y . 
However, I have hive-0.12.0 installed with hadoop-2.2.0 and I get the same 
error that [~ashahab] has. I noticed that if I moved all the 
{{protobuf-java-2.5.0.jar}} files under hadoop's lib dirs to 
{{protobuf-java-2.5.0.jar.bak}}, then I didn't get the error.

It looks like protobuf 2.5.0 is not compatible with generated code from 2.4.1, 
and if I move all of the newer jars out of the way, then the 
{{protobuf-java-2.4.1.jar}} file is found under hive's lib dir.

I think there needs to be a new release (0.12.1 or 0.13.0) and/or the 
compatibility note on the downloads page needs to be adjusted.

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Fix For: 0.13.0

 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2014-02-26 Thread Abin Shahab (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13913481#comment-13913481
 ] 

Abin Shahab commented on HIVE-5112:
---

Steven, you can try compiling the orc related files with the correct version of 
protobuf(2.5.0).

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Fix For: 0.13.0

 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2014-02-03 Thread Abin Shahab (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13890348#comment-13890348
 ] 

Abin Shahab commented on HIVE-5112:
---

Hi All,
I notice the following exception when we try to use hive-0.12 orcfile format 
with hadoop-2.2. This goes away when we use it with hadoop-2.0.5. My hunch is 
that this is caused by the protobuf-2.4.1 code in hive-0.12.
Should the bug be reopened?
Error: java.lang.RuntimeException: Hive Runtime Error while closing operators
at 
org.apache.hadoop.hive.ql.exec.mr.ExecMapper.close(ExecMapper.java:240)
at org.apache.hadoop.mapred.MapRunner.run(MapRunner.java:61)
at org.apache.hadoop.mapred.MapTask.runOldMapper(MapTask.java:429)
at org.apache.hadoop.mapred.MapTask.run(MapTask.java:341)
at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:162)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:415)
at 
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1491)
at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:157)
Caused by: java.lang.UnsupportedOperationException: This is supposed to be 
overridden by subclasses.
at 
com.google.protobuf.GeneratedMessage.getUnknownFields(GeneratedMessage.java:180)
at 
org.apache.hadoop.hive.ql.io.orc.OrcProto$Type.getSerializedSize(OrcProto.java:7281)
at 
com.google.protobuf.CodedOutputStream.computeMessageSizeNoTag(CodedOutputStream.java:749)
at 
com.google.protobuf.CodedOutputStream.computeMessageSize(CodedOutputStream.java:530)
at 
org.apache.hadoop.hive.ql.io.orc.OrcProto$Footer.getSerializedSize(OrcProto.java:9054)
at 
org.apache.hadoop.hive.ql.io.orc.OrcProto$Footer.writeTo(OrcProto.java:9007)
at 
org.apache.hadoop.hive.ql.io.orc.WriterImpl.writeFooter(WriterImpl.java:1804)
at 
org.apache.hadoop.hive.ql.io.orc.WriterImpl.close(WriterImpl.java:1869)
at 
org.apache.hadoop.hive.ql.io.orc.OrcOutputFormat$OrcRecordWriter.close(OrcOutputFormat.java:95)
at 
org.apache.hadoop.hive.ql.exec.FileSinkOperator$FSPaths.closeWriters(FileSinkOperator.java:181)
at 
org.apache.hadoop.hive.ql.exec.FileSinkOperator.closeOp(FileSinkOperator.java:866)
at org.apache.hadoop.hive.ql.exec.Operator.close(Operator.java:596)
at org.apache.hadoop.hive.ql.exec.Operator.close(Operator.java:613)
at org.apache.hadoop.hive.ql.exec.Operator.close(Operator.java:613)
at org.apache.hadoop.hive.ql.exec.Operator.close(Operator.java:613)
at 
org.apache.hadoop.hive.ql.exec.mr.ExecMapper.close(ExecMapper.java:207)


 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Fix For: 0.13.0

 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2014-01-16 Thread Gordon Wang (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874390#comment-13874390
 ] 

Gordon Wang commented on HIVE-5112:
---

Hi folks,
I find that if I generate Complex.proto with protobuf 2.5.0. 
TestProtocolBuffersObjectInspectors fails. I think this jira does not upgrade 
protobuf completely.
So I file a jira HIVE-6219 to track this. If this is really a bug, shall we 
reopen this jira ?

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Fix For: 0.13.0

 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-09-13 Thread Sushanth Sowmyan (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766251#comment-13766251
 ] 

Sushanth Sowmyan commented on HIVE-5112:



Compiled code for protobuf is supposed to be backward-compatible across 
protobuf releases(old classes with new protobuf jar) . The only case where 
protobuf backward compatibility is supposed to bite you is when you have 
generated code with an old protobuf jar that you're trying to compile with a 
new protobuf jar. It's supposed to cause compile-time hassles, not runtime 
hassles.

So, I wanted to see if it was a difficult task upgrading hive-protobuf to a 
newer protobuf as well and so, tried to check out hive-protobuf to test to see 
if it was a simple update to 2.5 for that. I see only one .proto file, and it's 
used by the tests. I was able to generate new code for it that compiles, but I 
get test failures all over from the version of hive_test that I compiled 
(return code 9 and all that)

That got me thinking - if the problem comes from a protobuf 2.5 is not 
production-certified stance, then shouldn't hive-0.12 also not match 
production-certification?



 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Fix For: 0.13.0

 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-09-13 Thread Thejas M Nair (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766292#comment-13766292
 ] 

Thejas M Nair commented on HIVE-5112:
-

There are discussions in the hadoop mailing lists about having the hadoop 2 GA 
in few weeks. So I think it is worthwhile that we aim to have 0.12 to be 
compatible with the hadoop 2 line as well.

[~appodictic] I don't think your -1 is reasonable for the following reasons- 
- I don't consider it feasible to stop upgrading jars in hive because the old 
version of jar was used by some udf/serde/inputformat. (But I do think that in 
long term we need to explore ways of isolating the hive jars/classes vs user 
jars/classes) 
- In the example you cited, as Sushanth mentioned, you don't need to make any 
code changes to use protobuf 2.5. I suspect most users who are using protobuf 
with dynamic schema would not choose to work with generated code. So the number 
of users this is likely to affect is small.
- The upgrade is inevitable. With it being in trunk, it is in its way into the 
0.13 release.

I request you to please reconsider your -1. 


 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Fix For: 0.13.0

 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-09-13 Thread Edward Capriolo (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766693#comment-13766693
 ] 

Edward Capriolo commented on HIVE-5112:
---

{quote}
The upgrade is inevitable. With it being in trunk, it is in its way into the 
0.13 release.
{quote}
Yes but this will give users time to prepare for it. Which is what rushing the 
upgrade will take away.

{quote}
I don't consider it feasible to stop upgrading jars in hive because the old 
version of jar was used by some udf/serde/inputformat. 
{quote}
You want this upgrade because it effects the OCR input formats you care about. 
It effects new beta version that you want to support. 

Q. Why don't we remove the dependency from hive all together? A. We can't 
because it's baked via an input format.

{quote}
But I do think that in long term we need to explore ways of isolating the hive 
jars/classes vs user jars/classes.
{quote}
But why do that? We can just bake in all the things we care about! Then 
whenever it screws someone up we can just say long term we might research a 
way not to inconvenience people, but for now your inconvenienced

I don't care really take away my -1. I would not want the to inconvenience the 
0 people running future-ware versions in production.












 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Fix For: 0.13.0

 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-09-13 Thread Alan Gates (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767152#comment-13767152
 ] 

Alan Gates commented on HIVE-5112:
--

Sorry Ed, could you clarify.  I'm not sure if you meant the last sentence to be 
I don't care, take away my -1 or I don't care to take away my -1.  

In general I agree with Thejas.  Making Hive jar upgrades depend on the 
transitive closure of versions users of Hive depend will mean it can never 
upgrade.  I don't think it's fair to depict Hadoop 2.1 as future ware.  Making 
Hive work well with Hadoop 2 will be very important going forward.

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Fix For: 0.13.0

 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-09-13 Thread Ashutosh Chauhan (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767151#comment-13767151
 ] 

Ashutosh Chauhan commented on HIVE-5112:


bq. I don't care really take away my -1

Are you still -1 ?

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Fix For: 0.13.0

 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-09-12 Thread Thejas M Nair (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13765864#comment-13765864
 ] 

Thejas M Nair commented on HIVE-5112:
-

Users that are using protobuf and hive would need to upgrade at some point. If 
we don't do it in 0.12, it would happen in 0.13 (3-4 months down the line). 
Rest of the hadoop ecosystem is moving fast to adopt protobuf 2.5 . I think it 
will be useful for all the work that is going on to get the ecosystem on hadoop 
2.x .


 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Fix For: 0.13.0

 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-09-12 Thread Sushanth Sowmyan (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13765916#comment-13765916
 ] 

Sushanth Sowmyan commented on HIVE-5112:


I'd also much rather have this in 0.12. Without this in 0.12, we either block 
HIVE-4388 inclusion in 0.12, or require two versions of HIVE-4388, one with 
protobuf 2.4 and one with 2.5. And that jira blocks being able to work with 
hbase 0.96, which is in an RC stage, and past beta.

The term beta, imo, is not so much about experimentation nowadays as it is 
about being a preview.

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Fix For: 0.13.0

 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-09-11 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764086#comment-13764086
 ] 

Hudson commented on HIVE-5112:
--

ABORTED: Integrated in Hive-trunk-hadoop2 #420 (See 
[https://builds.apache.org/job/Hive-trunk-hadoop2/420/])
HIVE-5112 : Upgrade protobuf to 2.5 from 2.4 (Owen O'malley and Brock Noland 
via Ashutosh Chauhan) (hashutosh: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1521520)
* /hive/trunk/build.properties
* /hive/trunk/hcatalog/pom.xml
* /hive/trunk/ivy/libraries.properties
* 
/hive/trunk/ql/src/gen/protobuf/gen-java/org/apache/hadoop/hive/ql/io/orc/OrcProto.java


 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Fix For: 0.13.0

 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-09-11 Thread Thejas M Nair (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764985#comment-13764985
 ] 

Thejas M Nair commented on HIVE-5112:
-

Should we include this for 0.12 ? Without this change we won't have support for 
hadoop 2.1 beta for sometime.


 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Fix For: 0.13.0

 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-09-11 Thread Edward Capriolo (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13765015#comment-13765015
 ] 

Edward Capriolo commented on HIVE-5112:
---

I am -1 on building this into 0.12. We have infrastructure currently requiring 
protobuf 2.4 

https://github.com/edwardcapriolo/hive-protobuf/

People working with 2.1 beta, are working with something called called beta, so 
it is easier for them to adjust their kits then people who already have 
production critical things.

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Fix For: 0.13.0

 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-09-10 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763281#comment-13763281
 ] 

Hudson commented on HIVE-5112:
--

FAILURE: Integrated in Hive-trunk-hadoop2-ptest #92 (See 
[https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/92/])
HIVE-5112 : Upgrade protobuf to 2.5 from 2.4 (Owen O'malley and Brock Noland 
via Ashutosh Chauhan) (hashutosh: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1521520)
* /hive/trunk/build.properties
* /hive/trunk/hcatalog/pom.xml
* /hive/trunk/ivy/libraries.properties
* 
/hive/trunk/ql/src/gen/protobuf/gen-java/org/apache/hadoop/hive/ql/io/orc/OrcProto.java


 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Fix For: 0.13.0

 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-09-10 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763410#comment-13763410
 ] 

Hudson commented on HIVE-5112:
--

FAILURE: Integrated in Hive-trunk-hadoop1-ptest #160 (See 
[https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/160/])
HIVE-5112 : Upgrade protobuf to 2.5 from 2.4 (Owen O'malley and Brock Noland 
via Ashutosh Chauhan) (hashutosh: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1521520)
* /hive/trunk/build.properties
* /hive/trunk/hcatalog/pom.xml
* /hive/trunk/ivy/libraries.properties
* 
/hive/trunk/ql/src/gen/protobuf/gen-java/org/apache/hadoop/hive/ql/io/orc/OrcProto.java


 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Fix For: 0.13.0

 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-09-10 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763926#comment-13763926
 ] 

Hudson commented on HIVE-5112:
--

SUCCESS: Integrated in Hive-trunk-h0.21 #2323 (See 
[https://builds.apache.org/job/Hive-trunk-h0.21/2323/])
HIVE-5112 : Upgrade protobuf to 2.5 from 2.4 (Owen O'malley and Brock Noland 
via Ashutosh Chauhan) (hashutosh: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1521520)
* /hive/trunk/build.properties
* /hive/trunk/hcatalog/pom.xml
* /hive/trunk/ivy/libraries.properties
* 
/hive/trunk/ql/src/gen/protobuf/gen-java/org/apache/hadoop/hive/ql/io/orc/OrcProto.java


 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Fix For: 0.13.0

 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-09-09 Thread Ashutosh Chauhan (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13762345#comment-13762345
 ] 

Ashutosh Chauhan commented on HIVE-5112:


+1

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-09-09 Thread Sushanth Sowmyan (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13762403#comment-13762403
 ] 

Sushanth Sowmyan commented on HIVE-5112:


I noticed two things out-of the ordinary when I tested this:

  * Firstly, generated code from serde/if/test/complexpb.proto was not updated. 
In general, I noticed other tests fail due to a protobuf jar update, but I 
don't see that TestProtocolBuffersObjectInspectors (the associated test with 
this .proto) fails, so I guess it's good.
  * Second, the protobuf generated code I'm able to generate is 
different(descriptorData is different) from the one attached on this patch. 
However, tests still pass.

Overall, I'm still +1 on this since tests pass.

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-09-09 Thread Sushanth Sowmyan (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13762410#comment-13762410
 ] 

Sushanth Sowmyan commented on HIVE-5112:


(Edit : confirming that I did use protocol buffers 2.5.0 when testing this)

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-09-09 Thread Sushanth Sowmyan (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13762490#comment-13762490
 ] 

Sushanth Sowmyan commented on HIVE-5112:


(Also, looking further at use of Complexpb, it looks like the only purpose of 
Complexpb in this case is to test using TestProtocolBuffersObjectInspectors, 
that the object inspector works correctly. And as long as that's succeeding, we 
have no point of concern with not regenerating that.)

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-09-06 Thread Sushanth Sowmyan (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760652#comment-13760652
 ] 

Sushanth Sowmyan commented on HIVE-5112:


FYI, this patch in combination with HIVE-4388 (hbase handler update) causes a 
failure that is fixed by HIVE-5136. Depending on whether this gets committed 
first or HIVE-4388, we need to commit HIVE-5136 along with the other.

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-09-06 Thread Brock Noland (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760656#comment-13760656
 ] 

Brock Noland commented on HIVE-5112:


[~appodictic], [~hagleitn] or [~owen.omalley] does one of you want to take a 
look at this?

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-09-06 Thread Sushanth Sowmyan (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760684#comment-13760684
 ] 

Sushanth Sowmyan commented on HIVE-5112:


From the phabricator review, I think this patch has Gunther's +1. I'm willing 
to test and look through it as well.

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-09-06 Thread Brock Noland (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760712#comment-13760712
 ] 

Brock Noland commented on HIVE-5112:


Thanks Sushanth, it'd be great if you took a look.  I don't think Gunther's +1 
is valid since the patch was modified (upgrade hadoop-2 to beta) since the +1.

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-09-06 Thread Edward Capriolo (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760714#comment-13760714
 ] 

Edward Capriolo commented on HIVE-5112:
---

One question my ptotobuf input format is not part of hive yet. It is github
and on version 2.4 . I am guessing i will have to make a lock step upgrade.

On Friday, September 6, 2013, Sushanth Sowmyan (JIRA) j...@apache.org
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760684#comment-13760684]
willing to test and look through it as well.
administrators


 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-09-03 Thread Hive QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13757012#comment-13757012
 ] 

Hive QA commented on HIVE-5112:
---



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12601174/HIVE-5112.2.patch

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 2906 tests executed
*Failed tests:*
{noformat}
org.apache.hcatalog.fileformats.TestOrcDynamicPartitioned.testHCatDynamicPartitionedTableMultipleTask
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/593/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/593/console

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests failed with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Attachments: HIVE-5112.2.patch, HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-08-29 Thread Brock Noland (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13753839#comment-13753839
 ] 

Brock Noland commented on HIVE-5112:


With 2.1.0-beta released, should we move ahead on this one?

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Attachments: HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-08-21 Thread Hive QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13746801#comment-13746801
 ] 

Hive QA commented on HIVE-5112:
---



{color:green}Overall{color}: +1 all checks pass

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12599001/HIVE-5112.D12429.1.patch

{color:green}SUCCESS:{color} +1 2895 tests passed

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/496/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/496/console

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Attachments: HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-08-21 Thread Gunther Hagleitner (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13746868#comment-13746868
 ] 

Gunther Hagleitner commented on HIVE-5112:
--

I believe updating the dependency and leaving the generated code won't work. 
The lib isn't backwards compatible wrt to old generated code. I think the only 
real guarantee around compat is on the wire protocol.

With that: I think waiting until 2.1.0-beta and switching to that with proto 
2.5 at the same time is still the best option.

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Attachments: HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-08-20 Thread Phabricator (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13745247#comment-13745247
 ] 

Phabricator commented on HIVE-5112:
---

hagleitn has commented on the revision HIVE-5112 [jira] Upgrade protobuf to 
2.5 from 2.4.

  LGTM: +1

REVISION DETAIL
  https://reviews.facebook.net/D12429

To: JIRA, omalley
Cc: hagleitn


 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Attachments: HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-08-20 Thread Gunther Hagleitner (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13745259#comment-13745259
 ] 

Gunther Hagleitner commented on HIVE-5112:
--

Code looks good - some questions though:

- Is this going to work with 20S, where hadoop still relies on protobuf 2.4?
- Is the binary orc format going to be ok with the upgrade (orc files generated 
with 2.4, reading with 2.5)?

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Attachments: HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-08-20 Thread Edward Capriolo (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13745261#comment-13745261
 ] 

Edward Capriolo commented on HIVE-5112:
---

2.4 and 2.5 generated byte-code for protobuf is not the same compatible. 

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Attachments: HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-08-20 Thread Edward Capriolo (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13745282#comment-13745282
 ] 

Edward Capriolo commented on HIVE-5112:
---

In the maven branch I am going to push to remove generated source code. It 
helps avoid issues like this. 

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Attachments: HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-08-20 Thread Gunther Hagleitner (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13745325#comment-13745325
 ] 

Gunther Hagleitner commented on HIVE-5112:
--

[~appodictic] I am all for avoiding generated code, that's great stuff. 
However, in this case the question is about compatibility.

I think I've found answer to my 2 questions:

a) Hadoop 1 line doesn't depend on protobuf. So my 1st question is irrelevant. 
It will work.
b) 2.4 and 2.5 are compatible on the wire, so the new code will be able to read 
old orc files.

So, I think the change is good. 


 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Attachments: HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-08-20 Thread Edward Capriolo (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13745333#comment-13745333
 ] 

Edward Capriolo commented on HIVE-5112:
---

If hadoop 0.20 / 1 does not have a protobuf jar we should be fine. Downstream 
applications compiled against ocr, or applications that put proto 2.4 in the 
classpath will have problems.

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Attachments: HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-08-20 Thread Gunther Hagleitner (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13745342#comment-13745342
 ] 

Gunther Hagleitner commented on HIVE-5112:
--

One more thing: We're building against hadoop 2.0.5-alpha. That still depends 
on protobuf 2.4 afaik. I think we should upgrade this patch to also update the 
hadoop.23 version to 2.1.0-beta. Obviously that means waiting until 2.1.0 comes 
out to commit this patch. Does that make sense?

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Attachments: HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-08-20 Thread Edward Capriolo (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13745386#comment-13745386
 ] 

Edward Capriolo commented on HIVE-5112:
---

It sounds like we need a type of shim. I can not see how it will work with with 
different jars on the classpath. If a hive gets compiled with proto-2.5 and 
then gets deployed to an earlier hadoop it probably will not work correctly.

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Attachments: HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-08-20 Thread Edward Capriolo (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13745391#comment-13745391
 ] 

Edward Capriolo commented on HIVE-5112:
---

I am amazingly surprised hive compiles correctly at all

{quote}
[edward@desksandra hive-trunk]$ find . -name antlr*
./build/dist/lib/antlr-runtime-3.4.jar
./build/ql/gen/antlr
./build/ivy/lib/default/antlr-runtime-3.4.jar
./build/ivy/lib/default/antlr-3.4.jar
./build/metastore/gen/antlr
./hcatalog/core/build/lib/test/antlr-runtime-3.4.jar
./hcatalog/core/build/lib/test/antlr-3.4.jar
./hcatalog/core/build/lib/test/antlr-2.7.7.jar
./hcatalog/core/build/lib/compile/antlr-runtime-3.4.jar
./hcatalog/core/build/lib/compile/antlr-3.4.jar
./hcatalog/core/build/lib/compile/antlr-2.7.7.jar
./hcatalog/webhcat/svr/build/lib/test/antlr-2.7.7.jar
./hcatalog/webhcat/svr/build/lib/provided/antlr-runtime-3.4.jar
./hcatalog/webhcat/svr/build/lib/provided/antlr-3.4.jar
./hcatalog/webhcat/java-client/build/lib/test/antlr-runtime-3.4.jar
./hcatalog/webhcat/java-client/build/lib/test/antlr-3.4.jar
./hcatalog/webhcat/java-client/build/lib/test/antlr-2.7.7.jar
./hcatalog/webhcat/java-client/build/lib/compile/antlr-runtime-3.4.jar
./hcatalog/webhcat/java-client/build/lib/compile/antlr-3.4.jar
./hcatalog/webhcat/java-client/build/lib/compile/antlr-2.7.7.jar
./hcatalog/server-extensions/build/lib/test/antlr-runtime-3.4.jar
./hcatalog/server-extensions/build/lib/test/antlr-3.4.jar
./hcatalog/server-extensions/build/lib/test/antlr-2.7.7.jar
./hcatalog/server-extensions/build/lib/compile/antlr-runtime-3.4.jar
./hcatalog/server-extensions/build/lib/compile/antlr-3.4.jar
./hcatalog/server-extensions/build/lib/compile/antlr-2.7.7.jar
./hcatalog/hcatalog-pig-adapter/build/lib/test/antlr-runtime-3.4.jar
./hcatalog/hcatalog-pig-adapter/build/lib/test/antlr-3.4.jar
./hcatalog/hcatalog-pig-adapter/build/lib/test/antlr-2.7.7.jar
./hcatalog/hcatalog-pig-adapter/build/lib/compile/antlr-runtime-3.4.jar
./hcatalog/hcatalog-pig-adapter/build/lib/compile/antlr-3.4.jar
./hcatalog/hcatalog-pig-adapter/build/lib/compile/antlr-2.7.7.jar
./hcatalog/storage-handlers/hbase/build/lib/test/antlr-runtime-3.4.jar
./hcatalog/storage-handlers/hbase/build/lib/test/antlr-3.4.jar
./hcatalog/storage-handlers/hbase/build/lib/test/antlr-2.7.7.jar
./hcatalog/storage-handlers/hbase/build/lib/compile/antlr-runtime-3.4.jar
./hcatalog/storage-handlers/hbase/build/lib/compile/antlr-3.4.jar
./hcatalog/storage-handlers/hbase/build/lib/compile/antlr-2.7.7.jar
{quote}

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Attachments: HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-08-20 Thread Owen O'Malley (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13745476#comment-13745476
 ] 

Owen O'Malley commented on HIVE-5112:
-

Obviously, part of what Maven helps with is finding where you are using 
inconsistent versions of libraries. We need that.

You can't really create a shim for protobuf. My understanding is that you can 
use:
* 2.5 generated code only with the 2.5 library
* 2.4 generated code with either the 2.4 or 2.5 library

Maybe we should update the dependency to 2.5, but leave the generated code as 
it is.

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Attachments: HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-5112) Upgrade protobuf to 2.5 from 2.4

2013-08-20 Thread Edward Capriolo (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13745522#comment-13745522
 ] 

Edward Capriolo commented on HIVE-5112:
---

[~owen.omalley] I think that is a good idea.

 Upgrade protobuf to 2.5 from 2.4
 

 Key: HIVE-5112
 URL: https://issues.apache.org/jira/browse/HIVE-5112
 Project: Hive
  Issue Type: Improvement
Reporter: Brock Noland
Assignee: Owen O'Malley
 Attachments: HIVE-5112.D12429.1.patch


 Hadoop and Hbase have both upgraded protobuf. We should as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira