Hi Daniel,
Yes, you are right. Looks like it doesn't work HIVE-1234.01-branch-3.patch
format. I think the reason it was done that way is because we use '-' in
the branch naming convention and its easier to parse the patch name to
determine the profile. I think it would be helpful to support both
Hi,
Thanks Zoltan for starting this discussion. I ran into this a couple times
lately.
I've just opened https://issues.apache.org/jira/browse/HIVE-20191 to
mitigate the
effect of a wrong submission. Since I was backporting from master, I did't
even
notice that the patches were applied on master.
It doesn't matter if you use a dot v/s a dash to separate the patch version
with the profile name (same as branch name but its technically different).
See https://issues.apache.org/jira/browse/HIVE-18885 as an example where I
had submitted both the naming styles and precommit picked it up. Having
Hello!
I've seen a few people running into some problems because the current patch
naming convention is a little bit odd:
HIVE-[.][-].patch
...so if you would like to submit patch #02 to branch-2:
A file named: HIVE-111.02-branch-2 patch should be uploaded (note that there is
a mandatory