Review Request 34040: Refactoring Windowing for sum() to pass WindowFrameDef instead of two numbers (1 for number of preceding and 1 for number of following)

2015-05-11 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34040/ --- Review request for hive. Repository: hive-git Description --- This is

Re: Review Request 34040: Refactoring Windowing for sum() to pass WindowFrameDef instead of two numbers (1 for number of preceding and 1 for number of following)

2015-05-11 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34040/#review83257 --- Mostly looks good. Few minor comments.

Re: Review Request 34040: Refactoring Windowing for sum() to pass WindowFrameDef instead of two numbers (1 for number of preceding and 1 for number of following)

2015-05-11 Thread Aihua Xu
On May 11, 2015, 6:41 p.m., Ashutosh Chauhan wrote: ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/WindowFrameDef.java, line 51 https://reviews.apache.org/r/34040/diff/1/?file=955309#file955309line51 Should this take into account direction information? e.g., for 3 precceding 2

Re: Review Request 34040: Refactoring Windowing for sum() to pass WindowFrameDef instead of two numbers (1 for number of preceding and 1 for number of following)

2015-05-11 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34040/ --- (Updated May 11, 2015, 8:08 p.m.) Review request for hive. Repository:

Re: Review Request 34040: Refactoring Windowing for sum() to pass WindowFrameDef instead of two numbers (1 for number of preceding and 1 for number of following)

2015-05-11 Thread Aihua Xu
On May 11, 2015, 6:41 p.m., Ashutosh Chauhan wrote: ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java, line 225 https://reviews.apache.org/r/34040/diff/1/?file=955315#file955315line225 d can't be null at this point. Don't need ternary operator. fixed. On