Re: Review Request 40976: [REFACTOR] Make physical compiler more type safe

2015-12-08 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40976/#review109416 --- My comments are well addressed. LGTM +! pending QA run. Thanks. -

Re: Review Request 40976: [REFACTOR] Make physical compiler more type safe

2015-12-08 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40976/ --- (Updated Dec. 8, 2015, 10:04 p.m.) Review request for hive and pengcheng

Re: Review Request 40976: [REFACTOR] Make physical compiler more type safe

2015-12-07 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40976/#review109223 --- Patch looks good to me. But I also find some other similar places

Review Request 40976: [REFACTOR] Make physical compiler more type safe

2015-12-04 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40976/ --- Review request for hive. Bugs: HIVE-12595