Re: Review Request 55156: Min-max runtime filtering

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55156/#review195780 ---

Re: Review Request 55156: Min-max runtime filtering

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55156/ --- (Updated Jan. 22, 2017, 10:11 p.m.) Review request for hive, Gopal V, Gunther

Re: Review Request 55156: Min-max runtime filtering

> On Jan. 19, 2017, 5:53 p.m., Jason Dere wrote: > > ql/src/test/queries/clientpositive/dynamic_semijoin_reduction.q, line 33 > > > > > > This still looks off in the latest version of the patch - line 28 sets > >

Re: Review Request 55156: Min-max runtime filtering

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55156/#review162321 --- ql/src/test/queries/clientpositive/dynamic_semijoin_reduction.q

Re: Review Request 55156: Min-max runtime filtering

> On Jan. 19, 2017, 12:07 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java, line 656 > > > > > > remove this Thanks for pointing this out. Taking out my name from it. >

Re: Review Request 55156: Min-max runtime filtering

> On Jan. 13, 2017, 11:54 p.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java, line 746 > > > > > > Since you're using SemiJoinCycleRemovalDueToMapsideJoins in all 4 rules > >

Re: Review Request 55156: Min-max runtime filtering

> On Jan. 13, 2017, 12:08 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java, line 582 > > > > > > This might be more appropriate on the FilterOperator, as I believe > > there

Re: Review Request 55156: Min-max runtime filtering

> On Jan. 6, 2017, 3:25 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java, > > line 1200 > > > > > > I think this change can be removed if we

Re: Review Request 55156: Min-max runtime filtering

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55156/#review162197 --- ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java

Re: Review Request 55156: Min-max runtime filtering

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55156/ --- (Updated Jan. 18, 2017, 8:42 p.m.) Review request for hive, Gopal V, Gunther

Re: Review Request 55156: Min-max runtime filtering

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55156/#review161608 --- ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java

Re: Review Request 55156: Min-max runtime filtering

> On Jan. 13, 2017, 12:08 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java, > > line 765 > > > > > > Maybe explain why the semijoin optimization should be removed

Re: Review Request 55156: Min-max runtime filtering

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55156/ --- (Updated Jan. 13, 2017, 9:51 p.m.) Review request for hive, Gopal V, Gunther

Re: Review Request 55156: Min-max runtime filtering

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55156/#review161398 --- ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java

Re: Review Request 55156: Min-max runtime filtering

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55156/ --- (Updated Jan. 11, 2017, 4:20 a.m.) Review request for hive, Gopal V, Gunther

Re: Review Request 55156: Min-max runtime filtering

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55156/ --- (Updated Jan. 10, 2017, 7:36 p.m.) Review request for hive, Gopal V, Gunther

Re: Review Request 55156: Min-max runtime filtering

> On Jan. 6, 2017, 3:25 a.m., Jason Dere wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 2840 > > > > > > This setting should probably default to false for the time being Will do it at

Re: Review Request 55156: Min-max runtime filtering

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55156/ --- (Updated Jan. 7, 2017, 1:34 a.m.) Review request for hive, Gopal V, Gunther

Re: Review Request 55156: Min-max runtime filtering

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55156/#review160516 --- Looked over the first couple pages of the first patch. I'll take

Re: Review Request 55156: Min-max runtime filtering

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55156/ --- (Updated Jan. 4, 2017, 10:12 p.m.) Review request for hive, Gopal V, Gunther

Re: Review Request 55156: Min-max runtime filtering

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55156/ --- (Updated Jan. 4, 2017, 4:39 a.m.) Review request for hive, Gopal V, Gunther

Re: Review Request 55156: Min-max runtime filtering

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55156/ --- (Updated Jan. 3, 2017, 11:03 p.m.) Review request for hive, Gopal V, Gunther

Review Request 55156: Min-max runtime filtering

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55156/ --- Review request for hive, Gopal V, Gunther Hagleitner, Jason Dere, Prasanth_J,