Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58181/ --- (Updated April 13, 2017, 9:43 p.m.) Review request for hive and Ashutosh Chauha

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

> On April 12, 2017, 5:52 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java > > Lines 355 (patched) > > > > > > Do we need to register _is

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58181/ --- (Updated April 12, 2017, 11:26 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58181/#review171761 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translato

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58181/#review171760 --- ql/src/test/queries/clientpositive/is_distinct_from.q Lines 1 (pa

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58181/ --- (Updated April 12, 2017, 12:14 a.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

> On April 5, 2017, 3:37 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g > > Lines 590-592 (patched) > > > > > > It will be good to not add extra tokens in grammar as

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

> On April 5, 2017, 3:37 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g > > Lines 590-592 (patched) > > > > > > It will be good to not add extra tokens in grammar as

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

> On April 6, 2017, 8:18 p.m., pengcheng xiong wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g > > Line 590 (original), 597 (patched) > > > > > > Can you also confirm the precedence of is d

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58181/#review171246 --- ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g L

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

> On April 5, 2017, 3:37 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g > > Lines 590-592 (patched) > > > > > > It will be good to not add extra tokens in grammar as

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58181/ --- (Updated April 6, 2017, 5:38 a.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58181/ --- (Updated April 5, 2017, 9:53 p.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

> On April 5, 2017, 3:37 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g > > Lines 590-592 (patched) > > > > > > It will be good to not add extra tokens in grammar as

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58181/#review171125 --- ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g L

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58181/ --- (Updated April 4, 2017, 11:05 p.m.) Review request for hive, Ashutosh Chauhan a

Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58181/ --- Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez. Bugs: HI