Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-07 Thread Ashutosh Chauhan
> On Feb. 6, 2018, 12:33 a.m., Ashutosh Chauhan wrote: > > standalone-metastore/src/main/thrift/hive_metastore.thrift > > Lines 332 (patched) > > > > > > 1. Seems like you want to use this to allow/disallow load

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-07 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/ --- (Updated Feb. 7, 2018, 6:04 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-06 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/ --- (Updated Feb. 6, 2018, 6:37 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-05 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/ --- (Updated Feb. 6, 2018, 7:03 a.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-05 Thread Deepak Jaiswal
> On Feb. 6, 2018, 1:26 a.m., Sergey Shelukhin wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/CustomPartitionVertex.java > > Lines 551 (patched) > > > > > > what's the logic behind "- 2"? needs to be

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-05 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/#review196846 ---

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-05 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/#review196844 ---

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-03 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/ --- (Updated Feb. 4, 2018, 2:14 a.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-02 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/ --- (Updated Feb. 2, 2018, 10:11 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-01 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/ --- (Updated Feb. 2, 2018, 12:38 a.m.) Review request for hive, Eugene Koifman,

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-01 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/ --- (Updated Feb. 2, 2018, 12:24 a.m.) Review request for hive, Eugene Koifman,

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-01 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/#review196659 ---

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-01 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/#review196654 --- standalone-metastore/src/main/thrift/hive_metastore.thrift Line

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-01 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/ --- (Updated Feb. 1, 2018, 8:49 p.m.) Review request for hive, Eugene Koifman,

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-01 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/ --- (Updated Feb. 1, 2018, 7:24 p.m.) Review request for hive, Eugene Koifman,

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-01-16 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/ --- (Updated Jan. 17, 2018, 2:27 a.m.) Review request for hive, Eugene Koifman and

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-01-16 Thread Deepak Jaiswal
> On Jan. 16, 2018, 11:06 p.m., Jason Dere wrote: > > - Why the need for the file name change even for non-bucketed tables? > > - With this patch, what happens to existing tables (bucketed and > > non-bucketed) which contain filenames that do not match the format used > > here? > > - How are

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-01-16 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/#review195503 --- - Why the need for the file name change even for non-bucketed

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-01-16 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/ --- (Updated Jan. 16, 2018, 9:31 a.m.) Review request for hive, Eugene Koifman and

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-01-12 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/ --- (Updated Jan. 13, 2018, 6:28 a.m.) Review request for hive, Eugene Koifman and

Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-01-12 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/ --- Review request for hive, Eugene Koifman and Jason Dere. Bugs: HIVE-18350