Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65217/ --- (Updated Jan. 25, 2018, 1:52 p.m.) Review request for hive, Marta Kuczora and P

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65217/#review196222 --- Ship it! Ship It! - Marta Kuczora On Jan. 23, 2018, 1:38 p.m

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

> On Jan. 22, 2018, 3:21 p.m., Marta Kuczora wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java > > Lines 223 (patched) > > > > > > When altering a partitio

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65217/ --- (Updated Jan. 23, 2018, 1:38 p.m.) Review request for hive, Marta Kuczora and P

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65217/#review195910 --- Thanks a lot Adam for the patch. It looks good to me, I just have

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

> On Jan. 19, 2018, 11:41 a.m., Peter Vary wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java > > Lines 122 (patched) > > > > > > nit: Why static? I like m

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65217/ --- (Updated Jan. 19, 2018, 2:29 p.m.) Review request for hive, Marta Kuczora and P

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65217/#review195795 --- Thanks for the patch Adam. Questions, and some minor comments. Th

Review Request 65217: Create tests to cover alterPartition and renamePartition methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65217/ --- Review request for hive, Marta Kuczora and Peter Vary. Bugs: HIVE-18468 htt