Re: Review Request 65276: HIVE-18516

2018-02-02 Thread Deepak Jaiswal
> On Feb. 2, 2018, 8 p.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java > > Line 3470 (original), 3484 (patched) > > > > > > Also, shouldn't it be an error if one of the input

Re: Review Request 65276: HIVE-18516

2018-02-02 Thread Eugene Koifman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65276/#review196725 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Line

Re: Review Request 65276: HIVE-18516

2018-02-01 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65276/ --- (Updated Feb. 1, 2018, 7:10 p.m.) Review request for hive, Eugene Koifman and

Re: Review Request 65276: HIVE-18516

2018-01-31 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65276/ --- (Updated Feb. 1, 2018, 2:59 a.m.) Review request for hive, Eugene Koifman and

Re: Review Request 65276: HIVE-18516

2018-01-31 Thread Deepak Jaiswal
> On Feb. 1, 2018, 2:24 a.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java > > Lines 3784 (patched) > > > > > > how is isFullAcidTable different from isAcid ? > > There

Re: Review Request 65276: HIVE-18516

2018-01-31 Thread Eugene Koifman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65276/#review196609 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines

Re: Review Request 65276: HIVE-18516

2018-01-31 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65276/ --- (Updated Jan. 31, 2018, 10 p.m.) Review request for hive, Eugene Koifman and

Re: Review Request 65276: HIVE-18516

2018-01-31 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65276/ --- (Updated Jan. 31, 2018, 7:23 p.m.) Review request for hive, Eugene Koifman and

Re: Review Request 65276: HIVE-18516

2018-01-30 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65276/ --- (Updated Jan. 30, 2018, 6:49 p.m.) Review request for hive, Eugene Koifman and

Re: Review Request 65276: HIVE-18516

2018-01-29 Thread Deepak Jaiswal
> On Jan. 30, 2018, 3:09 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java > > Lines 3821 (patched) > > > > > > So only non-bucketed ACID tables get the file rename to 00_0

Re: Review Request 65276: HIVE-18516

2018-01-29 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65276/#review196499 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines

Re: Review Request 65276: HIVE-18516

2018-01-29 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65276/ --- (Updated Jan. 29, 2018, 11:10 p.m.) Review request for hive, Eugene Koifman

Re: Review Request 65276: HIVE-18516

2018-01-24 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65276/#review196192 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines

Review Request 65276: HIVE-18516

2018-01-22 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65276/ --- Review request for hive, Eugene Koifman and Jason Dere. Bugs: HIVE-18516