Re: Review Request 65778: HIVE-18726 Implement DEFAULT constraint

2018-03-02 Thread Vineet Garg
> On Feb. 27, 2018, 2:07 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/DefaultConstraint.java > > Lines 34 (patched) > > > > > > Is there a reason to implement Serializable ? > >

Re: Review Request 65778: HIVE-18726 Implement DEFAULT constraint

2018-03-02 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65778/ --- (Updated March 3, 2018, 1:01 a.m.) Review request for hive, Ashutosh Chauhan

Re: Review Request 65778: HIVE-18726 Implement DEFAULT constraint

2018-02-27 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65778/#review198327 --- ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java

Re: Review Request 65778: HIVE-18726 Implement DEFAULT constraint

2018-02-26 Thread Vineet Garg
> On Feb. 27, 2018, 2:07 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java > > Lines 409 (patched) > > > > > > What about other types: char, varchar, timestamp, tstz,

Re: Review Request 65778: HIVE-18726 Implement DEFAULT constraint

2018-02-26 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65778/#review198298 --- ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java

Review Request 65778: HIVE-18726 Implement DEFAULT constraint

2018-02-23 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65778/ --- Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez. Bugs: