Re: Review Request 67954: HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded HMS instance

2018-08-10 Thread Alexander Kolbasov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67954/
---

(Updated Aug. 10, 2018, 9:31 p.m.)


Review request for hive, Alan Gates, Peter Vary, Sahil Takiar, and Vihang 
Karajgaonkar.


Changes
---

Addressed comment from Alan Gates.


Bugs: HIVE-20194
https://issues.apache.org/jira/browse/HIVE-20194


Repository: hive-git


Description
---

HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded 
HMS instance


Diffs (updated)
-

  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
 a53d4be03d695bf2176436967026757391531bc9 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
 91c86a749c7afb06737c850e57f60820710c51f5 
  
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java
 34055d2d4d39dc63d505a5ef95d190aa80a49d14 


Diff: https://reviews.apache.org/r/67954/diff/6/

Changes: https://reviews.apache.org/r/67954/diff/5-6/


Testing
---


Thanks,

Alexander Kolbasov

Re: Review Request 67954: HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded HMS instance

2018-08-10 Thread Alan Gates 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67954/#review207091
---




standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
Lines 110 (patched)


You define these two values both here and in HiveMetaStoreClientPreCatalog. 
 Wouldn't it make more sense to define them once in a shared location (like 
IMetaStoreClient maybe)?


- Alan Gates


On Aug. 9, 2018, 10:35 p.m., Alexander Kolbasov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67954/
> ---
> 
> (Updated Aug. 9, 2018, 10:35 p.m.)
> 
> 
> Review request for hive, Alan Gates, Peter Vary, Sahil Takiar, and Vihang 
> Karajgaonkar.
> 
> 
> Bugs: HIVE-20194
> https://issues.apache.org/jira/browse/HIVE-20194
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded 
> HMS instance
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
>  a53d4be03d695bf2176436967026757391531bc9 
>   
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
>  91c86a749c7afb06737c850e57f60820710c51f5 
>   
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java
>  34055d2d4d39dc63d505a5ef95d190aa80a49d14 
> 
> 
> Diff: https://reviews.apache.org/r/67954/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Kolbasov
> 
>

Re: Review Request 67954: HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded HMS instance

2018-08-10 Thread Vihang Karajgaonkar via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67954/#review207090
---


Ship it!




Ship It!

- Vihang Karajgaonkar


On Aug. 9, 2018, 10:35 p.m., Alexander Kolbasov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67954/
> ---
> 
> (Updated Aug. 9, 2018, 10:35 p.m.)
> 
> 
> Review request for hive, Alan Gates, Peter Vary, Sahil Takiar, and Vihang 
> Karajgaonkar.
> 
> 
> Bugs: HIVE-20194
> https://issues.apache.org/jira/browse/HIVE-20194
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded 
> HMS instance
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
>  a53d4be03d695bf2176436967026757391531bc9 
>   
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
>  91c86a749c7afb06737c850e57f60820710c51f5 
>   
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java
>  34055d2d4d39dc63d505a5ef95d190aa80a49d14 
> 
> 
> Diff: https://reviews.apache.org/r/67954/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Kolbasov
> 
>

Re: Review Request 67954: HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded HMS instance

2018-08-09 Thread Alexander Kolbasov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67954/
---

(Updated Aug. 9, 2018, 10:35 p.m.)


Review request for hive, Alan Gates, Peter Vary, Sahil Takiar, and Vihang 
Karajgaonkar.


Changes
---

Fixed HiveMetaStoreClientPreCatalog to use the new signature for 
newRetryingHMSHandler


Bugs: HIVE-20194
https://issues.apache.org/jira/browse/HIVE-20194


Repository: hive-git


Description
---

HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded 
HMS instance


Diffs (updated)
-

  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
 a53d4be03d695bf2176436967026757391531bc9 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
 91c86a749c7afb06737c850e57f60820710c51f5 
  
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java
 34055d2d4d39dc63d505a5ef95d190aa80a49d14 


Diff: https://reviews.apache.org/r/67954/diff/5/

Changes: https://reviews.apache.org/r/67954/diff/4-5/


Testing
---


Thanks,

Alexander Kolbasov

Re: Review Request 67954: HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded HMS instance

2018-07-20 Thread Alexander Kolbasov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67954/
---

(Updated July 20, 2018, 6:15 p.m.)


Review request for hive, Alan Gates, Peter Vary, Sahil Takiar, and Vihang 
Karajgaonkar.


Changes
---

Fixed incorrect last reviewboard update.


Summary (updated)
-

HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded 
HMS instance


Bugs: HIVE-20194
https://issues.apache.org/jira/browse/HIVE-20194


Repository: hive-git


Description
---

HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded 
HMS instance


Diffs (updated)
-

  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
 47f819b60a6c7eb2acac9217724e67a976341093 
  
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
 92e280570f44cd56fe87c3123001b9263d28186f 
  
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java
 d91f737450efa9de6db3806401072645c96bbb7d 


Diff: https://reviews.apache.org/r/67954/diff/4/

Changes: https://reviews.apache.org/r/67954/diff/3-4/


Testing
---


Thanks,

Alexander Kolbasov

Re: Review Request 67954: HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded HMS instance

2018-07-20 Thread Alexander Kolbasov 


> On July 19, 2018, 12:25 a.m., Vihang Karajgaonkar wrote:
> > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
> > Lines 111-116 (patched)
> > 
> >
> > Do you think we can get these values from a config instead of hard 
> > coding?

Hmm, it is possible, I am not sure whether it is worth introducing a config 
variable fo this. This is a one-off case. Do you think it is better to make 
configurable?


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67954/#review206230
---


On July 18, 2018, 12:10 a.m., Alexander Kolbasov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67954/
> ---
> 
> (Updated July 18, 2018, 12:10 a.m.)
> 
> 
> Review request for hive, Alan Gates, Peter Vary, Sahil Takiar, and Vihang 
> Karajgaonkar.
> 
> 
> Bugs: HIVE-20194
> https://issues.apache.org/jira/browse/HIVE-20194
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded 
> HMS instance
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
>  47f819b60a6c7eb2acac9217724e67a976341093 
>   
> standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
>  92e280570f44cd56fe87c3123001b9263d28186f 
>   
> standalone-metastore/metastore-common/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java
>  d91f737450efa9de6db3806401072645c96bbb7d 
> 
> 
> Diff: https://reviews.apache.org/r/67954/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Kolbasov
> 
>

Re: Review Request 67954: HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded HMS instance

2018-07-18 Thread Vihang Karajgaonkar via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67954/#review206230
---




standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
Lines 111-116 (patched)


Do you think we can get these values from a config instead of hard coding?


- Vihang Karajgaonkar


On July 18, 2018, 12:10 a.m., Alexander Kolbasov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67954/
> ---
> 
> (Updated July 18, 2018, 12:10 a.m.)
> 
> 
> Review request for hive, Alan Gates, Peter Vary, Sahil Takiar, and Vihang 
> Karajgaonkar.
> 
> 
> Bugs: HIVE-20194
> https://issues.apache.org/jira/browse/HIVE-20194
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded 
> HMS instance
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
>  47f819b60a6c7eb2acac9217724e67a976341093 
>   
> standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
>  92e280570f44cd56fe87c3123001b9263d28186f 
>   
> standalone-metastore/metastore-common/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java
>  d91f737450efa9de6db3806401072645c96bbb7d 
> 
> 
> Diff: https://reviews.apache.org/r/67954/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Kolbasov
> 
>

Review Request 67954: HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded HMS instance

2018-07-17 Thread Alexander Kolbasov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67954/
---

Review request for hive, Alan Gates, Peter Vary, Sahil Takiar, and Vihang 
Karajgaonkar.


Bugs: HIVE-20194
https://issues.apache.org/jira/browse/HIVE-20194


Repository: hive-git


Description
---

HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded 
HMS instance


Diffs
-

  
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
 47f819b60a6c7eb2acac9217724e67a976341093 
  
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
 92e280570f44cd56fe87c3123001b9263d28186f 
  
standalone-metastore/metastore-common/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java
 d91f737450efa9de6db3806401072645c96bbb7d 


Diff: https://reviews.apache.org/r/67954/diff/1/


Testing
---


Thanks,

Alexander Kolbasov