Re: Review Request 68011: HIVE-19770 Support for CBO for queries with multiple same columns in select

2018-07-30 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68011/#review206598 --- ql/src/test/results/clientpositive/bucketsortoptimize_insert_4.q.

Re: Review Request 68011: HIVE-19770 Support for CBO for queries with multiple same columns in select

2018-07-29 Thread Vineet Garg
> On July 24, 2018, 11:34 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/bucketsortoptimize_insert_4.q.out > > Lines 84-85 (patched) > > > > > > This extra operator will result in perf loss. We d

Re: Review Request 68011: HIVE-19770 Support for CBO for queries with multiple same columns in select

2018-07-27 Thread Vineet Garg
> On July 24, 2018, 11:34 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java > > Line 4070 (original), 4070 (patched) > > > > > > Looks like there is no need to duplica

Re: Review Request 68011: HIVE-19770 Support for CBO for queries with multiple same columns in select

2018-07-27 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68011/ --- (Updated July 27, 2018, 11:14 p.m.) Review request for hive, Ashutosh Chauhan a

Re: Review Request 68011: HIVE-19770 Support for CBO for queries with multiple same columns in select

2018-07-24 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68011/#review206425 --- ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java L

Review Request 68011: HIVE-19770 Support for CBO for queries with multiple same columns in select

2018-07-22 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68011/ --- Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez. Bugs: HI