Re: Review Request 72290: HIVE-23067: Use batch DB calls in TxnHandler for commitTxn and abortTxns

2020-04-02 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72290/#review220186 --- Ship it! Ship It! - Denys Kuzmenko On April 1, 2020, 6:53 a.

Re: Review Request 72290: HIVE-23067: Use batch DB calls in TxnHandler for commitTxn and abortTxns

2020-04-02 Thread Peter Vary via Review Board
> On ápr. 1, 2020, 7:38 de, Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 4295 (patched) > > > > > > Please extract this

Re: Review Request 72290: HIVE-23067: Use batch DB calls in TxnHandler for commitTxn and abortTxns

2020-04-01 Thread Marton Bod
> On April 1, 2020, 9:02 a.m., Peter Vary wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 1379 (patched) > > > > > > Will this issue unne

Re: Review Request 72290: HIVE-23067: Use batch DB calls in TxnHandler for commitTxn and abortTxns

2020-04-01 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72290/#review220167 --- standalone-metastore/metastore-server/src/main/java/org/apache/ha

Re: Review Request 72290: HIVE-23067: Use batch DB calls in TxnHandler for commitTxn and abortTxns

2020-04-01 Thread Marton Bod
> On April 1, 2020, 7:38 a.m., Denys Kuzmenko wrote: > > LGTM, just a few comments. Thanks for the review! > On April 1, 2020, 7:38 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Line 1300 (original),

Re: Review Request 72290: HIVE-23067: Use batch DB calls in TxnHandler for commitTxn and abortTxns

2020-04-01 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72290/#review220164 --- LGTM, just a few comments. standalone-metastore/metastore-server

Review Request 72290: HIVE-23067: Use batch DB calls in TxnHandler for commitTxn and abortTxns

2020-03-31 Thread Marton Bod
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72290/ --- Review request for hive, Denys Kuzmenko and Peter Vary. Repository: hive-git