On 5/7/06, Nick Kew <[EMAIL PROTECTED]> wrote:
On Sunday 07 May 2006 23:07, Garrett Rooney wrote:
> On 5/7/06, Nick Kew <[EMAIL PROTECTED]> wrote:
> > Now, what about a platform that HAS_PTHREAD_KILL, but which uses some
> > other form of threading in its APR (isn't that at least an option on som
On 5/7/06, Nick Kew <[EMAIL PROTECTED]> wrote:
On Sunday 07 May 2006 22:35, Jeff Trawick wrote:
> "Remove some obsolete declarations and comments from scoreboard.h. [...]" ?
>
> The scoreboard looks the same AFAICT ;) (Some programmers may care.)
There's the memory fix too.
so extra memory
On Sunday 07 May 2006 23:07, Garrett Rooney wrote:
> On 5/7/06, Nick Kew <[EMAIL PROTECTED]> wrote:
> > Now, what about a platform that HAS_PTHREAD_KILL, but which uses some
> > other form of threading in its APR (isn't that at least an option on some
> > FreeBSD versions?) Wouldn't this break hor
On Sunday 07 May 2006 22:35, Jeff Trawick wrote:
> "Remove some obsolete declarations and comments from scoreboard.h. [...]" ?
>
> The scoreboard looks the same AFAICT ;) (Some programmers may care.)
There's the memory fix too. But it's also a placeholder for the two remaining
patches, which a
+---+
| Bugzilla Bug ID |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned
+---+
| Bugzilla Bug ID |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned
On 5/7/06, Nick Kew <[EMAIL PROTECTED]> wrote:
Now, what about a platform that HAS_PTHREAD_KILL, but which uses some
other form of threading in its APR (isn't that at least an option on some
FreeBSD versions?) Wouldn't this break horribly when it pthread_kills a
non-pthread? Couldn't it even h
On 5/7/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
Author: niq
Date: Sun May 7 14:07:14 2006
New Revision: 404851
URL: http://svn.apache.org/viewcvs?rev=404851&view=rev
Log:
Note scoreboard stuff in changes; leave the 'difficult' patches
to see if they attract any more review.
Modified:
On 5/7/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
Author: niq
Date: Sun May 7 14:01:48 2006
New Revision: 404849
URL: http://svn.apache.org/viewcvs?rev=404849&view=rev
Log:
Tidy up scoreboard.h (Chris Darroch)
cool; forgot to +1 this and a couple of others
On 5/7/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
Author: niq
Date: Sun May 7 14:03:39 2006
New Revision: 404850
URL: http://svn.apache.org/viewcvs?rev=404850&view=rev
Log:
Initialise server generation (Chris Darroch)
Modified:
httpd/httpd/trunk/server/mpm/experimental/event/event.c
On Fri, May 05, 2006 at 11:20:14PM +0100, Nick Kew wrote:
> Looks right for ap_init_scoreboard, and there's nothing else relevant
> in scoreboard.c. A quick grep suggests it's globally right, so +1.
Same here, afaict the patch gets it right.
--
Colm MacCárthaighPublic Ke
On Thursday 04 May 2006 18:48, Chris Darroch wrote:
> -/* fork didn't succeed. Fix the scoreboard or else
> - * it will say SERVER_STARTING forever and ever
> +/* fork didn't succeed. There's no need to touch the scoreboard;
> + * if we were trying to replace a fai
On Thursday 04 May 2006 19:16, Chris Darroch wrote:
> +#ifdef HAVE_PTHREAD_KILL
> +unblock_signal(WORKER_SIGNAL);
> +apr_signal(WORKER_SIGNAL, dummy_signal_handler);
> +#endif
> +
OK, unblock a signal. This happens after child_init, but presumably
won't interfere with existing modules 'c
On Sunday 07 May 2006 16:08, Ruediger Pluem wrote:
> On 05/07/2006 04:52 PM, wrote:
> > Author: niq
> >
> >
> >*) core: Prevent reading uninitialized memory while reading a line of
> > - protocol input. PR 39282. [Davi Arnaut ]
> > + protocol input. PR 39282. [Davi Arnaut ]
>
> Just
On 05/07/2006 04:52 PM, wrote:
> Author: niq
>
>*) core: Prevent reading uninitialized memory while reading a line of
> - protocol input. PR 39282. [Davi Arnaut ]
> + protocol input. PR 39282. [Davi Arnaut ]
Just curious: Why did you remove the dots? So far we have only removed
15 matches
Mail list logo