RE: Upgrade Summary

2015-12-11 Thread Bert Huijben
> -Original Message- > From: Stefan Eissing [mailto:stefan.eiss...@greenbytes.de] > Sent: vrijdag 11 december 2015 10:20 > To: dev@httpd.apache.org > Subject: Re: Upgrade Summary > Regarding request bodies: > - websocket will never switch on request bodies > - h2c currently does not, but

Re: [VOTE] Release Apache httpd 2.4.18 as GA

2015-12-11 Thread Yann Ylavic
On Tue, Dec 8, 2015 at 9:38 PM, Jim Jagielski wrote: > > I'm calling a VOTE on releasing these as Apache httpd 2.4.18 GA. > > [X] +1: Good to go md5/sha1/pgp OK Tested on: * Debian 8.2 (Jessie) => All tests passed. * Debian 7.9 (Wheezy) => All tests passed. * Debian 6.0.10

Re: Upgrade Summary

2015-12-11 Thread Yann Ylavic
On Fri, Dec 11, 2015 at 10:20 AM, Stefan Eissing wrote: > >> Am 11.12.2015 um 02:22 schrieb Yann Ylavic : >> >> On Thu, Dec 10, 2015 at 11:46 AM, Stefan Eissing >> wrote: >>> Given all the input on this thread, I

Re: svn commit: r1719403 - in /httpd/httpd/trunk: CHANGES modules/http2/h2_conn.c modules/http2/h2_h2.c modules/http2/h2_io.c modules/http2/h2_io.h modules/http2/h2_mplx.c modules/http2/h2_stream.c mo

2015-12-11 Thread Yann Ylavic
Hi Stefan, On Fri, Dec 11, 2015 at 1:57 PM, wrote: > Author: icing > Date: Fri Dec 11 12:57:32 2015 > New Revision: 1719403 > > URL: http://svn.apache.org/viewvc?rev=1719403=rev > Log: > fixed window update on chunked uploads, moved handling of chunking to later > stage Is

Re: svn commit: r1719403 - in /httpd/httpd/trunk: CHANGES modules/http2/h2_conn.c modules/http2/h2_h2.c modules/http2/h2_io.c modules/http2/h2_io.h modules/http2/h2_mplx.c modules/http2/h2_stream.c mo

2015-12-11 Thread Stefan Eissing
> Am 11.12.2015 um 14:55 schrieb Yann Ylavic : > > Hi Stefan, > > On Fri, Dec 11, 2015 at 1:57 PM, wrote: >> Author: icing >> Date: Fri Dec 11 12:57:32 2015 >> New Revision: 1719403 >> >> URL: http://svn.apache.org/viewvc?rev=1719403=rev >> Log: >>

Re: [VOTE] Release Apache httpd 2.4.18 as GA

2015-12-11 Thread Gregg Smith
+1 Various flavors of VC/Windows On 12/8/2015 12:38 PM, Jim Jagielski wrote: The pre-release test tarballs for Apache httpd 2.4.18 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.18 GA. [ ] +1: Good to go [

[RESULT] Was: [VOTE] Release Apache httpd 2.4.18 as GA

2015-12-11 Thread Jim Jagielski
With more than the required 3 +1 (binding) votes, I call the VOTE closed with the result that the VOTE PASSES. I will start moving the artifacts so the mirrors can collect them over the weekend. > On Dec 8, 2015, at 3:38 PM, Jim Jagielski wrote: > > The pre-release test

Re: Upgrade Summary

2015-12-11 Thread Yann Ylavic
Hi Jacob, On Fri, Dec 11, 2015 at 11:47 PM, Jacob Champion wrote: > > This is where we disagree, for the case of WebSocket and WebSocket alone. > RFC 6455 4.2.1: > >The client's opening handshake consists of the following parts. If >the server, while reading the

Re: [VOTE] Release Apache httpd 2.4.18 as GA

2015-12-11 Thread Yann Ylavic
On Fri, Dec 11, 2015 at 9:21 PM, Rainer Jung wrote: > > - three compiler warning (2 regressions, one old) [] > modules/ssl/ssl_engine_kernel.c:414:22: warning: variable 'hssc' set > but not used [-Wunused-but-set-variable] This one is harmless ('hssc' redeclared

Re: Upgrade Summary

2015-12-11 Thread William A Rowe Jr
On Fri, Dec 11, 2015 at 2:55 PM, Jacob Champion wrote: > On 12/11/2015 12:12 PM, William A Rowe Jr wrote: > >> On Fri, Dec 11, 2015 at 1:13 PM, Jacob Champion > > wrote: >> >> On 12/11/2015 02:36 AM, Bert Huijben

Re: [VOTE] Release Apache httpd 2.4.18 as GA

2015-12-11 Thread Yann Ylavic
On Fri, Dec 11, 2015 at 10:57 PM, Yann Ylavic wrote: > On Fri, Dec 11, 2015 at 10:39 PM, Yann Ylavic wrote: >> On Fri, Dec 11, 2015 at 9:21 PM, Rainer Jung wrote: >>> >>> - three compiler warning (2 regressions, one old) >>

Re: Upgrade Summary

2015-12-11 Thread Yann Ylavic
On Sat, Dec 12, 2015 at 12:41 AM, Yann Ylavic wrote: > Hi Jacob, > > On Fri, Dec 11, 2015 at 11:47 PM, Jacob Champion wrote: >> >> This is where we disagree, for the case of WebSocket and WebSocket alone. >> RFC 6455 4.2.1: >> >>The client's

Re: [VOTE] Release Apache httpd 2.4.18 as GA

2015-12-11 Thread Yann Ylavic
On Fri, Dec 11, 2015 at 10:39 PM, Yann Ylavic wrote: > On Fri, Dec 11, 2015 at 9:21 PM, Rainer Jung wrote: >> >> - three compiler warning (2 regressions, one old) > [] >> modules/ssl/ssl_engine_kernel.c:414:22: warning: variable 'hssc' set

Re: Upgrade Summary

2015-12-11 Thread Jacob Champion
n 12/11/2015 02:24 PM, William A Rowe Jr wrote: On Fri, Dec 11, 2015 at 2:55 PM, Jacob Champion > wrote: That additional constraint doesn't conflict with any part of HTTP/1.1, as far as I can tell. Returning 4xx directly to an Upgrade

RE: Upgrade Summary

2015-12-11 Thread Bert Huijben
If you request an upgrade to TLS on your initial request, upgrading with a body might still make sense. Especially if the server would respond with a 401. But also if the request can be public, but the response needs to be secured. If we blindly ignore the upgrade as ‘doesn’t make sense’, the

RE: Upgrade Summary

2015-12-11 Thread Bert Huijben
I’m not talking about why the client does want the upgrade… Perhaps it doesn’t know if port 443 uses TLS or hosts the same content. In general it is just a lucky guess that it does have the same content. The Alt-Svc spec might help here, but currently this still requires the admin to configure

Re: Upgrade Summary

2015-12-11 Thread Stefan Eissing
> Am 11.12.2015 um 02:22 schrieb Yann Ylavic : > > On Thu, Dec 10, 2015 at 11:46 AM, Stefan Eissing > wrote: >> Given all the input on this thread, I arrive at the following pseudo code: > > Thanks for _compiling_ this thread, quite

Re: mod_http2 memory footprint

2015-12-11 Thread Stefan Eissing
The "slowly growing" part is certainly not good. For 2.4.18, my main concern was stability and some important new features. I had a look at memory consumption but could not find anything that explained the growth well. Definitely needs more attention in the future... > Am 10.12.2015 um 10:25

Re: [VOTE] Release Apache httpd 2.4.18 as GA

2015-12-11 Thread Rainer Canavan
2015-12-11 19:59 GMT+01:00 Jim Jagielski : > Just a quick reminder that the voting closes in about 90mins. > > tia! builds and works according to my casual tests on IRIX mips as n32. rainer

Re: svn commit: r1719403 - in /httpd/httpd/trunk: CHANGES modules/http2/h2_conn.c modules/http2/h2_h2.c modules/http2/h2_io.c modules/http2/h2_io.h modules/http2/h2_mplx.c modules/http2/h2_stream.c mo

2015-12-11 Thread Yann Ylavic
On Fri, Dec 11, 2015 at 2:57 PM, Stefan Eissing wrote: > >> Am 11.12.2015 um 14:55 schrieb Yann Ylavic : >> >> Hi Stefan, >> >> On Fri, Dec 11, 2015 at 1:57 PM, wrote: >>> Author: icing >>> Date: Fri Dec 11 12:57:32 2015 >>>

Re: Upgrade Summary

2015-12-11 Thread Jacob Champion
On 12/11/2015 02:36 AM, Bert Huijben wrote: -Original Message- From: Stefan Eissing [mailto:stefan.eiss...@greenbytes.de] Protocol implementations should make up their minds in the "propose" phase, I think, because once a protocol gets selected, the upgrade *should* succeed unless the

Re: Upgrade Summary

2015-12-11 Thread William A Rowe Jr
On Fri, Dec 11, 2015 at 1:13 PM, Jacob Champion wrote: > On 12/11/2015 02:36 AM, Bert Huijben wrote: > >> -Original Message- >>> From: Stefan Eissing [mailto:stefan.eiss...@greenbytes.de] >>> Protocol implementations should make up their minds in the "propose" >>>

Re: [VOTE] Release Apache httpd 2.4.18 as GA

2015-12-11 Thread Rainer Jung
Am 08.12.2015 um 21:38 schrieb Jim Jagielski: The pre-release test tarballs for Apache httpd 2.4.18 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.18 GA. [X] +1: Good to go [ ] +0: meh [ ] -1: Danger Will

Re: [VOTE] Release Apache httpd 2.4.18 as GA

2015-12-11 Thread Jim Jagielski
Just a quick reminder that the voting closes in about 90mins. tia! > On Dec 8, 2015, at 3:38 PM, Jim Jagielski wrote: > > The pre-release test tarballs for Apache httpd 2.4.18 can be found > at the usual place: > > http://httpd.apache.org/dev/dist/ > > I'm calling a

Re: Upgrade Summary

2015-12-11 Thread Stefan Eissing
Jacob, thanks for the code! I will let this and my pseudo code stew over the weekend and then probably next week start the changes to upgrade handling. //Stefan > Am 10.12.2015 um 23:18 schrieb Jacob Champion : > > Okay, I finally have actual code to share. This is the

Re: Upgrade Summary

2015-12-11 Thread Jacob Champion
On 12/11/2015 12:12 PM, William A Rowe Jr wrote: On Fri, Dec 11, 2015 at 1:13 PM, Jacob Champion > wrote: On 12/11/2015 02:36 AM, Bert Huijben wrote: Not upgrading is 100% better than failing. ...except for those protocols for